Skip Menu |
Report information
Id: 128427
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: mistydemeo [at] gmail.com
Cc:
AdminCc:

Operating System: darwin
PatchStatus: (no value)
Severity: High
Type: library
Perl Version: 5.24.0
Fixed In: (no value)



Date: Fri, 17 Jun 2016 13:21:50 -0700
To: perlbug [...] perl.org
From: Misty De Meo <mistydemeo [...] gmail.com>
Subject: perl does not build on Darwin platforms with clock_gettime
Download (untitled) / with headers
text/plain 4.2k
This is a bug report for perl from mistydemeo@gmail.com,
generated with the help of perlbug 1.40 running under perl 5.24.0.


-----------------------------------------------------------------
[Please describe your issue here]

Time::HiRes contains code to emulate clock_gettime on Darwin, which
historically has not included that function. Most of this is guarded
by #ifdefs which check for both Darwin and the absense of clock_gettime.
However, the latter isn't applied consistently, resulting in build
errors on Darwin versions which include a native clock_gettime.

The attached patch fixes this by adjusting one #ifdef.

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=library
    severity=high
    Type=Patch
    PatchStatus=HasPatch
    module=Time::HiRes
---
Site configuration information for perl 5.24.0:

Configured by brew at Sat Jun  4 10:59:48 BST 2016.

Summary of my perl5 (revision 5 version 24 subversion 0) configuration:

  Platform:
    osname=darwin, osvers=15.5.0, archname=darwin-thread-multi-2level
    uname='darwin elcapitanvm.local 15.5.0 darwin kernel version 15.5.0: tue apr 19 18:36:36 pdt 2016; root:xnu-3248.50.21~8release_x86_64 x86_64 '
    config_args='-des -Dprefix=/usr/local/Cellar/perl/5.24.0_1 -Dprivlib=/usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0 -Dsitelib=/usr/local/Cellar/perl/5.24.0_1/lib/perl5/site_perl/5.24.0 -Dotherlibdirs=/usr/local/lib/perl5/site_perl/5.24.0 -Dperlpath=/usr/local/opt/perl/bin/perl -Dstartperl=#!/usr/local/opt/perl/bin/perl -Dman1dir=/usr/local/Cellar/perl/5.24.0_1/share/man/man1 -Dman3dir=/usr/local/Cellar/perl/5.24.0_1/share/man/man3 -Duseshrplib -Duselargefiles -Dusethreads'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.11 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV',
    optimize='-O3',
    cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.11 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion='', gccversion='4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -mmacosx-version-min=10.11 -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/include/libxml2 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/7.3.0/lib /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/lib /usr/lib
    libs=-lpthread -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=, so=dylib, useshrplib=true, libperl=libperl.dylib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags=' -mmacosx-version-min=10.11 -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.24.0:
    /usr/local/Cellar/perl/5.24.0_1/lib/perl5/site_perl/5.24.0/darwin-thread-multi-2level
    /usr/local/Cellar/perl/5.24.0_1/lib/perl5/site_perl/5.24.0
    /usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0/darwin-thread-multi-2level
    /usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0
    /usr/local/lib/perl5/site_perl/5.24.0
    .

---
Environment for perl 5.24.0:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/mistydemeo
    LANG=en_CA.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/Users/mistydemeo/.rbenv/shims:/Users/mistydemeo/.nodenv/shims:/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/fish

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
On Fri Jun 17 13:22:07 2016, mistydemeo@gmail.com wrote: Show quoted text
> This is a bug report for perl from mistydemeo@gmail.com, > generated with the help of perlbug 1.40 running under perl 5.24.0. > > > ----------------------------------------------------------------- > [Please describe your issue here] > > Time::HiRes contains code to emulate clock_gettime on Darwin, which > historically has not included that function. Most of this is guarded > by #ifdefs which check for both Darwin and the absense of > clock_gettime. > However, the latter isn't applied consistently, resulting in build > errors on Darwin versions which include a native clock_gettime. > > The attached patch fixes this by adjusting one #ifdef. >
It's not clear to me what source code you have drawn your patch against. When I ack or grep the Perl 5 core distribution, I find no directory named 'rts'. Nor do I find the string 'darwin_HOST_OS' in any source code. ##### $ ack '\brts\b' MANIFEST [no output] $ find . -type d -name '*rts*' ./cpan/Devel-PPPort/parts $ ack darwin_HOST_OS . [no output] ##### Can you clarify? Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Date: Sat, 18 Jun 2016 18:57:47 +0200
To: perl5-porters [...] perl.org
From: Lukas Mai <plokinom [...] gmail.com>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
Download (untitled) / with headers
text/plain 1.4k
Am 18.06.2016 um 14:06 schrieb James E Keenan via RT: Show quoted text
> On Fri Jun 17 13:22:07 2016, mistydemeo@gmail.com wrote:
>> This is a bug report for perl from mistydemeo@gmail.com, >> generated with the help of perlbug 1.40 running under perl 5.24.0. >> >> >> ----------------------------------------------------------------- >> [Please describe your issue here] >> >> Time::HiRes contains code to emulate clock_gettime on Darwin, which >> historically has not included that function. Most of this is guarded >> by #ifdefs which check for both Darwin and the absense of >> clock_gettime. >> However, the latter isn't applied consistently, resulting in build >> errors on Darwin versions which include a native clock_gettime. >> >> The attached patch fixes this by adjusting one #ifdef. >>
> > It's not clear to me what source code you have drawn your patch against. > > When I ack or grep the Perl 5 core distribution, I find no directory named 'rts'. Nor do I find the string 'darwin_HOST_OS' in any source code. > > ##### > $ ack '\brts\b' MANIFEST > [no output] > > $ find . -type d -name '*rts*' > ./cpan/Devel-PPPort/parts > > $ ack darwin_HOST_OS . > [no output] > ##### > > Can you clarify?
Wow, this is pretty amazing. I have no idea how this happened, but the patch seems to be against https://github.com/ghc/ghc/blob/master/rts/posix/GetTime.c, which is the runtime system of ghc (the Glasgow Haskell Compiler). -- Lukas Mai <plokinom@gmail.com>
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 530b
On Sat Jun 18 09:58:28 2016, plokinom@gmail.com wrote: Show quoted text
> > Wow, this is pretty amazing. I have no idea how this happened, but the > patch seems to be against > https://github.com/ghc/ghc/blob/master/rts/posix/GetTime.c, which is > the > runtime system of ghc (the Glasgow Haskell Compiler).
Forwarding a message from the original reporter: | GHC has an almost identical bug, and when reporting the bug to perl, I | inadvertently attached the GHC patch instead of the perl patch. I've | attached the correct patch to this email.
Subject: 0001-Time-HiRes-fix-Darwins-with-clock_gettime.patch
From 76264435f3fcc23c80831f940059bfb80122dcc9 Mon Sep 17 00:00:00 2001 From: Misty De Meo <mistydemeo@github.com> Date: Fri, 17 Jun 2016 12:49:44 -0700 Subject: [PATCH] Time::HiRes: fix Darwins with clock_gettime Not all of the Darwin time code was guarded by the same set of #ifdefs, leading to bugs on Darwin platforms with clock_gettime where a struct would not be defined but would still be used elsewhere. --- dist/Time-HiRes/HiRes.xs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/Time-HiRes/HiRes.xs b/dist/Time-HiRes/HiRes.xs index 38ca0dc..ed60336 100644 --- a/dist/Time-HiRes/HiRes.xs +++ b/dist/Time-HiRes/HiRes.xs @@ -940,7 +940,7 @@ BOOT: } # endif #endif -#if defined(PERL_DARWIN) +#if defined(PERL_DARWIN) && !defined(CLOCK_REALTIME) # ifdef USE_ITHREADS MUTEX_INIT(&darwin_time_mutex); # endif -- 2.9.0
Date: Fri, 17 Jun 2016 13:24:43 -0700
To: perlbug-followup [...] perl.org
From: Misty De Meo <mistydemeo [...] gmail.com>
Subject: Re: [perl #128427] perlbug AutoReply: perl does not build on Darwin platforms with clock_gettime
Apologies, it appears I attached the incorrect patch. The correct patch is attached.

Message body is not shown because sender requested not to inline it.

Date: Sat, 18 Jun 2016 14:45:48 -0700
To: perlbug-followup [...] perl.org
From: Misty De Meo <mistydemeo [...] gmail.com>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
Download (untitled) / with headers
text/plain 1.7k
Hi, Lukas, Apologies for the incorrect patch. GHC had nearly the same bug, and I inadvertantly attached the incorrect patch. I attempted to reply earlier with the correct patch, but the tracker has been dropping my messages. On Sat, Jun 18, 2016 at 9:58 AM, Lukas Mai via RT <perlbug-followup@perl.org> wrote: Show quoted text
> Am 18.06.2016 um 14:06 schrieb James E Keenan via RT:
>> On Fri Jun 17 13:22:07 2016, mistydemeo@gmail.com wrote:
>>> This is a bug report for perl from mistydemeo@gmail.com, >>> generated with the help of perlbug 1.40 running under perl 5.24.0. >>> >>> >>> ----------------------------------------------------------------- >>> [Please describe your issue here] >>> >>> Time::HiRes contains code to emulate clock_gettime on Darwin, which >>> historically has not included that function. Most of this is guarded >>> by #ifdefs which check for both Darwin and the absense of >>> clock_gettime. >>> However, the latter isn't applied consistently, resulting in build >>> errors on Darwin versions which include a native clock_gettime. >>> >>> The attached patch fixes this by adjusting one #ifdef. >>>
>> >> It's not clear to me what source code you have drawn your patch against. >> >> When I ack or grep the Perl 5 core distribution, I find no directory named 'rts'. Nor do I find the string 'darwin_HOST_OS' in any source code. >> >> ##### >> $ ack '\brts\b' MANIFEST >> [no output] >> >> $ find . -type d -name '*rts*' >> ./cpan/Devel-PPPort/parts >> >> $ ack darwin_HOST_OS . >> [no output] >> ##### >> >> Can you clarify?
> > Wow, this is pretty amazing. I have no idea how this happened, but the > patch seems to be against > https://github.com/ghc/ghc/blob/master/rts/posix/GetTime.c, which is the > runtime system of ghc (the Glasgow Haskell Compiler). > > -- > Lukas Mai <plokinom@gmail.com> > >
CC: perlbug-followup [...] perl.org
To: Misty De Meo <mistydemeo [...] gmail.com>
Subject: Re: [perl #128427] perlbug AutoReply: perl does not build on Darwin platforms with clock_gettime
From: Dave Mitchell <davem [...] iabyn.com>
Date: Mon, 20 Jun 2016 08:35:59 +0100
Download (untitled) / with headers
text/plain 407b
On Fri, Jun 17, 2016 at 01:24:43PM -0700, Misty De Meo wrote: Show quoted text
> Apologies, it appears I attached the incorrect patch. The correct patch is > attached.
Thanks, applied as 2d41a263c0e09e6dfabecd28212d7e80b42dc3e6 and I've added you to AUTHORS with ba3530a211029e1fe07e19b385b9f7c17af92ac5 -- "Foul and greedy Dwarf - you have eaten the last candle." -- "Hordes of the Things", BBC Radio.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 896b
On Mon Jun 20 00:36:34 2016, davem wrote: Show quoted text
> On Fri, Jun 17, 2016 at 01:24:43PM -0700, Misty De Meo wrote:
> > Apologies, it appears I attached the incorrect patch. The correct patch is > > attached.
> > Thanks, applied as > > 2d41a263c0e09e6dfabecd28212d7e80b42dc3e6
This change unfortunately didn't quite work. In OS X 10.11.5 (at least, but got also failure reports from other versions), the change meant that the mutex init was skipped, which meant that the further mutex use panicked (correctly) if the Perl was built with threads. So what exactly was the intent of the change? You said "resulting in build errors on Darwin versions which include a native clock_gettime"? What are these platforms? Non-Apple Darwin builds? That is fine, but the change needs to be something different. Show quoted text
> and I've added you to AUTHORS with > > ba3530a211029e1fe07e19b385b9f7c17af92ac5 >
RT-Send-CC: perl5-porters [...] perl.org
On Wed Jun 22 04:37:18 2016, jhi wrote: Show quoted text
> On Mon Jun 20 00:36:34 2016, davem wrote:
> > On Fri, Jun 17, 2016 at 01:24:43PM -0700, Misty De Meo wrote:
> > > Apologies, it appears I attached the incorrect patch. The correct > > > patch is > > > attached.
> > > > Thanks, applied as > > > > 2d41a263c0e09e6dfabecd28212d7e80b42dc3e6
> > This change unfortunately didn't quite work. > > In OS X 10.11.5 (at least, but got also failure reports from other > versions), the change meant that the mutex > init was skipped, which meant that the further mutex use panicked > (correctly) if the Perl was built with threads. So what exactly was > the intent of the change? > > You said "resulting in build errors on Darwin versions which include a > native clock_gettime"? What are these platforms? Non-Apple Darwin > builds? That is fine, but the change needs to be something different.
Ah, I see it now. The test !defined(CLOCK_REALTIME) is not valid anymore later in the file because the Darwin emulation defines it. I'll fix this.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 457b
The code in question has been modified in more recent versions of Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these changes sufficient? http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 If not, the patch from Misty may have been overwritten when the new version of Time-HiRes was brought into blead (is it cpan-upstream?). Jarkko, have you had a chance to look into the issues you identified? -- Dan Collins
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 726b
On Tue Sep 06 10:48:17 2016, dcollinsn@gmail.com wrote: Show quoted text
> The code in question has been modified in more recent versions of > Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these changes > sufficient? > http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 > > If not, the patch from Misty may have been overwritten when the new > version of Time-HiRes was brought into blead (is it cpan-upstream?). > Jarkko, have you had a chance to look into the issues you identified?
The latest versions of T-H should be all good in all known versions of OS X. Sierra, whatever. If they are not, new bug reports should be filed. As far as I know, this one can be closed. Show quoted text
> -- > Dan Collins
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 896b
On Wed Sep 07 18:31:46 2016, jhi wrote: Show quoted text
> On Tue Sep 06 10:48:17 2016, dcollinsn@gmail.com wrote:
> > The code in question has been modified in more recent versions of > > Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these changes > > sufficient? > > http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 > > > > If not, the patch from Misty may have been overwritten when the new > > version of Time-HiRes was brought into blead (is it cpan-upstream?). > > Jarkko, have you had a chance to look into the issues you identified?
> > The latest versions of T-H should be all good in all known versions of > OS X. Sierra, whatever. > If they are not, new bug reports should be filed. As far as I know, > this one can be closed.
The issue is more building 5.24 on Sierra, is there a minimal fix for the build issue which can be backported to 5.24? Tony
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
On Thu, 08 Sep 2016 01:58:19 GMT, tonyc wrote: Show quoted text
> On Wed Sep 07 18:31:46 2016, jhi wrote:
> > On Tue Sep 06 10:48:17 2016, dcollinsn@gmail.com wrote:
> > > The code in question has been modified in more recent versions of > > > Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these > > > changes > > > sufficient? > > > http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 > > > > > > If not, the patch from Misty may have been overwritten when the new > > > version of Time-HiRes was brought into blead (is it cpan- > > > upstream?). > > > Jarkko, have you had a chance to look into the issues you > > > identified?
> > > > The latest versions of T-H should be all good in all known versions > > of > > OS X. Sierra, whatever. > > If they are not, new bug reports should be filed. As far as I know, > > this one can be closed.
> > The issue is more building 5.24 on Sierra, is there a minimal fix for > the build > issue which can be backported to 5.24? > > Tony
MoarVM also faced this problem: https://github.com/MoarVM/MoarVM/commit/20c8591ad7644926e09691da8c2a9179b11ac53e -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 283b
Show quoted text
> The issue is more building 5.24 on Sierra, is there a minimal fix for > the build > issue which can be backported to 5.24? > > Tony
Hi, this is what we did for Perl 6: https://github.com/MoarVM/MoarVM/commit/20c8591ad7644926e09691da8c2a9179b11ac53e I hope that helps a little.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
On Thu, 08 Sep 2016 01:58:19 GMT, tonyc wrote: Show quoted text
> On Wed Sep 07 18:31:46 2016, jhi wrote:
> > On Tue Sep 06 10:48:17 2016, dcollinsn@gmail.com wrote:
> > > The code in question has been modified in more recent versions of > > > Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these > > > changes > > > sufficient? > > > http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 > > > > > > If not, the patch from Misty may have been overwritten when the new > > > version of Time-HiRes was brought into blead (is it cpan- > > > upstream?). > > > Jarkko, have you had a chance to look into the issues you > > > identified?
> > > > The latest versions of T-H should be all good in all known versions > > of > > OS X. Sierra, whatever. > > If they are not, new bug reports should be filed. As far as I know, > > this one can be closed.
> > The issue is more building 5.24 on Sierra, is there a minimal fix for > the build > issue which can be backported to 5.24? > > Tony
Tony, Jarkko, Dan: Can you advise where we stand on this ticket? Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Date: Thu, 29 Dec 2016 17:07:44 -0600
To: Craig Berry via RT <perlbug-followup [...] perl.org>
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
Download (untitled) / with headers
text/plain 2.8k
On Thu, Dec 29, 2016 at 8:00 AM, James E Keenan via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Thu, 08 Sep 2016 01:58:19 GMT, tonyc wrote:
>> On Wed Sep 07 18:31:46 2016, jhi wrote:
>> > On Tue Sep 06 10:48:17 2016, dcollinsn@gmail.com wrote:
>> > > The code in question has been modified in more recent versions of >> > > Time-HiRes, for example, to use PERL_DARWIN_MUTEX. Are these >> > > changes >> > > sufficient? >> > > http://perl5.git.perl.org/perl.git/commitdiff/c4a535af41823cc84534bf8dbecfdcc3eb7daa86 >> > > >> > > If not, the patch from Misty may have been overwritten when the new >> > > version of Time-HiRes was brought into blead (is it cpan- >> > > upstream?). >> > > Jarkko, have you had a chance to look into the issues you >> > > identified?
>> > >> > The latest versions of T-H should be all good in all known versions >> > of >> > OS X. Sierra, whatever. >> > If they are not, new bug reports should be filed. As far as I know, >> > this one can be closed.
>> >> The issue is more building 5.24 on Sierra, is there a minimal fix for >> the build >> issue which can be backported to 5.24? >> >> Tony
> > Tony, Jarkko, Dan: Can you advise where we stand on this ticket? > > Thank you very much. > > -- > James E Keenan (jkeenan@cpan.org)
As of v5.24.1-RC4-13-gb7d278c, there is one remaining test failure: $ ../../perl -I../../lib t/clock.t 1..5 # I am the main process 19721, starting the watchdog process... # The watchdog process 19722 launched, continuing testing... # I am the watchdog process 19722, sleeping for 360 seconds... ok 1 - require Time::HiRes; # have_clock_gettime = 1 # have_clock_getres = 1 # have_clock_nanosleep = 1 # have_clock = 1 # CLOCK_REALTIME: try = 1 # t1 = 1483046030.35294, t0 = 1483046028.84275 # dt = 1.51018714904785, rt = 0.00679143269856763 ok 2 ok 3 Time::HiRes::clock_nanosleep(): unimplemented in this platform at t/clock.t line 74. # I am the main process 19721, terminating the watchdog process 19722 before it terminates me in 358 seconds (testing took 2 seconds). # kill KILL 19722 = 1 # All done. # Looks like you planned 5 tests but ran 3. # Looks like your test exited with 60 just after 3. I've attached a patch that updates maint-5.24 to the current CPAN release of Tiime::HiRes and can confirm that this gets all tests passing on macOS Sierra. As far as I can see the only new feature is the addition of a high-resolution utime(). All other changes are bug fixes, most of them darwin-related. Disentangling which bug fixes are strictly necessary might be riskier (and certainly more work) than just taking the whole thing. All of the relevant changes have been in blead for a couple of months, meaning we'd probably know about it by now if they were problematic. At least this is an alternative to leaving the test failure as-is. I think the only other alternative would be for someone to trawl through all the changes and produce a more minimal patch.

Message body is not shown because sender requested not to inline it.

From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Date: Fri, 21 Jul 2017 15:12:28 -0400
CC: Karen Etheridge <ether [...] cpan.org>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
To: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Download (untitled) / with headers
text/plain 562b
On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote: Show quoted text
> I've attached a patch that updates maint-5.24 to the current CPAN > release of Tiime::HiRes and can confirm that this gets all tests > passing on macOS Sierra. >
ether said in #p5p that she was unable to build 5.24.2 because of this issue. I checked and it does not appear that this (or any upgrade to Time::HiRes) made it into 5.24.2, so people will have trouble installing it on this OS. Do we need another point release for 5.24.* to fix this..? -- Matthew Horsfall (alh)
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>, Karen Etheridge <ether [...] cpan.org>
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
Date: Fri, 21 Jul 2017 18:47:48 -0500
To: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
Download (untitled) / with headers
text/plain 991b
On Fri, Jul 21, 2017 at 2:12 PM, Matthew Horsfall (alh) <wolfsage@gmail.com> wrote: Show quoted text
> On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote:
>> I've attached a patch that updates maint-5.24 to the current CPAN >> release of Tiime::HiRes and can confirm that this gets all tests >> passing on macOS Sierra. >>
> > ether said in #p5p that she was unable to build 5.24.2 because of this issue. > > I checked and it does not appear that this (or any upgrade to > Time::HiRes) made it into 5.24.2, so people will have trouble > installing it on this OS. > > Do we need another point release for 5.24.* to fix this..?
5.24.2 was limited to the base.pm fixes. So yes, this will not be fixed unless it gets into the next maint-5.24 release. I have voted for my own patch: <https://perl5.git.perl.org/perl.git/commitdiff/63784e26bef8426a67e8780734da0d0e7a9d052b> It needs one more vote. Perhaps the only wrinkle now is whether it should get 1.9742 rather than 1.9741.
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>, Karen Etheridge <ether [...] cpan.org>
Date: Fri, 21 Jul 2017 19:57:18 -0400
From: wolfsage [...] gmail.com
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
To: "Craig A. Berry" <craig.a.berry [...] gmail.com>
Download (untitled) / with headers
text/plain 1.1k
Show quoted text
> On Jul 21, 2017, at 7:47 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote: > > On Fri, Jul 21, 2017 at 2:12 PM, Matthew Horsfall (alh) > <wolfsage@gmail.com> wrote:
>> On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote:
>>> I've attached a patch that updates maint-5.24 to the current CPAN >>> release of Tiime::HiRes and can confirm that this gets all tests >>> passing on macOS Sierra. >>>
>> >> ether said in #p5p that she was unable to build 5.24.2 because of this issue. >> >> I checked and it does not appear that this (or any upgrade to >> Time::HiRes) made it into 5.24.2, so people will have trouble >> installing it on this OS. >> >> Do we need another point release for 5.24.* to fix this..?
> > 5.24.2 was limited to the base.pm fixes. So yes, this will not be > fixed unless it gets into the next maint-5.24 release. I have voted > for my own patch: > > <https://perl5.git.perl.org/perl.git/commitdiff/63784e26bef8426a67e8780734da0d0e7a9d052b> > > It needs one more vote. Perhaps the only wrinkle now is whether it > should get 1.9742 rather than 1.9741.
+1 from me, thanks. -- Matthew Horsfall (alh)
To: wolfsage [...] gmail.com, "Craig A. Berry" <craig.a.berry [...] gmail.com>
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
Date: Sun, 23 Jul 2017 20:42:46 +0200
From: Sawyer X <xsawyerx [...] gmail.com>
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>, Karen Etheridge <ether [...] cpan.org>
Download (untitled) / with headers
text/plain 1.2k
On 07/22/2017 01:57 AM, wolfsage@gmail.com wrote: Show quoted text
>> On Jul 21, 2017, at 7:47 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote: >> >> On Fri, Jul 21, 2017 at 2:12 PM, Matthew Horsfall (alh) >> <wolfsage@gmail.com> wrote:
>>> On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote:
>>>> I've attached a patch that updates maint-5.24 to the current CPAN >>>> release of Tiime::HiRes and can confirm that this gets all tests >>>> passing on macOS Sierra. >>>>
>>> ether said in #p5p that she was unable to build 5.24.2 because of this issue. >>> >>> I checked and it does not appear that this (or any upgrade to >>> Time::HiRes) made it into 5.24.2, so people will have trouble >>> installing it on this OS. >>> >>> Do we need another point release for 5.24.* to fix this..?
>> 5.24.2 was limited to the base.pm fixes. So yes, this will not be >> fixed unless it gets into the next maint-5.24 release. I have voted >> for my own patch: >> >> <https://perl5.git.perl.org/perl.git/commitdiff/63784e26bef8426a67e8780734da0d0e7a9d052b> >> >> It needs one more vote. Perhaps the only wrinkle now is whether it >> should get 1.9742 rather than 1.9741.
> +1 from me, thanks.
From me as well. Reflected here: https://perl5.git.perl.org/perl.git/commitdiff/31e0d510bd365f1c040cd8bdcb00065ff67f02d5.
Subject: Re: [perl #128427] perl does not build on Darwin platforms with clock_gettime
To: Sawyer X <xsawyerx [...] gmail.com>
Date: Mon, 24 Jul 2017 21:16:46 +0100
From: Steve Hay via perl5-porters <perl5-porters [...] perl.org>
CC: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>, "Craig A. Berry" <craig.a.berry [...] gmail.com>, "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>, Karen Etheridge <ether [...] cpan.org>, Jarkko Hietaniemi <jhi [...] iki.fi>
Download (untitled) / with headers
text/plain 1.6k
On 23 July 2017 at 19:42, Sawyer X <xsawyerx@gmail.com> wrote: Show quoted text
> > > On 07/22/2017 01:57 AM, wolfsage@gmail.com wrote:
>>> On Jul 21, 2017, at 7:47 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote: >>> >>> On Fri, Jul 21, 2017 at 2:12 PM, Matthew Horsfall (alh) >>> <wolfsage@gmail.com> wrote:
>>>> On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry <craig.a.berry@gmail.com> wrote:
>>>>> I've attached a patch that updates maint-5.24 to the current CPAN >>>>> release of Tiime::HiRes and can confirm that this gets all tests >>>>> passing on macOS Sierra. >>>>>
>>>> ether said in #p5p that she was unable to build 5.24.2 because of this issue. >>>> >>>> I checked and it does not appear that this (or any upgrade to >>>> Time::HiRes) made it into 5.24.2, so people will have trouble >>>> installing it on this OS. >>>> >>>> Do we need another point release for 5.24.* to fix this..?
>>> 5.24.2 was limited to the base.pm fixes. So yes, this will not be >>> fixed unless it gets into the next maint-5.24 release. I have voted >>> for my own patch: >>> >>> <https://perl5.git.perl.org/perl.git/commitdiff/63784e26bef8426a67e8780734da0d0e7a9d052b> >>> >>> It needs one more vote. Perhaps the only wrinkle now is whether it >>> should get 1.9742 rather than 1.9741.
>> +1 from me, thanks.
> > From me as well. Reflected here: > https://perl5.git.perl.org/perl.git/commitdiff/31e0d510bd365f1c040cd8bdcb00065ff67f02d5.
I'm happy to take Craig's patch to update to 1.9741 for 5.24.3. Are the extra changes in 1.9742 safe & worthwhile? It looks like 'yes' on both fronts to me, but should I be concerned about the entirely red column ('gnu') here?: http://matrix.cpantesters.org/?dist=Time-HiRes+1.9742
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.1k
On Mon, 24 Jul 2017 13:17:04 -0700, shay wrote: Show quoted text
> On 23 July 2017 at 19:42, Sawyer X <xsawyerx@gmail.com> wrote:
> > > > > > On 07/22/2017 01:57 AM, wolfsage@gmail.com wrote:
> >>> On Jul 21, 2017, at 7:47 PM, Craig A. Berry > >>> <craig.a.berry@gmail.com> wrote: > >>> > >>> On Fri, Jul 21, 2017 at 2:12 PM, Matthew Horsfall (alh) > >>> <wolfsage@gmail.com> wrote:
> >>>> On Thu, Dec 29, 2016 at 6:07 PM, Craig A. Berry > >>>> <craig.a.berry@gmail.com> wrote:
> >>>>> I've attached a patch that updates maint-5.24 to the current CPAN > >>>>> release of Tiime::HiRes and can confirm that this gets all tests > >>>>> passing on macOS Sierra. > >>>>>
> >>>> ether said in #p5p that she was unable to build 5.24.2 because of > >>>> this issue. > >>>> > >>>> I checked and it does not appear that this (or any upgrade to > >>>> Time::HiRes) made it into 5.24.2, so people will have trouble > >>>> installing it on this OS. > >>>> > >>>> Do we need another point release for 5.24.* to fix this..?
> >>> 5.24.2 was limited to the base.pm fixes. So yes, this will not be > >>> fixed unless it gets into the next maint-5.24 release. I have > >>> voted > >>> for my own patch: > >>> > >>> <https://perl5.git.perl.org/perl.git/commitdiff/63784e26bef8426a67e8780734da0d0e7a9d052b> > >>> > >>> It needs one more vote. Perhaps the only wrinkle now is whether it > >>> should get 1.9742 rather than 1.9741.
> >> +1 from me, thanks.
> > > > From me as well. Reflected here: > > https://perl5.git.perl.org/perl.git/commitdiff/31e0d510bd365f1c040cd8bdcb00065ff67f02d5.
> > I'm happy to take Craig's patch to update to 1.9741 for 5.24.3. Are > the extra changes in 1.9742 safe & worthwhile? It looks like 'yes' on > both fronts to me, but should I be concerned about the entirely red > column ('gnu') here?: > http://matrix.cpantesters.org/?dist=Time-HiRes+1.9742
I've now pulled 1.9741 into maint-5.24, ready for perl-5.24.3. I didn't take 1.9742 (or 1.9744, which has since arrived as well!) because maint-5.26 currently has 1.9741 and I didn't like the idea of an upgrade from perl-5.24 to perl-5.26 rolling back to an older Time-HiRes (and there is no pressing need to upgrade Time-HiRes in perl-5.26 as far as I know).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org