Skip Menu |
Report information
Id: 128316
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: leonerd [at] leonerd.org.uk
Cc:
AdminCc:

Operating System: Linux
PatchStatus: (no value)
Severity: low
Type: core
Perl Version: 5.22.1
Fixed In: (no value)

Attachments
0001-perl-128316-preserve-errno-from-failed-system-calls.patch



To: perlbug [...] perl.org
Date: Fri, 3 Jun 2016 16:01:06 +0100
From: "Paul \"LeoNerd\" Evans" <leonerd [...] leonerd.org.uk>
Subject: CORE::socket() mangles EMFILE and turns it into EBADF
Download (untitled) / with headers
text/plain 11.4k
This is a bug report for perl from leonerd@leonerd.org.uk, generated with the help of perlbug 1.40 running under perl 5.22.1. ----------------------------------------------------------------- If a socket(2) call results in EMFILE (Too many open files), the core perl socket() syscall turns this into an EBADF message instead. $ ulimit -n 64 $ perl -Mblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, 0) { push @s, $s; } die $!' Bad file descriptor at -e line 1. At strace level: ... socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = 63 ioctl(63, TCGETS, 0x7ffc0f2b4d80) = -1 ENOTTY (Inappropriate ioctl for device) lseek(63, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) ioctl(63, TCGETS, 0x7ffc0f2b4d80) = -1 ENOTTY (Inappropriate ioctl for device) lseek(63, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) fcntl(63, F_SETFD, FD_CLOEXEC) = 0 socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = -1 EMFILE (Too many open files) write(2, "Bad file descriptor at -e line 1"..., 34) = 34 [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=core severity=low --- Site configuration information for perl 5.22.1: Configured by Debian Project at Sun Apr 17 19:08:08 UTC 2016. Summary of my perl5 (revision 5 version 22 subversion 1) configuration: Platform: osname=linux, osvers=3.16.0, archname=x86_64-linux-gnu-thread-multi uname='linux localhost 3.16.0 #1 smp debian 3.16.0 x86_64 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=-DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Dldflags= -Wl,-z,relro -Dlddlflags=-shared -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.22 -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.22 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux-gnu/perl5/5.22 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.22.1 -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib -Dlibperl=libperl.so.5.22.1' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='x86_64-linux-gnu-gcc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -g', cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='', gccversion='5.3.1 20160409', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='x86_64-linux-gnu-gcc', ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=libc-2.22.so, so=so, useshrplib=true, libperl=libperl.so.5.22 gnulibc_version='2.22' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib -fstack-protector-strong' Locally applied patches: DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS default for modules installed from CPAN. DEBPKG:debian/db_file_ver - http://bugs.debian.org/340047 Remove overly restrictive DB_File version check. DEBPKG:debian/doc_info - Replace generic man(1) instructions with Debian-specific information. DEBPKG:debian/enc2xs_inc - http://bugs.debian.org/290336 Tweak enc2xs to follow symlinks and ignore missing @INC directories. DEBPKG:debian/errno_ver - http://bugs.debian.org/343351 Remove Errno version check due to upgrade problems with long-running processes. DEBPKG:debian/libperl_embed_doc - http://bugs.debian.org/186778 Note that libperl-dev package is required for embedded linking DEBPKG:fixes/respect_umask - Respect umask during installation DEBPKG:debian/writable_site_dirs - Set umask approproately for site install directories DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of libperl.a under /usr/lib DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or perllocal.pod for perl or vendor DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to the binary targets. DEBPKG:debian/instmodsh_doc - Debian policy doesn't install .packlist files for core or vendor. DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH as per Debian policy. DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to /etc/perl/Net as /usr may not be writable. DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian DEBPKG:debian/prune_libs - http://bugs.debian.org/128355 Prune the list of libraries wanted to what we actually need. DEBPKG:fixes/net_smtp_docs - [rt.cpan.org #36038] http://bugs.debian.org/100195 Document the Net::SMTP 'Port' option DEBPKG:debian/perlivp - http://bugs.debian.org/510895 Make perlivp skip include directories in /usr/local DEBPKG:debian/deprecate-with-apt - http://bugs.debian.org/747628 Point users to Debian packages of deprecated core modules DEBPKG:debian/squelch-locale-warnings - http://bugs.debian.org/508764 Squelch locale warnings in Debian package maintainer scripts DEBPKG:debian/skip-upstream-git-tests - Skip tests specific to the upstream Git repository DEBPKG:debian/patchlevel - http://bugs.debian.org/567489 List packaged patches for 5.22.1-10 in patchlevel.h DEBPKG:debian/skip-kfreebsd-crash - http://bugs.debian.org/628493 [perl #96272] Skip a crashing test case in t/op/threads.t on GNU/kFreeBSD DEBPKG:fixes/document_makemaker_ccflags - http://bugs.debian.org/628522 [rt.cpan.org #68613] Document that CCFLAGS should include $Config{ccflags} DEBPKG:debian/find_html2text - http://bugs.debian.org/640479 Configure CPAN::Distribution with correct name of html2text DEBPKG:debian/perl5db-x-terminal-emulator.patch - http://bugs.debian.org/668490 Invoke x-terminal-emulator rather than xterm in perl5db.pl DEBPKG:debian/cpan-missing-site-dirs - http://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with nonexisting site dirs if a parent is writable DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] http://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' option not respected DEBPKG:debian/regen-skip - Skip a regeneration check in unrelated git repositories DEBPKG:debian/makemaker-pasthru - http://bugs.debian.org/758471 Pass LD settings through to subdirectories DEBPKG:fixes/pod_man_reproducible_date - http://bugs.debian.org/759405 Support POD_MAN_DATE in Pod::Man for the left-hand footer DEBPKG:debian/locale-robustness - http://bugs.debian.org/782068 [perl #124310] Make t/run/locale.t survive missing locales masked by LC_ALL DEBPKG:fixes/podman-utc - http://bugs.debian.org/780259 Make the embedded date from Pod::Man reproducible DEBPKG:fixes/podman-utc-docs - http://bugs.debian.org/780259 Documentation and test suite updates for UTC fix DEBPKG:fixes/podman-empty-date - http://bugs.debian.org/780259 Support an empty POD_MAN_DATE environment variable DEBPKG:fixes/podman-pipe - http://bugs.debian.org/777405 Better errors for man pages from standard input DEBPKG:debian/pod2man-customized - Update porting/customized.dat for pod2man modifications DEBPKG:debian/makemaker-manext - http://bugs.debian.org/247370 Make EU::MakeMaker honour MANnEXT settings in generated manpage headers DEBPKG:debian/makemaker_customized - Update t/porting/customized.dat for files patched in Debian DEBPKG:debian/do-not-record-build-date - [6baa8db] http://bugs.debian.org/774422 [perl #125830] Allow overriding the compile time in "perl -V" output DEBPKG:fixes/podman-source-date-epoch - http://bugs.debian.org/801621 Make Pod::Man honor the SOURCE_DATE_EPOCH environment variable DEBPKG:fixes/podman-source-date-epoch-cleanups - http://bugs.debian.org/801621 Coding style and documentation for SOURCE_EPOCH_DATE DEBPKG:fixes/podman-source-date-epoch-testfix - http://bugs.debian.org/807086 Guard for building with SOURCE_DATE_EPOCH or POD_MAN_DATE set DEBPKG:debian/devel-ppport-reproducibility - http://bugs.debian.org/801523 Sort the list of XS code files when generating RealPPPort.xs DEBPKG:fixes/encode-unicode-bom - http://bugs.debian.org/798727 [rt.cpan.org #107043] Address https://rt.cpan.org/Public/Bug/Display.html?id=107043 DEBPKG:debian/encode-unicode-bom-doc - http://bugs.debian.org/798727 Document Debian backport of Encode::Unicode fix DEBPKG:debian/kfreebsd-softupdates - http://bugs.debian.org/796798 Work around Debian Bug#796798 DEBPKG:fixes/autodie-scope - http://bugs.debian.org/798096 Fix a scoping issue with "no autodie" and the "system" sub DEBPKG:debian/debugperl-compat-fix - [perl #127212] http://bugs.debian.org/810326 Disable PERL_TRACK_MEMPOOL for debugging builds DEBPKG:fixes/CVE-2015-8607_file_spec_taint_fix - http://bugs.debian.org/810719 [perl #126862] ensure File::Spec::canonpath() preserves taint DEBPKG:fixes/mkstemp-umask - http://bugs.debian.org/810924 [perl #127322] [e57270b] Fix umask for mkstemp(3) calls DEBPKG:fixes/crosscompile-no-targethost - [perl #127234] Fix the Configure escape with usecrosscompile but no targethost DEBPKG:fixes/podlators-no-encode - [rt.cpan.org #111156] Degrade gracefully if utf8 is requested but Encode is not available DEBPKG:debian/cross-time-hires - [rt.cpan.org #111391] Add an environment variable to skip running configuration probes DEBPKG:fixes/encode-unicode-pod - Unicode.pm: Fix POD error DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in Memoize DEBPKG:fixes/ok-pod - Added encoding for pod. DEBPKG:fixes/CVE-2016-2381_duplicate_env - remove duplicate environment variables from environ --- @INC for perl 5.22.1: /home/leo/lib/perl5/x86_64-linux-gnu-thread-multi /home/leo/lib/perl5 /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base . --- Environment for perl 5.22.1: HOME=/home/leo LANG=en_GB.UTF-8 LANGUAGE=en_GB:en LD_LIBRARY_PATH=/home/leo/lib LOGDIR (unset) PATH=/home/leo/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games PERL5LIB=/home/leo/lib/perl5 PERL_BADLANG (unset) PERL_MB_OPT=--install_base=/home/leo PERL_MM_OPT=INSTALL_BASE=/home/leo SHELL=/bin/bash
Download (untitled)
application/pgp-signature 181b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 12.4k
On Fri Jun 03 08:01:38 2016, leonerd@leonerd.org.uk wrote: Show quoted text
> This is a bug report for perl from leonerd@leonerd.org.uk, > generated with the help of perlbug 1.40 running under perl 5.22.1. > > > ----------------------------------------------------------------- > If a socket(2) call results in EMFILE (Too many open files), the core > perl > socket() syscall turns this into an EBADF message instead. > > $ ulimit -n 64 > $ perl -Mblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, > 0) { push @s, $s; } die $!' > Bad file descriptor at -e line 1. >
Copying those commands to the command-prompt, I got: ##### $ perl -Mblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, 0) { push @s, $s; } die $!' Cannot find blib even in /home/jkeenan/gitwork/perl/../../../../.. BEGIN failed--compilation aborted. ##### Should '-Mblib' actually be '-Iblib'? Only when I made that correction did I get your results: ##### $ perl -Iblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, 0) { push @s, $s; } die $!' Bad file descriptor at -e line 1. ##### Show quoted text
> At strace level: > > ... > socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = 63 > ioctl(63, TCGETS, 0x7ffc0f2b4d80) = -1 ENOTTY (Inappropriate > ioctl for device) > lseek(63, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > ioctl(63, TCGETS, 0x7ffc0f2b4d80) = -1 ENOTTY (Inappropriate > ioctl for device) > lseek(63, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > fcntl(63, F_SETFD, FD_CLOEXEC) = 0 > socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = -1 EMFILE (Too many open > files) > write(2, "Bad file descriptor at -e line 1"..., 34) = 34 > > > [Please do not change anything below this line] > ----------------------------------------------------------------- > --- > Flags: > category=core > severity=low > --- > Site configuration information for perl 5.22.1: > > Configured by Debian Project at Sun Apr 17 19:08:08 UTC 2016. > > Summary of my perl5 (revision 5 version 22 subversion 1) > configuration: > > Platform: > osname=linux, osvers=3.16.0, archname=x86_64-linux-gnu-thread-multi > uname='linux localhost 3.16.0 #1 smp debian 3.16.0 x86_64 gnulinux ' > config_args='-Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc > -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=- > DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector- > strong -Wformat -Werror=format-security -Dldflags= -Wl,-z,relro > -Dlddlflags=-shared -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64- > linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.22 > -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.22 -Dvendorprefix=/usr > -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux- > gnu/perl5/5.22 -Dsiteprefix=/usr/local > -Dsitelib=/usr/local/share/perl/5.22.1 > -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 > -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 > -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 > -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible- > pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil > -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib > -Dlibperl=libperl.so.5.22.1' > hint=recommended, useposix=true, d_sigaction=define > useithreads=define, usemultiplicity=define > use64bitint=define, use64bitall=define, uselongdouble=undef > usemymalloc=n, bincompat5005=undef > Compiler: > cc='x86_64-linux-gnu-gcc', ccflags ='-D_REENTRANT -D_GNU_SOURCE > -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include > -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', > optimize='-O2 -g', > cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict- > aliasing -pipe -I/usr/local/include' > ccversion='', gccversion='5.3.1 20160409', gccosandvers='' > intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, > doublekind=3 > d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, > longdblkind=3 > ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', > lseeksize=8 > alignbytes=8, prototype=define > Linker and Libraries: > ld='x86_64-linux-gnu-gcc', ldflags =' -fstack-protector-strong > -L/usr/local/lib' > libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed > /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu > /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib > libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt > perllibs=-ldl -lm -lpthread -lc -lcrypt > libc=libc-2.22.so, so=so, useshrplib=true, libperl=libperl.so.5.22 > gnulibc_version='2.22' > Dynamic Linking: > dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' > cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib -fstack- > protector-strong' > > Locally applied patches: > DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS > default for modules installed from CPAN. > DEBPKG:debian/db_file_ver - http://bugs.debian.org/340047 Remove > overly restrictive DB_File version check. > DEBPKG:debian/doc_info - Replace generic man(1) instructions with > Debian-specific information. > DEBPKG:debian/enc2xs_inc - http://bugs.debian.org/290336 Tweak > enc2xs to follow symlinks and ignore missing @INC directories. > DEBPKG:debian/errno_ver - http://bugs.debian.org/343351 Remove > Errno version check due to upgrade problems with long-running > processes. > DEBPKG:debian/libperl_embed_doc - http://bugs.debian.org/186778 > Note that libperl-dev package is required for embedded linking > DEBPKG:fixes/respect_umask - Respect umask during installation > DEBPKG:debian/writable_site_dirs - Set umask approproately for > site install directories > DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of > libperl.a under /usr/lib > DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or > perllocal.pod for perl or vendor > DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to > the binary targets. > DEBPKG:debian/instmodsh_doc - Debian policy doesn't install > .packlist files for core or vendor. > DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH > as per Debian policy. > DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to > /etc/perl/Net as /usr may not be writable. > DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian > DEBPKG:debian/prune_libs - http://bugs.debian.org/128355 Prune the > list of libraries wanted to what we actually need. > DEBPKG:fixes/net_smtp_docs - [rt.cpan.org #36038] > http://bugs.debian.org/100195 Document the Net::SMTP 'Port' option > DEBPKG:debian/perlivp - http://bugs.debian.org/510895 Make perlivp > skip include directories in /usr/local > DEBPKG:debian/deprecate-with-apt - http://bugs.debian.org/747628 > Point users to Debian packages of deprecated core modules > DEBPKG:debian/squelch-locale-warnings - > http://bugs.debian.org/508764 Squelch locale warnings in Debian > package maintainer scripts > DEBPKG:debian/skip-upstream-git-tests - Skip tests specific to the > upstream Git repository > DEBPKG:debian/patchlevel - http://bugs.debian.org/567489 List > packaged patches for 5.22.1-10 in patchlevel.h > DEBPKG:debian/skip-kfreebsd-crash - http://bugs.debian.org/628493 > [perl #96272] Skip a crashing test case in t/op/threads.t on > GNU/kFreeBSD > DEBPKG:fixes/document_makemaker_ccflags - > http://bugs.debian.org/628522 [rt.cpan.org #68613] Document that > CCFLAGS should include $Config{ccflags} > DEBPKG:debian/find_html2text - http://bugs.debian.org/640479 > Configure CPAN::Distribution with correct name of html2text > DEBPKG:debian/perl5db-x-terminal-emulator.patch - > http://bugs.debian.org/668490 Invoke x-terminal-emulator rather than > xterm in perl5db.pl > DEBPKG:debian/cpan-missing-site-dirs - > http://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with > nonexisting site dirs if a parent is writable > DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] > http://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' > option not respected > DEBPKG:debian/regen-skip - Skip a regeneration check in unrelated > git repositories > DEBPKG:debian/makemaker-pasthru - http://bugs.debian.org/758471 > Pass LD settings through to subdirectories > DEBPKG:fixes/pod_man_reproducible_date - > http://bugs.debian.org/759405 Support POD_MAN_DATE in Pod::Man for the > left-hand footer > DEBPKG:debian/locale-robustness - http://bugs.debian.org/782068 > [perl #124310] Make t/run/locale.t survive missing locales masked by > LC_ALL > DEBPKG:fixes/podman-utc - http://bugs.debian.org/780259 Make the > embedded date from Pod::Man reproducible > DEBPKG:fixes/podman-utc-docs - http://bugs.debian.org/780259 > Documentation and test suite updates for UTC fix > DEBPKG:fixes/podman-empty-date - http://bugs.debian.org/780259 > Support an empty POD_MAN_DATE environment variable > DEBPKG:fixes/podman-pipe - http://bugs.debian.org/777405 Better > errors for man pages from standard input > DEBPKG:debian/pod2man-customized - Update porting/customized.dat > for pod2man modifications > DEBPKG:debian/makemaker-manext - http://bugs.debian.org/247370 > Make EU::MakeMaker honour MANnEXT settings in generated manpage > headers > DEBPKG:debian/makemaker_customized - Update > t/porting/customized.dat for files patched in Debian > DEBPKG:debian/do-not-record-build-date - [6baa8db] > http://bugs.debian.org/774422 [perl #125830] Allow overriding the > compile time in "perl -V" output > DEBPKG:fixes/podman-source-date-epoch - > http://bugs.debian.org/801621 Make Pod::Man honor the > SOURCE_DATE_EPOCH environment variable > DEBPKG:fixes/podman-source-date-epoch-cleanups - > http://bugs.debian.org/801621 Coding style and documentation for > SOURCE_EPOCH_DATE > DEBPKG:fixes/podman-source-date-epoch-testfix - > http://bugs.debian.org/807086 Guard for building with > SOURCE_DATE_EPOCH or POD_MAN_DATE set > DEBPKG:debian/devel-ppport-reproducibility - > http://bugs.debian.org/801523 Sort the list of XS code files when > generating RealPPPort.xs > DEBPKG:fixes/encode-unicode-bom - http://bugs.debian.org/798727 > [rt.cpan.org #107043] Address > https://rt.cpan.org/Public/Bug/Display.html?id=107043 > DEBPKG:debian/encode-unicode-bom-doc - > http://bugs.debian.org/798727 Document Debian backport of > Encode::Unicode fix > DEBPKG:debian/kfreebsd-softupdates - http://bugs.debian.org/796798 > Work around Debian Bug#796798 > DEBPKG:fixes/autodie-scope - http://bugs.debian.org/798096 Fix a > scoping issue with "no autodie" and the "system" sub > DEBPKG:debian/debugperl-compat-fix - [perl #127212] > http://bugs.debian.org/810326 Disable PERL_TRACK_MEMPOOL for debugging > builds > DEBPKG:fixes/CVE-2015-8607_file_spec_taint_fix - > http://bugs.debian.org/810719 [perl #126862] ensure > File::Spec::canonpath() preserves taint > DEBPKG:fixes/mkstemp-umask - http://bugs.debian.org/810924 [perl > #127322] [e57270b] Fix umask for mkstemp(3) calls > DEBPKG:fixes/crosscompile-no-targethost - [perl #127234] Fix the > Configure escape with usecrosscompile but no targethost > DEBPKG:fixes/podlators-no-encode - [rt.cpan.org #111156] Degrade > gracefully if utf8 is requested but Encode is not available > DEBPKG:debian/cross-time-hires - [rt.cpan.org #111391] Add an > environment variable to skip running configuration probes > DEBPKG:fixes/encode-unicode-pod - Unicode.pm: Fix POD error > DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in > Memoize > DEBPKG:fixes/ok-pod - Added encoding for pod. > DEBPKG:fixes/CVE-2016-2381_duplicate_env - remove duplicate > environment variables from environ > > --- > @INC for perl 5.22.1: > /home/leo/lib/perl5/x86_64-linux-gnu-thread-multi > /home/leo/lib/perl5 > /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 > /usr/local/share/perl/5.22.1 > /usr/lib/x86_64-linux-gnu/perl5/5.22 > /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl/5.22 > /usr/share/perl/5.22 > /usr/local/lib/site_perl > /usr/lib/x86_64-linux-gnu/perl-base > . > > --- > Environment for perl 5.22.1: > HOME=/home/leo > LANG=en_GB.UTF-8 > LANGUAGE=en_GB:en > LD_LIBRARY_PATH=/home/leo/lib > LOGDIR (unset) > PATH=/home/leo/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games > PERL5LIB=/home/leo/lib/perl5 > PERL_BADLANG (unset) > PERL_MB_OPT=--install_base=/home/leo > PERL_MM_OPT=INSTALL_BASE=/home/leo > SHELL=/bin/bash
-- James E Keenan (jkeenan@cpan.org)
Date: Sun, 5 Jun 2016 03:29:34 +0100
To: perl5-porters [...] perl.org
From: Zefram <zefram [...] fysh.org>
Subject: Re: [perl #128316] CORE::socket() mangles EMFILE and turns it into EBADF
Download (untitled) / with headers
text/plain 979b
LeoNerd wrote: Show quoted text
>If a socket(2) call results in EMFILE (Too many open files), the core perl >socket() syscall turns this into an EBADF message instead.
There is explicit code to do that: fd = PerlSock_socket(domain, type, protocol); if (fd < 0) { SETERRNO(EBADF,RMS_IFI); RETPUSHUNDEF; } The SETERRNO() was introduced by commit 375ed12a in 2014. I don't see from the commit message what this was trying to address. The commit is mainly concerned with the error cases of attempting operations that require an existing fd where the Perl filehandle is closed or otherwise lacks an fd. In those cases it is appropriate to set errno to EBADF. This situation with the return value from socket() is not one of those: it doesn't require an existing fd, errno should already have been set appropriately, and the error was already being detected by Perl (it was doing the RETPUSHUNDEF). So that hunk of the commit looks like a mistake. Jarkko? -zefram
Date: Sun, 5 Jun 2016 16:12:41 +0100
CC: perlbug-followup [...] perl.org
To: perl5-porters [...] perl.org
Subject: Re: [perl #128316] CORE::socket() mangles EMFILE and turns it into EBADF
From: "Paul \"LeoNerd\" Evans" <leonerd [...] leonerd.org.uk>
Download (untitled) / with headers
text/plain 1.4k
On Sat, 4 Jun 2016 19:02:16 -0700 "James E Keenan via RT" <perlbug-followup@perl.org> wrote: Show quoted text
> On Fri Jun 03 08:01:38 2016, leonerd@leonerd.org.uk wrote:
> > This is a bug report for perl from leonerd@leonerd.org.uk, > > generated with the help of perlbug 1.40 running under perl 5.22.1. > > > > > > ----------------------------------------------------------------- > > If a socket(2) call results in EMFILE (Too many open files), the > > core perl > > socket() syscall turns this into an EBADF message instead. > > > > $ ulimit -n 64 > > $ perl -Mblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, > > 0) { push @s, $s; } die $!' > > Bad file descriptor at -e line 1. > >
> > Copying those commands to the command-prompt, I got: > > ##### > $ perl -Mblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, > 0) { push @s, $s; } die $!' Cannot find blib even > in /home/jkeenan/gitwork/perl/../../../../.. BEGIN > failed--compilation aborted. ##### > > Should '-Mblib' actually be '-Iblib'? Only when I made that > correction did I get your results: ##### > $ perl -Iblib -MSocket -E 'while(socket my $s, PF_INET, SOCK_STREAM, > 0) { push @s, $s; } die $!' Bad file descriptor at -e line 1. > #####
Oh oops, that's just a leftover -Mblib from my testing of something else; it doesn't appear to be relevant to the bug. -- Paul "LeoNerd" Evans leonerd@leonerd.org.uk http://www.leonerd.org.uk/ | https://metacpan.org/author/PEVANS
Download (untitled)
application/pgp-signature 181b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 338b
Show quoted text
> This situation with the return value from socket() is not one of those: > it doesn't require an existing fd, errno should already have been set > appropriately, and the error was already being detected by Perl (it > was doing the RETPUSHUNDEF). So that hunk of the commit looks like > a mistake. Jarkko?
Your analysis seems correct.
Date: Tue, 7 Jun 2016 07:02:14 +0100
Subject: Re: [perl #128316] CORE::socket() mangles EMFILE and turns it into EBADF
From: Zefram <zefram [...] fysh.org>
To: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 788b
Jarkko Hietaniemi via RT wrote: Show quoted text
>Your analysis seems correct.
OK, so that hunk should be reverted. Reviewing the rest of the commit, I see two more bugs of this kind. It introduces a similar bug into pp_truncate, in the branch that truncates by name via open+ftruncate. That was fixed by TonyC in d484df69. There's another in pp_fttext, for the case where the file is identified by name and the stat fails. That's still in place. Instead of setting errno to EBADF or doing nothing with it (as was happening before the commit), errno ought to be saved across the closing of the file. All three of these fixes should be candidates for backporting to maint releases. 5.24 has the pp_socket and pp_fttext bugs. 5.22 has all three bugs (pp_socket, pp_truncate, pp_fttext). -zefram
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 901b
On Mon Jun 06 23:02:48 2016, zefram@fysh.org wrote: Show quoted text
> Jarkko Hietaniemi via RT wrote:
> >Your analysis seems correct.
> > OK, so that hunk should be reverted. Reviewing the rest of the commit, > I see two more bugs of this kind. >
... Show quoted text
> > There's another in pp_fttext, for the case where the file is identified > by name and the stat fails. That's still in place. Instead of setting > errno to EBADF or doing nothing with it (as was happening before the > commit), errno ought to be saved across the closing of the file. > > All three of these fixes should be candidates for backporting to maint > releases. 5.24 has the pp_socket and pp_fttext bugs. 5.22 has all > three bugs (pp_socket, pp_truncate, pp_fttext).
Does the attached address the problems you're describing. The test (surprisingly to me) also passes on Win32, though I had to push the limit to 2046 for it to fail there. Tony
Subject: 0001-perl-128316-preserve-errno-from-failed-system-calls.patch
From 3f6b66c14467c0f8c7459e32c576618155ca89f3 Mon Sep 17 00:00:00 2001 From: Tony Cook <tony@develop-help.com> Date: Thu, 16 Jun 2016 14:08:18 +1000 Subject: (perl #128316) preserve errno from failed system calls --- pp_sys.c | 4 ++-- t/io/socket.t | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/pp_sys.c b/pp_sys.c index 33cba46..3bf2673 100644 --- a/pp_sys.c +++ b/pp_sys.c @@ -2497,7 +2497,6 @@ PP(pp_socket) TAINT_PROPER("socket"); fd = PerlSock_socket(domain, type, protocol); if (fd < 0) { - SETERRNO(EBADF,RMS_IFI); RETPUSHUNDEF; } IoIFP(io) = PerlIO_fdopen(fd, "r"SOCKET_OPEN_MODE); /* stdio gets confused about sockets */ @@ -3531,8 +3530,9 @@ PP(pp_fttext) } PL_laststatval = PerlLIO_fstat(fd, &PL_statcache); if (PL_laststatval < 0) { + dSAVE_ERRNO; (void)PerlIO_close(fp); - SETERRNO(EBADF,RMS_IFI); + RESTORE_ERRNO; FT_RETURNUNDEF; } PerlIO_binmode(aTHX_ fp, '<', O_BINARY, NULL); diff --git a/t/io/socket.t b/t/io/socket.t index b51079a..54e4438 100644 --- a/t/io/socket.t +++ b/t/io/socket.t @@ -128,6 +128,28 @@ SKIP: { } } +SKIP: +{ + eval { require Errno; defined &Errno::EMFILE } + or skip "Can't load Errno or EMFILE not defined", 1; + my @socks; + my $sock_limit = 1000; # don't consume every file in the system + # Default limits on various systems I have: + # 65536 - Linux + # 256 - Solaris + # 128 - NetBSD + # 256 - Cygwin + # 256 - darwin + while (@socks < $sock_limit) { + socket my $work, PF_INET, SOCK_STREAM, $tcp + or last; + push @socks, $work; + } + @socks == $sock_limit + and skip "Didn't run out of open handles", 1; + is(0+$!, Errno::EMFILE(), "check correct errno for too many files"); +} + done_testing(); my @child_tests; -- 2.1.4
Subject: Re: [perl #128316] CORE::socket() mangles EMFILE and turns it into EBADF
From: Zefram <zefram [...] fysh.org>
To: perl5-porters [...] perl.org
Date: Thu, 16 Jun 2016 05:38:29 +0100
Download (untitled) / with headers
text/plain 106b
Tony Cook via RT wrote: Show quoted text
>Does the attached address the problems you're describing.
Looks good. -zefram
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 215b
On Wed Jun 15 21:38:55 2016, zefram@fysh.org wrote: Show quoted text
> Tony Cook via RT wrote:
> >Does the attached address the problems you're describing.
> > Looks good.
Applied as 3f6b66c14467c0f8c7459e32c576618155ca89f3. Tony


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org