Skip Menu |
Report information
Id: 128203
Status: resolved
Priority: 0/
Queue: perl6

Owner: Nobody
Requestors: rob [at] hoelz.ro
Cc:
AdminCc:

Severity: (no value)
Tag: (no value)
Platform: (no value)
Patch Status: (no value)
VM: (no value)



Subject: S06-advanced/wrap.t in 6.c-errata roast branch fails a test
Download (untitled) / with headers
text/plain 660b
Here's what the failure looks like: Show quoted text
> # Failed test 'right exception type (X::NoDispatcher)' > # at /tmp/nom/share/perl6/precomp/E329B59A53DA690354B48752DE28FEFA7C5BD5A1.1463791841.84691/C7/C712FE6969F786C9380D643DF17E85D06868219E line 1 > # Expected: X::NoDispatcher > # Got: X::ControlFlow::Return > # Exception message: Attempt to return outside of any Routine > # Looks like you failed 1 test of 2 > not ok 59 - {nextsame}() dies properly
The failure was introduced by e239f6e. For some reason, changing subtest to a multi sub affects how throws-like evaluates strings, and somehow it affects how the dispatcher is set up for nextsame.
Download (untitled) / with headers
text/plain 847b
I have a fix in place, but it's not a permanent solution. I'd like to get the bottom of the true cause. On 2016-05-20 17:57:53, rob@hoelz.ro wrote: Show quoted text
> Here's what the failure looks like: >
> > # Failed test 'right exception type (X::NoDispatcher)' > > # at > > /tmp/nom/share/perl6/precomp/E329B59A53DA690354B48752DE28FEFA7C5BD5A1.1463791841.84691/C7/C712FE6969F786C9380D643DF17E85D06868219E > > line 1 > > # Expected: X::NoDispatcher > > # Got: X::ControlFlow::Return > > # Exception message: Attempt to return outside of any Routine > > # Looks like you failed 1 test of 2 > > not ok 59 - {nextsame}() dies properly
> > The failure was introduced by e239f6e. For some reason, changing > subtest to a multi sub affects how throws-like evaluates strings, and > somehow it affects how the dispatcher is set up for nextsame.
Download (untitled) / with headers
text/plain 228b
It's just a bad test that relies too much on the internal implementation of subtest(). The explanation is here (esp. last few lines with jnthn++'s explanation): https://github.com/rakudo/rakudo/pull/743#issuecomment-210489723
RT-Send-CC: perl6-compiler [...] perl.org
Download (untitled) / with headers
text/plain 335b
On Tue Jun 14 19:51:08 2016, cpan@zoffix.com wrote: Show quoted text
> It's just a bad test that relies too much on the internal > implementation of subtest(). The explanation is here (esp. last few > lines with jnthn++'s explanation): > https://github.com/rakudo/rakudo/pull/743#issuecomment-210489723
So can we close this RT? -- Will "Coke" Coleda
Download (untitled) / with headers
text/plain 467b
On Tue Aug 23 11:57:08 2016, coke wrote: Show quoted text
> So can we close this RT?
After we revert hoelzro's temporary fix (that uses a series of `if/else` in one `sub subtest` in lieu of multi-dispatch) and replicate the fix for the bogus test that's currently in master back in 6.c-errata [or use a better test; I forget whether the use of `subtest` was even needed in that test]. I marked my calendar and will take care of all this on Sept. 10th, unless someone beats me to it.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org