Skip Menu |
Report information
Id: 124127
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: vega.james [at] gmail.com
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: HasPatch
Severity: low
Type:
Perl Version: (no value)
Fixed In: (no value)



Subject: [patch] Restore ability to debug threaded scripts
To: perl5-porters [...] perl.org
Date: Fri, 20 Mar 2015 01:31:31 -0400
From: James McCoy <vega.james [...] gmail.com>
Download (untitled) / with headers
text/plain 1.2k
Prior to Perl 5.18, it was possible to use “perl -d threaded-script.pl” to debug a script which was imports threads/threads::shared. Starting in Perl 5.18, this would fail with lock can only be used on shared values errors coming out of perl5db.pl. It was possible to work around this by running “perl -dt threaded-script.pl”. This would let the debugger run as long as no threads actually got spawned. If a thread was spawned, then the debugger just wedges (c.f., #120170). Ok, some sanity is restored. However, it would still be nice to be able to run with “perl -d” again so debugging of threads can take place. That was still failing due to Modification of a read-only value attempted errors while trying to grow @stack in perl5db.pl. The second patch works around this by pushing onto @stack instead of growing it through setting $#stack to a larger value. There may be a better way to fix this so the $#stack approach still works, but that's a bit beyond my depth currently. Thank you for considering these patches. Currently, 5.18 and 5.20 are basically DOA at $work due to the above issues (and another 5.18-specific issue I'll follow up on). Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <vega.james@gmail.com>

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 884b
On Fri Mar 20 04:11:22 2015, vega.james@gmail.com wrote: Show quoted text
> Prior to Perl 5.18, it was possible to use “perl -d threaded-script.pl” > to debug a script which was imports threads/threads::shared. Starting > in Perl 5.18, this would fail with > > lock can only be used on shared values > > errors coming out of perl5db.pl. It was possible to work around this by > running “perl -dt threaded-script.pl”. This would let the debugger run > as long as no threads actually got spawned. If a thread was spawned, > then the debugger just wedges (c.f., #120170). >
[snip] Would you be able to attach (a) a small but meaningful example of a program with threads that exhibits this behavior under the debugger? Also, could you attach the output of 'perl -V' from the perl build you are using to run that program? Thank you very much. -- James E Keenan (jkeenan@cpan.org)
From: James McCoy <vega.james [...] gmail.com>
Date: Sat, 21 Mar 2015 11:15:02 -0400
To: James E Keenan via RT <perlbug-followup [...] perl.org>
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT wrote: Show quoted text
> On Fri Mar 20 04:11:22 2015, vega.james@gmail.com wrote:
> > Prior to Perl 5.18, it was possible to use “perl -d threaded-script.pl” > > to debug a script which was imports threads/threads::shared. Starting > > in Perl 5.18, this would fail with > > > > lock can only be used on shared values > > > > errors coming out of perl5db.pl. It was possible to work around this by > > running “perl -dt threaded-script.pl”. This would let the debugger run > > as long as no threads actually got spawned. If a thread was spawned, > > then the debugger just wedges (c.f., #120170). > >
> > > [snip] > > Would you be able to attach (a) a small but meaningful example of a program with threads that exhibits this behavior under the debugger? > > Also, could you attach the output of 'perl -V' from the perl build you are using to run that program?
Sure. Attached. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <vega.james@gmail.com>
Download foo.pl
text/x-perl 175b

Message body is not shown because sender requested not to inline it.

Download perl.txt
text/plain 7.9k

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 648b
On Sat Mar 21 08:15:51 2015, vega.james@gmail.com wrote: Show quoted text
> On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT wrote:
> > [snip] > > > > Would you be able to attach (a) a small but meaningful example of a > > program with threads that exhibits this behavior under the debugger? > > > > Also, could you attach the output of 'perl -V' from the perl build > > you are using to run that program?
> > Sure. Attached.
Problem confirmed. I reduced the list of config_args to just '-Dusethreads' to simplify the analysis. See file attached for results before and after applying poster's two patches. -- James E Keenan (jkeenan@cpan.org)
Subject: 124127-debugger-threads-results.txt
# blead, threaded build at commit 539023973b95d208601bd10848496eae785dcacc sh ./Configure -des -Dusedevel -Dusethreads & make -j8 $ ./perl -Ilib -d ~/learn/perl/p5p/124127-foo.pl Loading DB routines from perl5db.pl version 1.48 Editor support available. Enter h or 'h h' for help, or 'man perldebug' for more help. lock can only be used on shared values at lib/perl5db.pl line 4116. BEGIN failed--compilation aborted at /home/jkeenan/learn/perl/p5p/124127-foo.pl line 5. lock can only be used on shared values at lib/perl5db.pl line 2529. END failed--call queue aborted at /home/jkeenan/learn/perl/p5p/124127-foo.pl line 5. Unbalanced scopes: 3 more ENTERs than LEAVEs ##### # git clean -dfx; apply both patches; Configure and build anew as above $ ./perl -Ilib -d ~/learn/perl/p5p/124127-foo.pl Loading DB routines from perl5db.pl version 1.48 Editor support available. Enter h or 'h h' for help, or 'man perldebug' for more help. main::(/home/jkeenan/learn/perl/p5p/124127-foo.pl:12): 12: my $thr = threads->create(\&foo); DB<1> n Hello, world! Debugged program terminated. Use q to quit or R to restart, use o inhibit_exit to avoid stopping after program termination, h q, h R or h o to get additional info. DB<1> q
To: James E Keenan via RT <perlbug-followup [...] perl.org>
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
From: James McCoy <vega.james [...] gmail.com>
Date: Tue, 24 Mar 2015 22:26:26 -0400
Download (untitled) / with headers
text/plain 913b
On Sat, Mar 21, 2015 at 09:49:07AM -0700, James E Keenan via RT wrote: Show quoted text
> On Sat Mar 21 08:15:51 2015, vega.james@gmail.com wrote:
> > On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT wrote:
> > > [snip] > > > > > > Would you be able to attach (a) a small but meaningful example of a > > > program with threads that exhibits this behavior under the debugger? > > > > > > Also, could you attach the output of 'perl -V' from the perl build > > > you are using to run that program?
> > > > Sure. Attached.
> > Problem confirmed. I reduced the list of config_args to just '-Dusethreads' to simplify the analysis. See file attached for results before and after applying poster's two patches.
Would the fix for these issues be candidates for maintenance releases, since it was a regression from 5.16 → 5.18? Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <vega.james@gmail.com>
Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.4k
On Tue Mar 24 19:26:59 2015, vega.james@gmail.com wrote: Show quoted text
> On Sat, Mar 21, 2015 at 09:49:07AM -0700, James E Keenan via RT wrote:
> > On Sat Mar 21 08:15:51 2015, vega.james@gmail.com wrote:
> > > On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT > > > wrote:
> > > > [snip] > > > > > > > > Would you be able to attach (a) a small but meaningful example of > > > > a > > > > program with threads that exhibits this behavior under the > > > > debugger? > > > > > > > > Also, could you attach the output of 'perl -V' from the perl > > > > build > > > > you are using to run that program?
> > > > > > Sure. Attached.
> > > > Problem confirmed. I reduced the list of config_args to just '- > > Dusethreads' to simplify the analysis. See file attached for results > > before and after applying poster's two patches.
> > Would the fix for these issues be candidates for maintenance releases, > since it was a regression from 5.16 → 5.18? > > Cheers,
It would be a candidate but that's subject to caveats. 1) While I've confirmed the bug, I haven't confirmed the fix -- and it's probably outside my expertise to do so. p5p list: Can you review this patch? 2) 5.18 is nearing the May 2015 end of its maintenance window. It is up to the maintenance pumpking to decide whether there will be another release of 5.18 at all. If so, and if the patch is approved, it is eligible. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.7k
On Wed Mar 25 03:27:08 2015, jkeenan wrote: Show quoted text
> On Tue Mar 24 19:26:59 2015, vega.james@gmail.com wrote:
> > On Sat, Mar 21, 2015 at 09:49:07AM -0700, James E Keenan via RT > > wrote:
> > > On Sat Mar 21 08:15:51 2015, vega.james@gmail.com wrote:
> > > > On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT > > > > wrote:
> > > > > [snip] > > > > > > > > > > Would you be able to attach (a) a small but meaningful example > > > > > of > > > > > a > > > > > program with threads that exhibits this behavior under the > > > > > debugger? > > > > > > > > > > Also, could you attach the output of 'perl -V' from the perl > > > > > build > > > > > you are using to run that program?
> > > > > > > > Sure. Attached.
> > > > > > Problem confirmed. I reduced the list of config_args to just '- > > > Dusethreads' to simplify the analysis. See file attached for > > > results > > > before and after applying poster's two patches.
> > > > Would the fix for these issues be candidates for maintenance > > releases, > > since it was a regression from 5.16 → 5.18? > > > > Cheers,
> > It would be a candidate but that's subject to caveats. > > 1) While I've confirmed the bug, I haven't confirmed the fix -- and > it's probably outside my expertise to do so. p5p list: Can you > review this patch? > > 2) 5.18 is nearing the May 2015 end of its maintenance window. It is > up to the maintenance pumpking to decide whether there will be another > release of 5.18 at all. If so, and if the patch is approved, it is > eligible. > > Thank you very much.
Another bug report (https://rt.perl.org/Ticket/Display.html?id=124203) touched upon a very similar problem, but was reported to have introduced a new bug. -- James E Keenan (jkeenan@cpan.org)
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
To: James E Keenan via RT <perlbug-followup [...] perl.org>
Date: Sun, 29 Mar 2015 22:52:00 -0400
From: James McCoy <vega.james [...] gmail.com>
Download (untitled) / with headers
text/plain 2.4k
On Sun, Mar 29, 2015 at 03:03:59PM -0700, James E Keenan via RT wrote: Show quoted text
> On Wed Mar 25 03:27:08 2015, jkeenan wrote:
> > On Tue Mar 24 19:26:59 2015, vega.james@gmail.com wrote:
> > > On Sat, Mar 21, 2015 at 09:49:07AM -0700, James E Keenan via RT > > > wrote:
> > > > On Sat Mar 21 08:15:51 2015, vega.james@gmail.com wrote:
> > > > > On Sat, Mar 21, 2015 at 05:18:17AM -0700, James E Keenan via RT > > > > > wrote:
> > > > > > [snip] > > > > > > > > > > > > Would you be able to attach (a) a small but meaningful example > > > > > > of > > > > > > a > > > > > > program with threads that exhibits this behavior under the > > > > > > debugger? > > > > > > > > > > > > Also, could you attach the output of 'perl -V' from the perl > > > > > > build > > > > > > you are using to run that program?
> > > > > > > > > > Sure. Attached.
> > > > > > > > Problem confirmed. I reduced the list of config_args to just '- > > > > Dusethreads' to simplify the analysis. See file attached for > > > > results > > > > before and after applying poster's two patches.
> > > > > > Would the fix for these issues be candidates for maintenance > > > releases, > > > since it was a regression from 5.16 → 5.18? > > > > > > Cheers,
> > > > It would be a candidate but that's subject to caveats. > > > > 1) While I've confirmed the bug, I haven't confirmed the fix -- and > > it's probably outside my expertise to do so. p5p list: Can you > > review this patch? > > > > 2) 5.18 is nearing the May 2015 end of its maintenance window. It is > > up to the maintenance pumpking to decide whether there will be another > > release of 5.18 at all. If so, and if the patch is approved, it is > > eligible. > > > > Thank you very much.
> > Another bug report (https://rt.perl.org/Ticket/Display.html?id=124203) touched upon a very similar problem, but was reported to have introduced a new bug.
Hmm, I'm not really sure how to debug the debugger. The patches were just based on bisecting to find where the specific behaviors were introduced and making logical changes. Any pointers here would be appreciated. If it is introduced by my patches and not just uncovered by being able to debug threaded scripts again, my guess would be that it's due to 0002-lib-perl5db.pl-Fix-read-only-value-modification.patch (or the commit referenced in that patch). I'll try to dig into this more over the next few days, regardless. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan@debian.org>
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
To: James E Keenan via RT <perlbug-followup [...] perl.org>
Date: Sun, 29 Mar 2015 23:54:52 -0400
From: James McCoy <vega.james [...] gmail.com>
Download (untitled) / with headers
text/plain 624b
On Sun, Mar 29, 2015 at 10:52:00PM -0400, James McCoy wrote: Show quoted text
> > Another bug report (https://rt.perl.org/Ticket/Display.html?id=124203) touched upon a very similar problem, but was reported to have introduced a new bug.
> > Hmm, I'm not really sure how to debug the debugger. The patches were > just based on bisecting to find where the specific behaviors were > introduced and making logical changes.
Except I was missing some logic. :) Updated patch attached to handle the fact that $stack_depth isn't always larger than $#stack. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <vega.james@gmail.com>

Message body is not shown because sender requested not to inline it.

From: Niko Tyni <ntyni [...] debian.org>
CC: James McCoy <vega.james [...] gmail.com>
Date: Mon, 13 Apr 2015 21:46:29 +0300
To: perl5-porters [...] perl.org
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
Download (untitled) / with headers
text/plain 1.1k
On Sun, Mar 29, 2015 at 11:54:52PM -0400, James McCoy wrote: Show quoted text
> From 05bc4308e4b82982cebdf08c970cba7bbb599356 Mon Sep 17 00:00:00 2001 > From: James McCoy <vega.james@gmail.com> > Date: Thu, 19 Mar 2015 23:05:35 -0400 > Subject: [PATCH 2/2] lib/perl5db.pl: Fix "read-only value" modification > > ce0d59fdd1c7d145efdf6bf8da56a259fed483e4 changed handling of > non-existent array elements. This causes "perl -d threaded-script.pl" > to error out with the "Modification of a read-only value attempted" > error. > > Pushing/popping @stack rather than resizing by changing the max index > avoids this error.
This seems to me like a workaround for a deeper problem. I don't see why extending the @stack array by modifying $#stack should create read-only elements. It's probably the same thing as this regression: % perl -Mthreads -le 'my @a = ("foo"); threads->create(sub { $#a=1; $a[1]="bar"; print @a})->join;' Thread 1 terminated abnormally: Modification of a read-only value attempted at -e line 1. which (also) regressed with ce0d59fdd1c7d145efdf6bf8da56a259fed483e4. Reproducible with current blead (v5.21.10-71-g2c04452) with just "Configure -des -Dusethreads -Dusedevel". -- Niko Tyni ntyni@debian.org
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.8k
On Mon Apr 13 11:47:06 2015, ntyni@debian.org wrote: Show quoted text
> On Sun, Mar 29, 2015 at 11:54:52PM -0400, James McCoy wrote: >
> > From 05bc4308e4b82982cebdf08c970cba7bbb599356 Mon Sep 17 00:00:00 > > 2001 > > From: James McCoy <vega.james@gmail.com> > > Date: Thu, 19 Mar 2015 23:05:35 -0400 > > Subject: [PATCH 2/2] lib/perl5db.pl: Fix "read-only value" > > modification > > > > ce0d59fdd1c7d145efdf6bf8da56a259fed483e4 changed handling of > > non-existent array elements. This causes "perl -d threaded- > > script.pl" > > to error out with the "Modification of a read-only value attempted" > > error. > > > > Pushing/popping @stack rather than resizing by changing the max index > > avoids this error.
> > This seems to me like a workaround for a deeper problem. I don't see > why > extending the @stack array by modifying $#stack should create read- > only > elements. > > It's probably the same thing as this regression: > > % perl -Mthreads -le 'my @a = ("foo"); threads->create(sub { $#a=1; > $a[1]="bar"; print @a})->join;' > Thread 1 terminated abnormally: Modification of a read-only value > attempted at -e line 1. > > which (also) regressed with ce0d59fdd1c7d145efdf6bf8da56a259fed483e4. > > Reproducible with current blead (v5.21.10-71-g2c04452) > with just "Configure -des -Dusethreads -Dusedevel".
The attached fixes that issue for me, but when I try to use the debugger I see: $ ./perl -Ilib -d ../123127.pl Loading DB routines from perl5db.pl version 1.48 Editor support available. Enter h or 'h h' for help, or 'man perldebug' for more help. lock can only be used on shared values at lib/perl5db.pl line 4116. BEGIN failed--compilation aborted at ../123127.pl line 5. lock can only be used on shared values at lib/perl5db.pl line 2529. END failed--call queue aborted at ../123127.pl line 5. perl: perl.c:584: perl_destruct: Assertion `(my_perl->Iscopestack_ix) == 0' failed. Aborted (-DDEBUGGING build) Tony
Subject: 0001-perl-124127-fix-cloning-arrays-with-unused-elements.patch
From a7efcbd868beeeca474ca98b6137570053c6fecc Mon Sep 17 00:00:00 2001 From: Tony Cook <tony@develop-help.com> Date: Tue, 14 Apr 2015 15:59:03 +1000 Subject: [PATCH] [perl #124127] fix cloning arrays with unused elements ce0d59fd changed arrays to use NULL instead of &PL_sv_undef for unused elements, unfortunately it missed updating sv_dup_common()'s initialization of unused elements, leaving them as NULL. This resulted in modification of read only value errors at runtime. --- sv.c | 2 +- t/op/threads.t | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/sv.c b/sv.c index 467dc24..2bb0346 100644 --- a/sv.c +++ b/sv.c @@ -13641,7 +13641,7 @@ S_sv_dup_common(pTHX_ const SV *const sstr, CLONE_PARAMS *const param) } items = AvMAX((const AV *)sstr) - AvFILLp((const AV *)sstr); while (items-- > 0) { - *dst_ary++ = &PL_sv_undef; + *dst_ary++ = NULL; } } else { diff --git a/t/op/threads.t b/t/op/threads.t index 6fb2410..e76c956 100644 --- a/t/op/threads.t +++ b/t/op/threads.t @@ -9,7 +9,7 @@ BEGIN { skip_all_without_config('useithreads'); skip_all_if_miniperl("no dynamic loading on miniperl, no threads"); - plan(27); + plan(28); } use strict; @@ -399,4 +399,10 @@ fresh_perl_is( 'no crash when deleting $::{INC} in thread' ); +fresh_perl_is(<<'CODE', 'ok', 'no crash modifying extended array element'); +use threads; +my @a = 1; +threads->create(sub { $#a = 1; $a[1] = 2; print qq/ok\n/ })->join; +CODE + # EOF -- 1.7.10.4
Subject: Re: [perl #124127] [patch] Restore ability to debug threaded scripts
To: Tony Cook via RT <perlbug-followup [...] perl.org>
CC: James McCoy <vega.james [...] gmail.com>
From: Niko Tyni <ntyni [...] debian.org>
Date: Tue, 14 Apr 2015 21:41:51 +0300
Download (untitled) / with headers
text/plain 1.4k
On Mon, Apr 13, 2015 at 11:06:21PM -0700, Tony Cook via RT wrote: Show quoted text
> On Mon Apr 13 11:47:06 2015, ntyni@debian.org wrote:
Show quoted text
> > % perl -Mthreads -le 'my @a = ("foo"); threads->create(sub { $#a=1; > > $a[1]="bar"; print @a})->join;' > > Thread 1 terminated abnormally: Modification of a read-only value > > attempted at -e line 1. > > > > which (also) regressed with ce0d59fdd1c7d145efdf6bf8da56a259fed483e4. > > > > Reproducible with current blead (v5.21.10-71-g2c04452) > > with just "Configure -des -Dusethreads -Dusedevel".
> > The attached fixes that issue for me, but when I try to use the debugger I see: > > $ ./perl -Ilib -d ../123127.pl > > Loading DB routines from perl5db.pl version 1.48 > Editor support available. > > Enter h or 'h h' for help, or 'man perldebug' for more help. > > lock can only be used on shared values at lib/perl5db.pl line 4116.
Awesome, thanks! The original patch 1/2 in this ticket by James McCoy fixes the other problem by reintroducing the lock prototype removed in v5.17.5-409-gcde405a. So the 'perl -d threaded-script.pl' breakage was a 5.17.6 regression and the 'Modification of a read-only value' issue just broke it further in 5.19.4. I can confirm that applying your patch and https://rt.perl.org/Ticket/Attachment/1336725/714399/0001-lib-perl5db.pl-Restore-noop-lock-prototype.patch make the debugger work again for me, at least on a trivial threaded script. Hope this clarifies -- Niko Tyni ntyni@debian.org
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.6k
On Tue Apr 14 11:42:47 2015, ntyni@debian.org wrote: Show quoted text
> On Mon, Apr 13, 2015 at 11:06:21PM -0700, Tony Cook via RT wrote:
> > On Mon Apr 13 11:47:06 2015, ntyni@debian.org wrote:
>
> > > % perl -Mthreads -le 'my @a = ("foo"); threads->create(sub { > > > $#a=1; > > > $a[1]="bar"; print @a})->join;' > > > Thread 1 terminated abnormally: Modification of a read-only value > > > attempted at -e line 1. > > > > > > which (also) regressed with > > > ce0d59fdd1c7d145efdf6bf8da56a259fed483e4. > > > > > > Reproducible with current blead (v5.21.10-71-g2c04452) > > > with just "Configure -des -Dusethreads -Dusedevel".
> > > > The attached fixes that issue for me, but when I try to use the > > debugger I see: > > > > $ ./perl -Ilib -d ../123127.pl > > > > Loading DB routines from perl5db.pl version 1.48 > > Editor support available. > > > > Enter h or 'h h' for help, or 'man perldebug' for more help. > > > > lock can only be used on shared values at lib/perl5db.pl line 4116.
> > Awesome, thanks! The original patch 1/2 in this ticket by James McCoy > fixes the other problem by reintroducing the lock prototype removed > in v5.17.5-409-gcde405a. > > So the 'perl -d threaded-script.pl' breakage was a 5.17.6 regression > and the > 'Modification of a read-only value' issue just broke it further in > 5.19.4. > > I can confirm that applying your patch and > https://rt.perl.org/Ticket/Attachment/1336725/714399/0001-lib- > perl5db.pl-Restore-noop-lock-prototype.patch > make the debugger work again for me, at least on a trivial threaded > script. > > Hope this clarifies
You're right. This fixes the default case, unfortunately PERL5DB_THREADED is also broken, I'll open a new ticket for that. Tony
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 520b
On Tue Apr 14 17:23:55 2015, tonyc wrote: Show quoted text
> > I can confirm that applying your patch and > > https://rt.perl.org/Ticket/Attachment/1336725/714399/0001-lib- > > perl5db.pl-Restore-noop-lock-prototype.patch > > make the debugger work again for me, at least on a trivial threaded > > script. > > > > Hope this clarifies
> > You're right. > > This fixes the default case, ...
These aren't regressions from 5.20, but I think they're serious enough to be blockers, so I'll make this ticket a 5.22 blocker. Opinions? Tony
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 689b
On Tue Apr 14 18:14:16 2015, tonyc wrote: Show quoted text
> On Tue Apr 14 17:23:55 2015, tonyc wrote:
> > > I can confirm that applying your patch and > > > https://rt.perl.org/Ticket/Attachment/1336725/714399/0001-lib- > > > perl5db.pl-Restore-noop-lock-prototype.patch > > > make the debugger work again for me, at least on a trivial threaded > > > script. > > > > > > Hope this clarifies
> > > > You're right. > > > > This fixes the default case, ...
> > These aren't regressions from 5.20, but I think they're serious enough to be > blockers, so I'll make this ticket a 5.22 blocker.
Applied as 41ef2c66e0da6dfb04ded81b979f7081007a1add and 902d16915db2735c3a41f15ef8d95cf300c31801. Closing Tony


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org