New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH 1/11] lib/h2ph.t: keep tmpfiles on error #14581
Comments
From @rurbanThis is a bug report for perl from rurban@cpanel.net, lib/h2ph.t: keep tmpfiles on error It's extremely hard to analyse h2ph errors without those tempfiles, See also Flags: Site configuration information for perl 5.21.9: Configured by rurban at Sun Feb 22 17:14:55 CET 2015. Summary of my perl5 (revision 5 version 21 subversion 9) configuration: Locally applied patches: @INC for perl 5.21.9: Environment for perl 5.21.9: |
From @rurban0001-lib-h2ph.t-keep-tmpfiles-on-error.patchFrom c24da5bd5e15c615b405f4837777abcf513126ff Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@cpanel.net>
Date: Sat, 21 Feb 2015 10:11:47 +0100
Subject: [PATCH] lib/h2ph.t: keep tmpfiles on error
It's extremely hard to analyse h2ph errors without those tempfiles,
and errors do not happen for the normal case.
---
lib/h2ph.t | 2 ++
1 file changed, 2 insertions(+)
diff --git lib/h2ph.t lib/h2ph.t
index 64d9dc0..78466df 100644
--- lib/h2ph.t
+++ lib/h2ph.t
@@ -57,6 +57,8 @@ is( $result, '', "output free of warnings" );
# cleanup
END {
+ if (!$result) {
1 while unlink("lib/h2ph.ph");
1 while unlink("_h2ph_pre.ph");
+ }
}
--
2.1.4
|
From @tonycozOn Sat Mar 14 03:45:43 2015, rurban@cpanel.net wrote:
When you're trying to diagnose such errors you can temporarily comment Leaving the files in on failure will leave trash that may cause problems with Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sun Mar 29 17:05:03 2015, tonyc wrote:
Rejecting this patch, I don't think it's needed, and it's harmful in some circumstances. Tony |
@tonycoz - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#124062 (status was 'rejected')
Searchable as RT124062$
The text was updated successfully, but these errors were encountered: