New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.21.6-51-ge41e986 breaks BDB #14353
Comments
From @cpansproutFormerly the & prototype allowed ‘undef’ as an argument, contrary to the documentation. that changed in v5.21.6-51-ge41e986. The question is: Do we need to permit ‘undef’ and adjust the documentation? Or does BDB need to be fixed? -- Father Chrysostomos |
From @ikegamiOn Sun, Dec 21, 2014 at 2:33 PM, Father Chrysostomos <
It feels wrong to allow undef, but I don't have a good argument for or The only thing I have is that permitting undef would be inconsistent
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sun Dec 21 11:33:02 2014, sprout wrote:
I think it's a bug fix, and if BDB depends on that bug it needs to be fixed. Tony |
From @andkalso affected JNQUINTIN/Math-Permute-Array-0.043.tar.gz (brought to my attention by Slaven Rezić) -- |
From @cpansproutOn Tue Mar 24 00:20:05 2015, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
Patch at <https://rt.cpan.org/Ticket/Display.html?id=103041>. -- Father Chrysostomos |
From @rjbsI can't easily compile BDB here. Is the fix as simple as changing the PROTOTYPE entry for set_sync_prepare in BDB.xs to ";&" ? Could someone verify this? -- |
From @iabynOn Mon, Apr 27, 2015 at 03:15:34PM -0700, Ricardo SIGNES via RT wrote:
Not really. It would also have to change the XS implementation to handle Looking at the usage in BDB, I think an undef value should still be BDB.pm does this as part of its initialisation: set_sync_prepare (undef); where set_sync_prepare() is used to register a callback. So in this case Looking at the original '&' ticket, #123062: & prototype is too permissive I think it's correct that it should dis-allow array refs etc, but I think -- |
From @iabynOn Tue, May 05, 2015 at 04:33:21PM +0100, Dave Mitchell wrote:
If no one objects, I'll merge the following commit once it's smoked: commit 343d03e allow undef as an arg to '&' prototype -- |
From @rjbs* Dave Mitchell <davem@iabyn.com> [2015-05-05T11:33:21]
I wrote many, many long responses to this, each one different than the So, instead, I think we have a really simple choice. Here's what the docs say An "&" requires an anonymous subroutine, which, if passed as the first The old behavior allows: sub takes_sub (&) { ... } ...which contradicts the documentation. We should change the behavior or we Changing the documentation and leaving the code alone (relative to v5.20) will Changing the code and leaving the documentation alone (again, relative to Nonetheless, it is with heavy heart that I think I agree with the suggested Boy, do I ever dislike prototypes! If anybody wants to change my mind, do so quickly! ;) Or wait to try again in -- |
From @iabynOn Wed, May 06, 2015 at 09:26:47AM -0400, Ricardo Signes wrote:
Now merged with v5.21.11-77-g8283f70 -- |
@iabyn - Status changed from 'open' to 'pending release' |
From @khwilliamsonThanks for submitting this ticket The issue should be resolved with the release today of Perl v5.22, available at http://www.perl.org/get.html -- |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#123475 (status was 'resolved')
Searchable as RT123475$
The text was updated successfully, but these errors were encountered: