Skip Menu |
Report information
Id: 123359
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: yoduh <jim.cromie [at] gmail.com>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: HasPatch
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



To: perlbug [...] perl.org
From: Jim Cromie <jim.cromie [...] gmail.com>
Subject: [patches 2/2] fix PERL_TRACE_OPS for threads, tweak for usability.
Date: Wed, 3 Dec 2014 12:46:15 -0700
Download (untitled) / with headers
text/plain 341b

1st adds Zero to perl-clone-using,

2nd does various tweaks to make it pass tests, be more usable.
- print only when -D.. given on cmd-line
- print only non-zero (good for -e tests)


I thought about adding

#ifdef PERL_TRACE_OPS && !defined(DEBUGGING)
#error "PERL_TRACE_OPS needs DEBUGGING too"
#endif

to dissuade casual builds slightly.
Download traceops-patch
application/octet-stream 4.9k

Message body not shown because it is not plain text.

Date: Thu, 4 Dec 2014 11:08:33 -0700
To: Perl 5 Porters <perl5-porters [...] perl.org>
From: Jim Cromie <jim.cromie [...] gmail.com>
Subject: Re: [perl #123359] [patches 2/2] fix PERL_TRACE_OPS for threads, tweak for usability.
Download (untitled) / with headers
text/plain 906b

sorry, I could have explained better.

 
Show quoted text
1st adds Zero to perl-clone-using,


ie 

diff --git a/sv.c b/sv.c

index 04b8fa8..6eb68e8 100644

--- a/sv.c

+++ b/sv.c

@@ -15010,6 +15010,10 @@ perl_clone_using(PerlInterpreter *proto_perl, UV flags,

}

}

+#ifdef PERL_TRACE_OPS

+ Zero(PL_op_exec_cnt, OP_max+2, UV);

+#endif

+



without it, each sub-thread in a threaded -DPERL_TRACE_OPS build

will print the same big number (99%), which prints as "abababab" in %x,

an obvious poison value in the interpreter struct


sure, who in their right mind would build such a thing, but ...

 
Show quoted text

2nd does various tweaks to make it pass tests, be more usable.
- print only when -D.. given on cmd-line
Show quoted text
- print only non-zero (good for -e tests)



ie perl_destruct prints op-counts only when enabled with -Dv or such,
and only those actually used, which makes perl -Dv -e 1  print a short/readable list.



RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 551b
On Wed Dec 03 11:47:09 2014, yoduh wrote: Show quoted text
> 1st adds Zero to perl-clone-using, > > 2nd does various tweaks to make it pass tests, be more usable. > - print only when -D.. given on cmd-line > - print only non-zero (good for -e tests) > > > I thought about adding > > #ifdef PERL_TRACE_OPS && !defined(DEBUGGING) > #error "PERL_TRACE_OPS needs DEBUGGING too" > #endif > > to dissuade casual builds slightly.
I'm not sure I'd want to apply your change without that, or some other way of enabling the trace dump, such an environment variable. Tony
Date: Tue, 10 May 2016 09:01:24 -0600
From: Jim Cromie <jim.cromie [...] gmail.com>
Subject: [perl #123359] can be closed
To: perlbug [...] perl.org
Download (untitled) / with headers
text/plain 151b
123359 [patches 2/2] fix PERL_TRACE_OPS for threads, tweak for usability. open perl5 Nobody 0 this ticket is superceded / obsoleted by [perl #127880]


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org