New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patches 2/2] fix PERL_TRACE_OPS for threads, tweak for usability. #14299
Comments
From @jimc1st adds Zero to perl-clone-using, 2nd does various tweaks to make it pass tests, be more usable. I thought about adding #ifdef PERL_TRACE_OPS && !defined(DEBUGGING) to dissuade casual builds slightly. |
From @jimc |
From @jimcsorry, I could have explained better.
ie diff --git a/sv.c b/sv.c index 04b8fa8..6eb68e8 100644 --- a/sv.c +++ b/sv.c @@ -15010,6 +15010,10 @@ perl_clone_using(PerlInterpreter *proto_perl, UV } } +#ifdef PERL_TRACE_OPS + Zero(PL_op_exec_cnt, OP_max+2, UV); +#endif + without it, each sub-thread in a threaded -DPERL_TRACE_OPS build will print the same big number (99%), which prints as "abababab" in %x, an obvious poison value in the interpreter struct sure, who in their right mind would build such a thing, but ...
- print only non-zero (good for -e tests) ie perl_destruct prints op-counts only when enabled with -Dv or such, |
From @tonycozOn Wed Dec 03 11:47:09 2014, yoduh wrote:
I'm not sure I'd want to apply your change without that, or some other way of enabling the trace dump, such an environment variable. Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @jimc123359 [patches 2/2] fix PERL_TRACE_OPS for threads, tweak for this ticket is superceded / obsoleted by [perl #127880] |
Migrated from rt.perl.org#123359 (status was 'open')
Searchable as RT123359$
The text was updated successfully, but these errors were encountered: