Skip Menu |
Report information
Id: 121431
Status: resolved
Priority: 0/
Queue: perl5

Owner: alh <wolfsage [at] gmail.com>
Requestors: alh <wolfsage [at] gmail.com>
Cc:
AdminCc:

Operating System: Linux
PatchStatus: (no value)
Severity: low
Type:
  • core
  • Patch
Perl Version: 5.14.2
Fixed In: (no value)



From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Subject: [PATCH] Add support for test.valgrind parallel testing
Date: Thu, 13 Mar 2014 08:39:35 -0400
To: perlbug [...] perl.org
This is a bug report for perl from wolfsage@gmail.com, generated with the help of perlbug 1.39 running under perl 5.14.2. ----------------------------------------------------------------- [Please describe your issue here] The included patch allows test.valgrind to run tests in parallel. Valgrind output for each test will be printed out after the test completes, with the name of the test prefixing every line. Example usage might be: TEST_JOBS=8 make test.valgrind VALGRIND='valgrind -q' 2>&1 | tee out.txt -q is needed to ensure only *errors* are captured, otherwise the output will be much louder than it already is. (Perhaps this should be the default mode?) [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=core severity=low --- Site configuration information for perl 5.14.2: Configured by Debian Project at Mon Mar 18 19:16:26 UTC 2013. Summary of my perl5 (revision 5 version 14 subversion 2) configuration: Platform: osname=linux, osvers=2.6.42-37-generic, archname=x86_64-linux-gnu-thread-multi uname='linux batsu 2.6.42-37-generic #58-ubuntu smp thu jan 24 15:28:10 utc 2013 x86_64 x86_64 x86_64 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.14 -Darchlib=/usr/lib/perl/5.14 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.14.2 -Dsitearch=/usr/local/lib/perl/5.14.2 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.14.2 -des' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -g', cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='', gccversion='4.6.3', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=, so=so, useshrplib=true, libperl=libperl.so.5.14.2 gnulibc_version='2.15' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector' Locally applied patches: --- @INC for perl 5.14.2: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl . --- Environment for perl 5.14.2: HOME=/home/mhorsfall LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/mhorsfall/perl5/perlbrew/bin:/home/mhorsfall/bin:/home/mhorsfall/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games PERLBREW_BASHRC_VERSION=0.66 PERLBREW_HOME=/home/mhorsfall/.perlbrew PERLBREW_ROOT=/home/mhorsfall/perl5/perlbrew PERL_BADLANG (unset) SHELL=/bin/bash

Message body is not shown because sender requested not to inline it.

Date: Sat, 15 Mar 2014 05:30:30 -0400
To: Perl5 Porters <perl5-porters [...] perl.org>
Subject: Re: [perl #121431] [PATCH] Add support for test.valgrind parallel testing
CC: bugs-bitbucket [...] rt.perl.org
From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Download (untitled) / with headers
text/plain 160b
The previous patch didn't clean out the valgrind-current files before running tests, so output from previous test runs could interfere. This patch fixes that.

Message body is not shown because sender requested not to inline it.

From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
To: Perl5 Porters <perl5-porters [...] perl.org>
Date: Sat, 15 Mar 2014 09:20:48 -0400
Subject: Re: [perl #121431] [PATCH] Add support for test.valgrind parallel testing
CC: bugs-bitbucket [...] rt.perl.org
Download (untitled) / with headers
text/plain 418b
While I think this patch makes parallel testing possible and testing of valgrind faster, it abandons some of the expected behavior of t/TEST with regards to valgrind tests. (Detecting/reporting on failures/warnings. Renaming of output files. Etc) I need to consider this more thoroughly (but by all means, use this until I've submitted a more correct one, hopefully in the next day/week.) -- Matthew Horsfall (alh)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 544b
On Sat Mar 15 06:21:11 2014, alh wrote: Show quoted text
> While I think this patch makes parallel testing possible and testing > of valgrind faster, it abandons some of the expected behavior of > t/TEST with regards to valgrind tests. (Detecting/reporting on > failures/warnings. Renaming of output files. Etc) > > I need to consider this more thoroughly (but by all means, use this > until I've submitted a more correct one, hopefully in the next > day/week.) >
Matthew: Will you be submitting a new patch for this ticket? Thank you very much. Jim Keenan
From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Subject: Re: [perl #121431] [PATCH] Add support for test.valgrind parallel testing
CC: Perl5 Porters <perl5-porters [...] perl.org>
To: perlbug-followup [...] perl.org
Date: Wed, 28 May 2014 12:59:55 -0400
Download (untitled) / with headers
text/plain 255b
On Sun, May 18, 2014 at 7:09 PM, James E Keenan via RT <perlbug-followup@perl.org> wrote: Show quoted text
> Matthew: Will you be submitting a new patch for this ticket? >
New version committed in be075ca. I need to update perlhacktips next. -- Matthew Horsfall (alh)
RT-Send-CC: perl5-porters [...] perl.org
And with 037ab3f it's documented. Closing. -- Matthew Horsfall (alh)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org