Skip Menu |
Report information
Id: 121277
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: bulk88 <bulk88 [at] hotmail.com>
Cc:
AdminCc:

Operating System: mswin32
PatchStatus: (no value)
Severity: High
Type: utilities
Perl Version: 5.19.9
Fixed In: (no value)



Subject: Commit "Make perlbug Unicode-aware." broke perlbug on Win32
Date: Tue, 18 Feb 2014 18:20:18 -0500
To: perlbug [...] perl.org
From: bulk88 <bulk88 [...] hotmail.com>
Download (untitled) / with headers
text/plain 3.7k
This is a bug report for perl from bulk88@hotmail.com, generated with the help of perlbug 1.40 running under perl 5.19.9. ----------------------------------------------------------------- [Please describe your issue here] Commit "Make perlbug Unicode-aware." 092c3affc299403d8cc5278d27c9961bca81efd6 broke perlbug on Win32. Previously perlbug always produced /r/n Win32 newlined text files. After that commit I get unix newlined reports. I now can't edit them (perlbug is set by default to use notepad on Win32 since forever, I like it that way). See attached screenshot. Reverting that commit using git, then running perlbug.pl to rebuild perlbug (no ext), then running that perlbug (no ext), fixes the problem for me. I recently upgraded my system blead perl from around 5.19.4-ish to last sunday's blead so it is getting reported now. [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=utilities severity=high --- Site configuration information for perl 5.19.9: Configured by Owner at Wed Feb 12 06:47:30 2014. Summary of my perl5 (revision 5 version 19 subversion 9) configuration: Derived from: 633f0fd2ca244ca83cc99b3af3a7d3ac2931850b Platform: osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread uname='' config_args='undef' hint=recommended, useposix=true, d_sigaction=undef useithreads=define, usemultiplicity=define use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cl', ccflags ='-nologo -GF -W3 -Od -MD -Zi -DDEBUGGING -DWIN32 -D_CONSOLE -DNO_STRICT -DPERL_TEXTMODE_SCRIPTS -DPERL_HASH_FUNC_ONE_AT_A_TIME -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T', optimize='-Od -MD -Zi -DDEBUGGING', cppflags='-DWIN32' ccversion='13.10.6030', gccversion='', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='link', ldflags ='-nologo -nodefaultlib -debug -libpath:"c:\perl519\lib\CORE" -machine:x86' libpth="C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\lib" libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl519.lib gnulibc_version='' Dynamic Linking: dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -libpath:"c:\perl519\lib\CORE" -machine:x86' Locally applied patches: uncommitted-changes --- @INC for perl 5.19.9: C:/perl519/site/lib C:/perl519/lib . --- Environment for perl 5.19.9: HOME (unset) LANG (unset) LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=C:\perl519\bin;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\IDE;C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\BIN;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin\prerelease;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\system32\wbem; PERL_BADLANG (unset) SHELL (unset)
perlbugreportbroken.PNG
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 139b
This ticket got discussion in http://www.nntp.perl.org/group/perl.perl5.porters/2014/03/msg213931.html -- bulk88 ~ bulk88 at hotmail.com
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
To: Craig Berry via RT <perlbug-followup [...] perl.org>
Date: Sat, 29 Mar 2014 18:08:55 -0500
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Subject: Re: [perl #121277] Commit "Make perlbug Unicode-aware." broke perlbug on Win32
Download (untitled) / with headers
text/plain 630b
On Mon, Mar 24, 2014 at 4:52 PM, bulk88 via RT <perlbug-followup@perl.org> wrote: Show quoted text
I took a (blind) stab at trying to add the :crlf layer everywhere that I thought perlbug was opening a file for output that might later be opened by a user, or when perlbug was opening for input a file previously created that way: http://perl5.git.perl.org/perl.git/commitdiff/89405f1ff7acf59b59c9f5f21d2b7b539140f360 This is on the branch craigb/perlbug_encoding_fixup. It has not been tested at all yet -- you could be the first :-).
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 876b
On Sat Mar 29 16:09:18 2014, craig.a.berry@gmail.com wrote: Show quoted text
> On Mon, Mar 24, 2014 at 4:52 PM, bulk88 via RT > <perlbug-followup@perl.org> wrote: > > I took a (blind) stab at trying to add the :crlf layer everywhere that > I thought perlbug was opening a file for output that might later be > opened by a user, or when perlbug was opening for input a file > previously created that way: > > http://perl5.git.perl.org/perl.git/commitdiff/89405f1ff7acf59b59c9f5f21d2b7b539140f360 > > This is on the branch craigb/perlbug_encoding_fixup. It has not been > tested at all yet -- you could be the first :-).
branch craigb/perlbug_encoding_fixup is fine, problem in notepad is now gone in that branch. I say feel free to merge. -- bulk88 ~ bulk88 at hotmail.com
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 421b
On Mon Mar 31 18:29:48 2014, bulk88 wrote: Show quoted text
> On Sat Mar 29 16:09:18 2014, craig.a.berry@gmail.com wrote:
> > > > This is on the branch craigb/perlbug_encoding_fixup. It has not been > > tested at all yet -- you could be the first :-).
> > branch craigb/perlbug_encoding_fixup is fine, problem in notepad is > now gone in that branch. I say feel free to merge.
Bump. Its commit time. -- bulk88 ~ bulk88 at hotmail.com
Subject: Re: [perl #121277] Commit "Make perlbug Unicode-aware." broke perlbug on Win32
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Date: Fri, 4 Apr 2014 09:13:49 -0500
To: Craig Berry via RT <perlbug-followup [...] perl.org>
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
On Fri, Apr 4, 2014 at 1:28 AM, bulk88 via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Mon Mar 31 18:29:48 2014, bulk88 wrote:
>> On Sat Mar 29 16:09:18 2014, craig.a.berry@gmail.com wrote:
>> > >> > This is on the branch craigb/perlbug_encoding_fixup. It has not been >> > tested at all yet -- you could be the first :-).
>> >> branch craigb/perlbug_encoding_fixup is fine, problem in notepad is >> now gone in that branch. I say feel free to merge.
> > Bump. Its commit time.
Since we're in code freeze, it doesn't get committed without specific say-so from the pumpking. Also, further discussion at http://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html suggests a better path forward for encoding might be to assume UTF-8 for report text provided by the user unless the user specifies an override. No one has commented on that nor have I gotten around to implementing it. If we go that route it would touch all the same places this branch touches to add the :crlf layer and it would be cleaner to do all the layer handling in one shot.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 615b
On Fri Apr 04 07:14:11 2014, craig.a.berry@gmail.com wrote: Show quoted text
> Since we're in code freeze, it doesn't get committed without specific > say-so from the pumpking. Also, further discussion at > > http://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html > > suggests a better path forward for encoding […]
Please go ahead and apply. If we get a better patch, that's great, too. Hopefully I can give this some time in the future myself. I think the "assume UTF-8 and provide a user override" is probably a good next step. Meantime, this much less broken is probably less broken enough. -- rjbs
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Subject: Re: [perl #121277] Commit "Make perlbug Unicode-aware." broke perlbug on Win32
To: Craig Berry via RT <perlbug-followup [...] perl.org>
Date: Thu, 10 Apr 2014 22:24:10 -0500
Download (untitled) / with headers
text/plain 919b
On Mon, Apr 7, 2014 at 9:24 AM, Ricardo SIGNES via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Fri Apr 04 07:14:11 2014, craig.a.berry@gmail.com wrote:
>> Since we're in code freeze, it doesn't get committed without specific >> say-so from the pumpking. Also, further discussion at >> >> http://www.nntp.perl.org/group/perl.perl5.porters/2014/04/msg214162.html >> >> suggests a better path forward for encoding [...]
> > Please go ahead and apply.
After some more testing, it's now in blead. Show quoted text
> If we get a better patch, that's great, too. Hopefully I can give this some time in the future myself. I think the "assume UTF-8 and provide a user override" is probably a good next step. Meantime, this much less broken is probably less broken enough.
I've started to look at implementing the UTF-8 default with override option and will put it in a branch for perusal. Not necessarily in time for 5.20 but we'll see.
RT-Send-CC: perl5-porters [...] perl.org
As the critical breakage is gone, I've removed this from the blockers list. -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org