Skip Menu |
Report information
Id: 121126
Status: resolved
Priority: 0/
Queue: perl5

Owner: tonyc <tony [at] develop-help.com>
Requestors: alh <wolfsage [at] gmail.com>
Cc:
AdminCc:

Operating System: Linux
PatchStatus: (no value)
Severity: low
Type:
Perl Version: 5.14.2
Fixed In: (no value)



To: perlbug [...] perl.org
Subject: [PATCH] Bring back test.deparse for smoking
From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Date: Thu, 30 Jan 2014 22:40:39 -0500
This is a bug report for perl from wolfsage@gmail.com, generated with the help of perlbug 1.39 running under perl 5.14.2. ----------------------------------------------------------------- [Please describe your issue here] Added back in test.deparse test target. It now runs all tests with t/TEST, and supports: * Skipping known bad tests entirely without running them * Running tests that are expected to fail, and "skipping" them if they do Or, if they pass, throwing an error to let us know the test now works This should allow us to smoke it and make sure things don't get any worse, while allowing us to fix things as we have time. [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=core severity=low --- Site configuration information for perl 5.14.2: Configured by Debian Project at Mon Mar 18 19:16:26 UTC 2013. Summary of my perl5 (revision 5 version 14 subversion 2) configuration: Platform: osname=linux, osvers=2.6.42-37-generic, archname=x86_64-linux-gnu-thread-multi uname='linux batsu 2.6.42-37-generic #58-ubuntu smp thu jan 24 15:28:10 utc 2013 x86_64 x86_64 x86_64 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.14 -Darchlib=/usr/lib/perl/5.14 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.14.2 -Dsitearch=/usr/local/lib/perl/5.14.2 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.14.2 -des' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -g', cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='', gccversion='4.6.3', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=, so=so, useshrplib=true, libperl=libperl.so.5.14.2 gnulibc_version='2.15' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector' Locally applied patches: --- @INC for perl 5.14.2: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl . --- Environment for perl 5.14.2: HOME=/home/mhorsfall LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/home/mhorsfall/perl5/perlbrew/bin:/home/mhorsfall/bin:/home/mhorsfall/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games PERLBREW_BASHRC_VERSION=0.66 PERLBREW_HOME=/home/mhorsfall/.perlbrew PERLBREW_ROOT=/home/mhorsfall/perl5/perlbrew PERL_BADLANG (unset) SHELL=/bin/bash

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 943b
On Thu Jan 30 19:40:56 2014, alh wrote: Show quoted text
> Added back in test.deparse test target. > > It now runs all tests with t/TEST, and supports: > > * Skipping known bad tests entirely without running them > * Running tests that are expected to fail, and "skipping" them if they > do > Or, if they pass, throwing an error to let us know the test now > works > > This should allow us to smoke it and make sure things don't get any > worse, > while allowing us to fix things as we have time.
I'd like to see a response from Nicholas on whether this goes back in or not. His argument still holds though - without the added makefile targets you can still run a deparse test with: TEST_ARGS=-deparse make test As to the patch itself, I'd prefer that the known issues list go into a separate file, as they do with t/porting/podcheck.t. This could simplify a future implementation of regenerating that list, just as porting/podcheck.t allows. Tony
From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
To: perlbug-followup [...] perl.org
Date: Wed, 19 Feb 2014 08:09:13 -0500
CC: Perl5 Porters <perl5-porters [...] perl.org>
Subject: Re: [perl #121126] [PATCH] Bring back test.deparse for smoking
Download (untitled) / with headers
text/plain 1.4k
On Sun, Feb 2, 2014 at 5:44 PM, Tony Cook via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Thu Jan 30 19:40:56 2014, alh wrote:
>> Added back in test.deparse test target. >> >> It now runs all tests with t/TEST, and supports: >> >> * Skipping known bad tests entirely without running them >> * Running tests that are expected to fail, and "skipping" them if they >> do >> Or, if they pass, throwing an error to let us know the test now >> works >> >> This should allow us to smoke it and make sure things don't get any >> worse, >> while allowing us to fix things as we have time.
> > I'd like to see a response from Nicholas on whether this goes back in or not. > > His argument still holds though - without the added makefile targets you can still run a deparse test with: > > TEST_ARGS=-deparse make test > > As to the patch itself, I'd prefer that the known issues list go into a separate file, as they do with t/porting/podcheck.t.
Agreed. I'm wondering how to implement this though. I think the test should normally be skipped, and then there should be a makefile target (or just ability to run the single .t file is fine...), but the .t file needs to run t/TEST recursively. So something like: TEST_DEPARSE=1 ./TEST /path/to/deparse.t And deparse.t needs to run ./TEST with the proper arguments to test everything, capture all output, and report on it? Also, this is one of my items for the Perl QA Hackathon if I have the time to get to it. -- Matthew Horsfall (alh)
Subject: Re: [perl #121126] [PATCH] Bring back test.deparse for smoking
CC: Perl5 Porters <perl5-porters [...] perl.org>
To: perlbug-followup [...] perl.org
Date: Thu, 13 Mar 2014 07:39:40 -0400
From: "Matthew Horsfall (alh)" <wolfsage [...] gmail.com>
Download (untitled) / with headers
text/plain 247b
Alright, here's a new attempt which breaks out the skips into Porting/deparse-skips.txt I'm not attached to that location, so if we'd prefer it under t/deparse-skips.txt (or t/deparse-skips.data) I'd be fine with that. -- Matthew Horsfall (alh)

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 360b
On Thu Mar 13 04:40:29 2014, alh wrote: Show quoted text
> Alright, here's a new attempt which breaks out the skips into > Porting/deparse-skips.txt > > I'm not attached to that location, so if we'd prefer it under > t/deparse-skips.txt (or t/deparse-skips.data) I'd be fine with that.
Applied as 2722144, without the Makefile support. Resolving. -- Matthew Horsfall (alh)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org