Skip Menu |
Report information
Id: 120976
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: rjbs <rjbs [at] cpan.org>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



Date: Sun, 12 Jan 2014 19:48:26 -0500
To: perlbug [...] perl.org
Subject: [META] tickets blocking the release of perl 5.18.3
From: Ricardo Signes <rjbs [...] cpan.org>
This meta-ticket will be used to collect tickets blocking the release of perl 5.18.3. -- rjbs
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 164b
I'm marking this as stalled, as it's fixed in blead and all that remains is for it to be be backported into the next (if any) 5.18 maint release -- Karl Williamson
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 266b
On Mon May 19 12:05:15 2014, khw wrote: Show quoted text
> I'm marking this as stalled, as it's fixed in blead and all that > remains is for it to be be backported into the next (if any) 5.18 > maint release
Oops. I stalled the wrong ticket, reopening this one -- Karl Williamson
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 533b
I just tried maint-5.18 and I still got the rm -f ../../lib/auto/Compress/Raw/Zlib/Zlib.so cc -shared -g3 -L/usr/local/lib -fstack-protector Zlib.o adler32.o crc32.o infback.o inflate.o uncompr.o compress.o deflate.o inffast.o inftrees.o trees.o zutil.o -o ../../lib/auto/Compress/Raw/Zlib/Zlib.so \ \ /usr/bin/ld: final link failed: Memory exhausted Problem fixed with a69492f5afa4bfb964605fd3f43c40392775c759 Update Compress-Raw-Zlib to CPAN version 2.065 [cpan #88936] This needs to be a blocker -- Reini Urban
RT-Send-CC: perl5-porters [...] perl.org
On Thu Jun 12 11:38:16 2014, rurban wrote: Show quoted text
> This needs to be a blocker
Looks like this is probably a sufficient fix? index 2b7c261..015c1d9 100644 --- a/maint-5.18:cpan/Compress-Raw-Zlib/Makefile.PL +++ b/blead:cpan/Compress-Raw-Zlib/Makefile.PL @@ -6,6 +6,7 @@ require 5.006 ; use private::MakeUtil; use ExtUtils::MakeMaker 5.16 ; use ExtUtils::Install (); # only needed to check for version +use Config; my $ZLIB_LIB ; my $ZLIB_INCLUDE ; @@ -14,6 +15,10 @@ my $OLD_ZLIB = '' ; my $WALL = '' ; my $GZIP_OS_CODE = -1 ; my $USE_PPPORT_H = ($ENV{PERL_CORE}) ? '' : '-DUSE_PPPORT_H'; +my $OPTIMIZE = $Config{'optimize'}; +if ($Config{'gccversion'} and $OPTIMIZE =~ /-g (gdb)? 3/x) { + $OPTIMIZE =~ s/-g(gdb)?3/-g/g; # [88936] out of memory with -g3 since 2.062 +} #$WALL = ' -pedantic ' if $Config{'cc'} =~ /gcc/ ; #$WALL = ' -Wall -Wno-comment ' if $Config{'cc'} =~ /gcc/ ; @@ -81,7 +86,8 @@ WriteMakefile( ? zlib_files($ZLIB_LIB) : (LIBS => [ "-L$ZLIB_LIB -lz " ]) ), - + OPTIMIZE => $OPTIMIZE, + -- -- rjbs
RT-Send-CC: perl5-porters [...] perl.org
Added cherry-picked and conflicted-fixed -p0 patch
Subject: 0001-Update-Compress-Raw-Zlib-to-CPAN-version-2.065.patch
From c747eae2dc2d13264910dd00f4901ff5e98315db Mon Sep 17 00:00:00 2001 From: Chris 'BinGOs' Williams <chris@bingosnet.co.uk> Date: Mon, 3 Feb 2014 20:35:24 +0000 Subject: [PATCH] Update Compress-Raw-Zlib to CPAN version 2.065 [DELTA] 2.065 3 February 2014 * [PATCH] resolve c++ build failure in core [#92657] * gcc -g3: final link failed: Memory exhausted [#88936] Fixed Conflicts: Porting/Maintainers.pl cpan/Compress-Raw-Zlib/Makefile.PL cpan/Compress-Raw-Zlib/Zlib.xs cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm t/porting/customized.dat Signed-off-by: Reini Urban <rurban@x-ray.at> --- Porting/Maintainers.pl | 3 +-- cpan/Compress-Raw-Zlib/Makefile.PL | 4 ++++ cpan/Compress-Raw-Zlib/Zlib.xs | 2 ++ cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm | 2 +- t/porting/customized.dat | 5 +++++ 5 files changed, 13 insertions(+), 3 deletions(-) diff --git Porting/Maintainers.pl Porting/Maintainers.pl index 32ff346..95956dd 100755 --- Porting/Maintainers.pl +++ Porting/Maintainers.pl @@ -377,8 +377,7 @@ use File::Glob qw(:case); 'Compress::Raw::Zlib' => { 'MAINTAINER' => 'pmqs', - 'DISTRIBUTION' => 'PMQS/Compress-Raw-Zlib-2.060.tar.gz', - + 'DISTRIBUTION' => 'PMQS/Compress-Raw-Zlib-2.065.tar.gz', 'FILES' => q[cpan/Compress-Raw-Zlib], 'EXCLUDED' => [ qr{^t/Test/}, diff --git cpan/Compress-Raw-Zlib/Makefile.PL cpan/Compress-Raw-Zlib/Makefile.PL index 2b7c261..77aba80 100644 --- cpan/Compress-Raw-Zlib/Makefile.PL +++ cpan/Compress-Raw-Zlib/Makefile.PL @@ -14,6 +14,10 @@ my $OLD_ZLIB = '' ; my $WALL = '' ; my $GZIP_OS_CODE = -1 ; my $USE_PPPORT_H = ($ENV{PERL_CORE}) ? '' : '-DUSE_PPPORT_H'; +my $OPTIMIZE = $Config{'optimize'}; +if ($Config{'gccversion'} and $OPTIMIZE =~ /-g (gdb)? 3/x) { + $OPTIMIZE =~ s/-g(gdb)?3/-g/g; # [88936] out of memory with -g3 since 2.062 +} #$WALL = ' -pedantic ' if $Config{'cc'} =~ /gcc/ ; #$WALL = ' -Wall -Wno-comment ' if $Config{'cc'} =~ /gcc/ ; diff --git cpan/Compress-Raw-Zlib/Zlib.xs cpan/Compress-Raw-Zlib/Zlib.xs index 1812230..2940ea4 100644 --- cpan/Compress-Raw-Zlib/Zlib.xs +++ cpan/Compress-Raw-Zlib/Zlib.xs @@ -1441,6 +1441,8 @@ Perl_sv_dump(output); */ if (RETVAL == Z_NEED_DICT && s->dictionary) { + STRLEN dlen; + const Bytef* b = (const Bytef*)SvPV(s->dictionary, dlen) ; s->dict_adler = s->stream.adler ; RETVAL = inflateSetDictionary(&(s->stream), (const Bytef*)SvPVX(s->dictionary), diff --git cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm index acf599d..cbeff7a 100644 --- cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm +++ cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm @@ -11,7 +11,7 @@ use warnings ; use bytes ; our ($VERSION, $XS_VERSION, @ISA, @EXPORT, %EXPORT_TAGS, @EXPORT_OK, $AUTOLOAD, %DEFLATE_CONSTANTS, @DEFLATE_CONSTANTS ); -$VERSION = '2.060'; +$VERSION = '2.065'; $XS_VERSION = $VERSION; $VERSION = eval $VERSION; diff --git t/porting/customized.dat t/porting/customized.dat index bdb8eb2..9eada37 100644 --- t/porting/customized.dat +++ t/porting/customized.dat @@ -1,3 +1,8 @@ +Config::Perl::V cpan/Config-Perl-V/t/20_plv510.t 7263a40dcbaf1ee447f0209d3bbc029cc747c959 +Config::Perl::V cpan/Config-Perl-V/t/21_plv518.t ec23f4e34fb2f84f63f5588ad4a577530dbef5d2 +Digest::MD5 cpan/Digest-MD5/t/files.t bdbe05b705d9da305fedce7a9f4b6ba63250c7cf +Module::Build cpan/Module-Build/lib/Module/Build/ConfigData.pm c12eec359dba0cf6118f958fb98ddebdaa3787b9 +PerlIO::via::QuotedPrint cpan/PerlIO-via-QuotedPrint/t/QuotedPrint.t ca39f0146e89de02c746e199c45dcb3e5edad691 Text::Balanced cpan/Text-Balanced/t/01_compile.t 1598cf491a48fa546260a2ec41142abe84da533d Text::Balanced cpan/Text-Balanced/t/02_extbrk.t 6ba1b64a4604e822dc2260b8ffcea6b406339ee8 Text::Balanced cpan/Text-Balanced/t/03_extcbk.t 3307c980af28963414cab799c427b359ef3b8657 -- 2.0.0
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 179b
On Thu Jun 12 11:45:41 2014, rurban wrote: Show quoted text
> Added cherry-picked and conflicted-fixed -p0 patch
#2, still -p0 without touching t/porting/customized.dat attached -- Reini Urban
Subject: 0001-Update-Compress-Raw-Zlib-to-CPAN-version-2.065.patch
From 19c143ed6235ec5fe2dcb740df061fa5c5a690c8 Mon Sep 17 00:00:00 2001 From: Chris 'BinGOs' Williams <chris@bingosnet.co.uk> Date: Mon, 3 Feb 2014 20:35:24 +0000 Subject: [PATCH] Update Compress-Raw-Zlib to CPAN version 2.065 [DELTA] 2.065 3 February 2014 * [PATCH] resolve c++ build failure in core [#92657] * gcc -g3: final link failed: Memory exhausted [#88936] Fixed Conflicts: Porting/Maintainers.pl cpan/Compress-Raw-Zlib/Makefile.PL cpan/Compress-Raw-Zlib/Zlib.xs cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm t/porting/customized.dat Signed-off-by: Reini Urban <rurban@x-ray.at> --- Porting/Maintainers.pl | 3 +-- cpan/Compress-Raw-Zlib/Makefile.PL | 4 ++++ cpan/Compress-Raw-Zlib/Zlib.xs | 2 ++ cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git Porting/Maintainers.pl Porting/Maintainers.pl index 32ff346..95956dd 100755 --- Porting/Maintainers.pl +++ Porting/Maintainers.pl @@ -377,8 +377,7 @@ use File::Glob qw(:case); 'Compress::Raw::Zlib' => { 'MAINTAINER' => 'pmqs', - 'DISTRIBUTION' => 'PMQS/Compress-Raw-Zlib-2.060.tar.gz', - + 'DISTRIBUTION' => 'PMQS/Compress-Raw-Zlib-2.065.tar.gz', 'FILES' => q[cpan/Compress-Raw-Zlib], 'EXCLUDED' => [ qr{^t/Test/}, diff --git cpan/Compress-Raw-Zlib/Makefile.PL cpan/Compress-Raw-Zlib/Makefile.PL index 2b7c261..77aba80 100644 --- cpan/Compress-Raw-Zlib/Makefile.PL +++ cpan/Compress-Raw-Zlib/Makefile.PL @@ -14,6 +14,10 @@ my $OLD_ZLIB = '' ; my $WALL = '' ; my $GZIP_OS_CODE = -1 ; my $USE_PPPORT_H = ($ENV{PERL_CORE}) ? '' : '-DUSE_PPPORT_H'; +my $OPTIMIZE = $Config{'optimize'}; +if ($Config{'gccversion'} and $OPTIMIZE =~ /-g (gdb)? 3/x) { + $OPTIMIZE =~ s/-g(gdb)?3/-g/g; # [88936] out of memory with -g3 since 2.062 +} #$WALL = ' -pedantic ' if $Config{'cc'} =~ /gcc/ ; #$WALL = ' -Wall -Wno-comment ' if $Config{'cc'} =~ /gcc/ ; diff --git cpan/Compress-Raw-Zlib/Zlib.xs cpan/Compress-Raw-Zlib/Zlib.xs index 1812230..2940ea4 100644 --- cpan/Compress-Raw-Zlib/Zlib.xs +++ cpan/Compress-Raw-Zlib/Zlib.xs @@ -1441,6 +1441,8 @@ Perl_sv_dump(output); */ if (RETVAL == Z_NEED_DICT && s->dictionary) { + STRLEN dlen; + const Bytef* b = (const Bytef*)SvPV(s->dictionary, dlen) ; s->dict_adler = s->stream.adler ; RETVAL = inflateSetDictionary(&(s->stream), (const Bytef*)SvPVX(s->dictionary), diff --git cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm index acf599d..cbeff7a 100644 --- cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm +++ cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm @@ -11,7 +11,7 @@ use warnings ; use bytes ; our ($VERSION, $XS_VERSION, @ISA, @EXPORT, %EXPORT_TAGS, @EXPORT_OK, $AUTOLOAD, %DEFLATE_CONSTANTS, @DEFLATE_CONSTANTS ); -$VERSION = '2.060'; +$VERSION = '2.065'; $XS_VERSION = $VERSION; $VERSION = eval $VERSION; -- 2.0.0
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 299b
On Thu Jun 12 11:38:16 2014, rurban wrote: Show quoted text
> I just tried maint-5.18 and I still got the > ...
I applied the smaller fix which I proposed, rather than upgrading the whole dist by several versions, which is contrary to usual procedure. Please let me know if this has not solved the issue. -- rjbs
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 502b
On Sun Jan 12 16:48:37 2014, rjbs wrote: Show quoted text
> This meta-ticket will be used to collect tickets blocking the release > of perl > 5.18.3.
5.18.3 (and 5.18.4) are out. I believe the next release in this series would be 5.18.5. Shall we open a META ticket for blockers to 5.18.5? (One candidate: https://rt.perl.org/Ticket/Display.html?id=123344) If so, what should we do with the RTs that were attached to this ticket but were *not* resolved? Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 638b
On Tue Dec 02 05:25:46 2014, jkeenan wrote: Show quoted text
> On Sun Jan 12 16:48:37 2014, rjbs wrote:
> > This meta-ticket will be used to collect tickets blocking the release > > of perl > > 5.18.3.
> > 5.18.3 (and 5.18.4) are out. I believe the next release in this > series would be 5.18.5. > > Shall we open a META ticket for blockers to 5.18.5? (One candidate: > https://rt.perl.org/Ticket/Display.html?id=123344) > > If so, what should we do with the RTs that were attached to this > ticket but were *not* resolved? > > Thank you very much.
5.18 backport https://rt.perl.org/Ticket/Display.html?id=40565 -- bulk88 ~ bulk88 at hotmail.com
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 572b
On Tue Dec 02 05:25:46 2014, jkeenan wrote: Show quoted text
> On Sun Jan 12 16:48:37 2014, rjbs wrote:
> > This meta-ticket will be used to collect tickets blocking the release > > of perl > > 5.18.3.
> > 5.18.3 (and 5.18.4) are out. I believe the next release in this > series would be 5.18.5. > > Shall we open a META ticket for blockers to 5.18.5? (One candidate: > https://rt.perl.org/Ticket/Display.html?id=123344) > > If so, what should we do with the RTs that were attached to this > ticket but were *not* resolved?
Link them all to the new ticket. -- Father Chrysostomos
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 102b
Moving links for open issues to 123362. Marking this Resolved. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Trying again to resolve this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org