Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] e51c959 update perlhack.pod, remove reference to http://github.com/mirrors/perl, it no longer exists #13477

Closed
p5pRT opened this issue Dec 18, 2013 · 11 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented Dec 18, 2013

Migrated from rt.perl.org#120819 (status was 'resolved')

Searchable as RT120819$

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From mcgrath.martin@gmail.com

Inline Patch
diff --git a/pod/perlhack.pod b/pod/perlhack.pod
index a32199a..90ade92 100644
--- a/pod/perlhack.pod
+++ b/pod/perlhack.pod
@@ -174,8 +174,7 @@ clone via http, though this is much slower:
 You may access the repository over the web.  This allows you to browse
 the tree, see recent commits, subscribe to RSS feeds for the changes,
 search for particular commits and more.  You may access it at
-L<http://perl5.git.perl.org/perl.git>.  A mirror of the repository is
-found at L<http://github.com/mirrors/perl>.
+L<http://perl5.git.perl.org/perl.git>.

 =head2 Read access via rsync


--------------1.7.10.4--


Flags:   category=docs   severity=low

Site configuration information for perl 5.18.1​:

Configured by marto at Thu Nov 28 14​:28​:00 GMT 2013.

Summary of my perl5 (revision 5 version 18 subversion 1) configuration​:

  Platform​:
  osname=linux, osvers=3.2.0-4-686-pae, archname=i686-linux
  uname='linux debian 3.2.0-4-686-pae #1 smp debian 3.2.51-1 i686
gnulinux '
  config_args='-de -Dprefix=/home/marto/perl5/perlbrew/perls/perl-5.18.1'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=undef, use64bitall=undef, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
  ccversion='', gccversion='4.7.2', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
  alignbytes=4, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/i386-linux-gnu /lib/../lib
/usr/lib/i386-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib
-fstack-protector'

Locally applied patches​:


@​INC for perl 5.18.1​:

/home/marto/perl5/perlbrew/perls/perl-5.18.1/lib/site_perl/5.18.1/i686-linux
  /home/marto/perl5/perlbrew/perls/perl-5.18.1/lib/site_perl/5.18.1
  /home/marto/perl5/perlbrew/perls/perl-5.18.1/lib/5.18.1/i686-linux
  /home/marto/perl5/perlbrew/perls/perl-5.18.1/lib/5.18.1
  .


Environment for perl 5.18.1​:
  HOME=/home/marto
  LANG=en_GB.UTF-8
  LANGUAGE=en_GB​:en
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)

PATH=/home/marto/perl5/perlbrew/bin​:/home/marto/perl5/perlbrew/perls/perl-5.18.1/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/games​:/usr/games
  PERLBREW_MANPATH=/home/marto/perl5/perlbrew/perls/perl-5.18.1/man

PERLBREW_PATH=/home/marto/perl5/perlbrew/bin​:/home/marto/perl5/perlbrew/perls/perl-5.18.1/bin
  PERLBREW_PERL=perl-5.18.1
  PERLBREW_ROOT=/home/marto/perl5/perlbrew
  PERLBREW_SKIP_INIT=1
  PERLBREW_VERSION=0.43
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From mcgrath.martin@gmail.com

0001-update-perlhack.pod-remove-reference-to-http-github..patch
From e51c9592cd699316357b463e948739f25b6b02be Mon Sep 17 00:00:00 2001
From: marto <marto@debian>
Date: Wed, 18 Dec 2013 10:53:21 +0000
Subject: [PATCH] update perlhack.pod, remove reference to 
 http://github.com/mirrors/perl, it no longer exists
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.10.4"

This is a multi-part message in MIME format.
--------------1.7.10.4
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 pod/perlhack.pod |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


--------------1.7.10.4
Content-Type: text/x-patch; name="0001-update-perlhack.pod-remove-reference-to-http-github..patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-update-perlhack.pod-remove-reference-to-http-github..patch"

diff --git a/pod/perlhack.pod b/pod/perlhack.pod
index a32199a..90ade92 100644
--- a/pod/perlhack.pod
+++ b/pod/perlhack.pod
@@ -174,8 +174,7 @@ clone via http, though this is much slower:
 You may access the repository over the web.  This allows you to browse
 the tree, see recent commits, subscribe to RSS feeds for the changes,
 search for particular commits and more.  You may access it at
-L<http://perl5.git.perl.org/perl.git>.  A mirror of the repository is
-found at L<http://github.com/mirrors/perl>.
+L<http://perl5.git.perl.org/perl.git>.
 
 =head2 Read access via rsync
 

--------------1.7.10.4--


@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From @wolfsage

On Wed Dec 18 03​:14​:57 2013, mcgrath.martin@​gmail.com wrote​:

diff --git a/pod/perlhack.pod b/pod/perlhack.pod
index a32199a..90ade92 100644
--- a/pod/perlhack.pod
+++ b/pod/perlhack.pod
@​@​ -174,8 +174,7 @​@​ clone via http, though this is much slower​:
You may access the repository over the web. This allows you to
browse
the tree, see recent commits, subscribe to RSS feeds for the changes,
search for particular commits and more. You may access it at
-L<http​://perl5.git.perl.org/perl.git>. A mirror of the repository is
-found at L<http​://github.com/mirrors/perl>.
+L<http​://perl5.git.perl.org/perl.git>.

It's now at https://github.com/Perl/perl5.

Should we list that and hope it doesn't change again?

-- Matthew Horsfall (alh)

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From @Hugmeir

Nice catch on the url! Hiwever, the patch should not be applied -- the
repository does exist, but was moved to https://github.com/Perl/perl5
I can't make a commit from my current location, but once someone fixes it
this ticket can be closed.

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From mcgrath.martin@gmail.com

On 18 December 2013 14​:21, Matthew Horsfall via RT <perlbug-followup@​perl
.org> wrote​:

It's now at https://github.com/Perl/perl5.

Should we list that and hope it doesn't change again?

-- Matthew Horsfall (alh)

Matthew,

thanks for this, shall I just fix this on github (via the URL you provided)
and issue a pull request, or edit this existing ticket?

Thanks for your help

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From @wolfsage

On Wed, Dec 18, 2013 at 9​:24 AM, Martin McGrath
<mcgrath.martin@​gmail.com> wrote​:

On 18 December 2013 14​:21, Matthew Horsfall via RT
<perlbug-followup@​perl.org> wrote​:

It's now at https://github.com/Perl/perl5.

Should we list that and hope it doesn't change again?

-- Matthew Horsfall (alh)

Matthew,

thanks for this, shall I just fix this on github (via the URL you provided)
and issue a pull request, or edit this existing ticket?

Thanks for your help

Please edit the existing ticket and apply a new patch if you would be so kind.

I believe we don't want Github pull requests in general.

Thanks,

-- Matthew Horsfall (alh)

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From mcgrath.martin@gmail.com

New patch to update the mirror to the correct URL.

On 18 December 2013 14​:21, Matthew Horsfall via RT <
perlbug-followup@​perl.org> wrote​:

On Wed Dec 18 03​:14​:57 2013, mcgrath.martin@​gmail.com wrote​:

diff --git a/pod/perlhack.pod b/pod/perlhack.pod
index a32199a..90ade92 100644
--- a/pod/perlhack.pod
+++ b/pod/perlhack.pod
@​@​ -174,8 +174,7 @​@​ clone via http, though this is much slower​:
You may access the repository over the web. This allows you to
browse
the tree, see recent commits, subscribe to RSS feeds for the changes,
search for particular commits and more. You may access it at
-L<http​://perl5.git.perl.org/perl.git>. A mirror of the repository is
-found at L<http​://github.com/mirrors/perl>.
+L<http​://perl5.git.perl.org/perl.git>.

It's now at https://github.com/Perl/perl5.

Should we list that and hope it doesn't change again?

-- Matthew Horsfall (alh)

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From mcgrath.martin@gmail.com

perlhack.pod-update-link-to-mirror.patch
--- perlhack.pod.orig	2013-12-18 14:45:37.000000000 +0000
+++ perlhack.pod	2013-12-18 14:46:15.000000000 +0000
@@ -175,7 +175,7 @@
 the tree, see recent commits, subscribe to RSS feeds for the changes,
 search for particular commits and more.  You may access it at
 L<http://perl5.git.perl.org/perl.git>.  A mirror of the repository is
-found at L<http://github.com/mirrors/perl>.
+found at L<https://github.com/Perl/perl5>.
 
 =head2 Read access via rsync
 

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

From @jkeenan

Applied to blead in commit b095961

Thanks for the patch. Marking ticket resolved.

Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Dec 18, 2013

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Dec 18, 2013
@p5pRT p5pRT added the hasPatch label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant