Skip Menu |
Report information
Id: 118215
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: rjbs <rjbs [at] cpan.org>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type:
Perl Version: (no value)
Fixed In: (no value)



Subject: make Module:CoreList's %deprecated a delta hash
Date: Tue, 28 May 2013 11:02:25 -0400
To: perlbug [...] perl.org
From: Ricardo Signes <rjbs [...] cpan.org>
Download (untitled) / with headers
text/plain 911b
%Module::CoreList::deprecated is a map from versions to modules "deprecated" in that version of perl. Every perl version has a full list, meaning we get entries like this: 5.011001 => { 'Class::ISA' => '1', 'Pod::Plainer' => '1', 'Shell' => '1', 'Switch' => '1', }, 5.011002 => { 'Class::ISA' => '1', 'Pod::Plainer' => '1', 'Shell' => '1', 'Switch' => '1', }, For later versions with more deprecations, this gets pretty big. More importantly, it needs to be updated versionly. Each perl version should instead be a delta so we only need to add additions or removals when they occur. We already have code for this, used by Module::Corelist: Module::CoreList::TieHashDelta Module::CoreList::deprecated should be set up with a delta hash. -- rjbs
Download signature.asc
application/pgp-signature 490b

Message body not shown because it is not plain text.

CC: Mike Doherty <mike [...] mikedoherty.ca>
Subject: [PATCH] [perl #118215] Make %Module::CoreList::deprecated a delta hash
Date: Wed, 29 May 2013 00:09:56 -0300
To: perlbug [...] perl.org
From: Mike Doherty <mike [...] mikedoherty.ca>
Download (untitled) / with headers
text/plain 455b
This hash tracks core module deprecations, which becomes very verbose if listing out the deprecated modules for every perl version. Instead, we can track the delta for each release, using Module::CoreList::TieHashDelta to inflate as needed. Fixes #118215: https://rt.perl.org/rt3//Public/Bug/Display.html?id=118215 --- dist/Module-CoreList/lib/Module/CoreList.pm | 604 +++++++--------------------- 1 file changed, 141 insertions(+), 463 deletions(-)

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 659b
On Tue May 28 20:10:34 2013, mike@mikedoherty.ca wrote: Show quoted text
>[a patch!]
Thanks, Mike! We discussed this on IRC, and for the record: it seems like this will never reset the contents as it should. For example, 5.013001 should have one entry, but this code makes it look like it will have quite a few more, including everything from 5.012005 as well. When I tried to test this, things got a bit odd: IN BLEAD: DB<11> x $Module::CoreList::deprecated{'5.013001'} 0 HASH(0x7fa5dd042c18) 'Shell' => 1 WITH THE PATCH: DB<5> x $Module::CoreList::deprecated{'5.013001'} 0 HASH(0x7fc043f9ec48) empty hash Mike said he'd investigate. -- rjbs
CC: Mike Doherty <mike [...] mikedoherty.ca>
Subject: [PATCH] [perl #118215] Make %Module::CoreList::deprecated a delta hash
Date: Mon, 10 Jun 2013 21:04:31 -0300
To: perlbug [...] perl.org
From: Mike Doherty <mike [...] mikedoherty.ca>

Message body is not shown because it is too large.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 367b
Thanks, applied as 5ff416f I applies some more work on top of that to bring in an omission that had been fixed between your patch and later blead. I also updated Porting/corelist.pl so that updating the corelist file will create new delta-style entries instead of bulk updates. Testing this by hand worked okay. Welcome to the perl AUTHORS file, Mike! -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org