New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t/op/reverse.t: add description to test #12583
Comments
From bobernststl@gmail.comCreated at the St. Louis Perl Monger Hackathon, please review. |
From bobernststl@gmail.com0002-Added-descriptions-to-tests-in-reverse.t.patchFrom d489c8780ffa5e7a558c4af5663106331ba38011 Mon Sep 17 00:00:00 2001
From: Bob Ernst <bobernst@cpan.org>
Date: Sat, 17 Nov 2012 21:18:20 +0000
Subject: [PATCH 2/2] Added descriptions to tests in reverse.t
---
t/op/reverse.t | 52 ++++++++++++++++++++++++++--------------------------
1 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/t/op/reverse.t b/t/op/reverse.t
index 916724c..bbc9336 100644
--- a/t/op/reverse.t
+++ b/t/op/reverse.t
@@ -8,46 +8,46 @@ BEGIN {
plan tests => 26;
-is(reverse("abc"), "cba");
+is(reverse("abc"), "cba", 'simple reverse');
$_ = "foobar";
-is(reverse(), "raboof");
+is(reverse(), "raboof", 'reverse of the default variable');
{
my @a = ("foo", "bar");
my @b = reverse @a;
- is($b[0], $a[1]);
- is($b[1], $a[0]);
+ is($b[0], $a[1], 'array reversal moved second element to first');
+ is($b[1], $a[0], 'array reversal moved first element to second');
}
{
my @a = (1, 2, 3, 4);
@a = reverse @a;
- is("@a", "4 3 2 1");
+ is("@a", "4 3 2 1", 'four element array reversed');
delete $a[1];
@a = reverse @a;
- ok(!exists $a[2]);
- is($a[0] . $a[1] . $a[3], '124');
+ ok(!exists $a[2], 'array reversed with deleted second element');
+ is($a[0] . $a[1] . $a[3], '124', 'remaining elements ok after delete and reverse');
@a = (5, 6, 7, 8, 9);
@a = reverse @a;
- is("@a", "9 8 7 6 5");
+ is("@a", "9 8 7 6 5", 'five element array reversed');
delete $a[3];
@a = reverse @a;
- ok(!exists $a[1]);
- is($a[0] . $a[2] . $a[3] . $a[4], '5789');
+ ok(!exists $a[1], 'five element array reversed with deleted fourth element');
+ is($a[0] . $a[2] . $a[3] . $a[4], '5789', 'remaining elements ok after delete and reverse');
delete $a[2];
@a = reverse @a;
- ok(!exists $a[2] && !exists $a[3]);
- is($a[0] . $a[1] . $a[4], '985');
+ ok(!exists $a[2] && !exists $a[3], 'test position of two deleted elements after reversal');
+ is($a[0] . $a[1] . $a[4], '985', 'check value of remaining elements');
my @empty;
@empty = reverse @empty;
- is("@empty", "");
+ is("@empty", "", 'reversed empty array is still empty');
}
use Tie::Array;
@@ -57,30 +57,30 @@ use Tie::Array;
@a = (1, 2, 3, 4);
@a = reverse @a;
- is("@a", "4 3 2 1");
+ is("@a", "4 3 2 1", 'tie array reversal');
delete $a[1];
@a = reverse @a;
- ok(!exists $a[2]);
- is($a[0] . $a[1] . $a[3], '124');
+ ok(!exists $a[2], 'deleted element position ok after reversal of tie array');
+ is($a[0] . $a[1] . $a[3], '124', 'remaining elements ok after delete and reversal for tie array');
@a = (5, 6, 7, 8, 9);
@a = reverse @a;
- is("@a", "9 8 7 6 5");
+ is("@a", "9 8 7 6 5", 'five element tie array reversal');
delete $a[3];
@a = reverse @a;
- ok(!exists $a[1]);
- is($a[0] . $a[2] . $a[3] . $a[4], '5789');
+ ok(!exists $a[1], 'deleted element position ok after tie array reversal');
+ is($a[0] . $a[2] . $a[3] . $a[4], '5789', 'remaining elements ok after tie array delete and reversal');
delete $a[2];
@a = reverse @a;
- ok(!exists $a[2] && !exists $a[3]);
- is($a[0] . $a[1] . $a[4], '985');
+ ok(!exists $a[2] && !exists $a[3], 'two deleted element positions ok after tie array reversal');
+ is($a[0] . $a[1] . $a[4], '985', 'remaining elements ok after two deletes and reversals');
tie my @empty, "Tie::StdArray";
@empty = reverse @empty;
- is(scalar(@empty), 0);
+ is(scalar(@empty), 0, 'reversed tie array still empty after reversal');
}
{
@@ -89,17 +89,17 @@ use Tie::Array;
my $a = "\x{263A}\x{263A}x\x{263A}y\x{263A}";
my $b = scalar reverse($a);
my $c = scalar reverse($b);
- is($a, $c);
+ is($a, $c, 'Unicode string double reversal matches original');
}
{
# Lexical $_.
sub blurp { my $_ = shift; reverse }
- is(blurp("foo"), "oof");
- is(sub { my $_ = shift; reverse }->("bar"), "rab");
+ is(blurp("foo"), "oof", 'reversal of default variable in function');
+ is(sub { my $_ = shift; reverse }->("bar"), "rab", 'reversal of default variable in anonymous function');
{
local $_ = "XXX";
- is(blurp("paz"), "zap");
+ is(blurp("paz"), "zap", 'reversal of default variable with local value set' );
}
}
--
1.7.2.5
|
From @jkeenanOn Sat Nov 17 13:23:13 2012, bobernststl@gmail.com wrote:
I have reviewed this patch and believe it should be applied. I have Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From [Unknown Contact. See original ticket]Patch committed to blead in commit af1b607 Closing ticket. Thank you very much. Jim Keenan |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#115790 (status was 'resolved')
Searchable as RT115790$
The text was updated successfully, but these errors were encountered: