Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diamond role inheritance is broken in Rakudo #707

Closed
p6rt opened this issue Feb 19, 2009 · 5 comments
Closed

Diamond role inheritance is broken in Rakudo #707

p6rt opened this issue Feb 19, 2009 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Feb 19, 2009

Migrated from rt.perl.org#63330 (status was 'resolved')

Searchable as RT63330$

@p6rt
Copy link
Author

p6rt commented Feb 19, 2009

From @masak

<masak> I know. let's do diamonds!
<masak> rakudo​: role A { method foo { say "OH HAI" } }; role B does A
{}; role C does A {}; class D does B does A {}; D.new.foo
<p6eval> rakudo 543e22​: OUTPUT«A conflict occurred during role
composition due to method 'foo'. [...]
<masak> this should work, shouldn't it?
<masak> a method shouldn't conflict with itself.
<jnthn> That's a bug.
* masak bugmits rakudosub

@p6rt
Copy link
Author

p6rt commented Feb 19, 2009

From @moritz

On Thu Feb 19 02​:39​:47 2009, masak wrote​:

<masak> I know. let's do diamonds!
<masak> rakudo​: role A { method foo { say "OH HAI" } }; role B does A
{}; role C does A {}; class D does B does A {}; D.new.foo
<p6eval> rakudo 543e22​: OUTPUT«A conflict occurred during role
composition due to method 'foo'. [...]
<masak> this should work, shouldn't it?
<masak> a method shouldn't conflict with itself.
<jnthn> That's a bug.
* masak bugmits rakudosub

Test added to t/spec/S12-role/composition.t

Cheers,
Moritz

@p6rt
Copy link
Author

p6rt commented Feb 19, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 8, 2009

From @jnthn

On Thu Feb 19 09​:45​:41 2009, moritz wrote​:

On Thu Feb 19 02​:39​:47 2009, masak wrote​:

<masak> I know. let's do diamonds!
...drug reference win? ;-)

<masak> rakudo​: role A { method foo { say "OH HAI" } }; role B does A
{}; role C does A {}; class D does B does A {}; D.new.foo
<p6eval> rakudo 543e22​: OUTPUT«A conflict occurred during role
composition due to method 'foo'. [...]
<masak> this should work, shouldn't it?
<masak> a method shouldn't conflict with itself.
<jnthn> That's a bug.
* masak bugmits rakudosub

I've fugbixed it now in git 14cd976.

Test added to t/spec/S12-role/composition.t

And unfudged this.

Thanks,

Jonathan

@p6rt
Copy link
Author

p6rt commented May 8, 2009

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed May 8, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant