New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undetectable, incompatible API changes in POPpx, etc. #8373
Comments
From jgmyers@proofpoint.comCreated by jgmyers@proofpoint.comPerl 5.8.8 contains an incompatible and undetectable change to the [ 25525] By: nicholas on 2005/09/21 09:32:33 Our code was calling POPpx then using the value assigned to n_a to It was highly irresponsible for someone to make an incompatible change Perl Info
|
From @nwc10Thanks for reporting this bug. On Thu, Mar 16, 2006 at 02:53:38PM -0800, John Gardiner Myers wrote:
The old documentation gives a return value of char *, and states Pops a string off the stack. The new documentation gives a return value of char *, and states Pops a string off the stack. No-one reading the public commit list realised that the changed behaviour Likewise no-one spotted it as a result of any of the maintenance snapshots in Of the 5000 modules on CPAN, 2 have code that is relying on n_a being set. Sorry for the trouble this has caused. Nicholas Clark |
The RT System itself - Status changed from 'new' to 'open' |
From jgmyers@proofpoint.comNicholas Clark via RT wrote:
|
From @gisleNicholas Clark <nick@ccl4.org> writes:
Anybody stupid enough to depend on an undocumented side effect that --Gisle |
From jgmyers@proofpoint.comGisle Aas via RT wrote:
n_a was documented. |
From @nwc10On Thu, Mar 16, 2006 at 03:31:26PM -0800, John Myers wrote:
According to cpansearch.bulknews.net, Net::ESMTP and MIME::Fast http://cpansearch.bulknews.net/search?q=POPpx&fm=all Nicholas Clark |
From @steve-m-hayJohn Gardiner Myers wrote:
I think the point was that the *setting of* n_a was not documented. The Radan Computational Ltd. The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email. |
From guest@guest.guest.xxxxxxxx
This is legalese and unfair. First of all, the docs in perlapi are extremely succint, and a lot of Documentation for POPp clearly stated that it was deprecated in favour I worked it around using the following setup: STRLEN n_a; But now that we're under use strict 'legalese'; I'd like to point out the documentation for SvPV/SvPVx: SvPV Returns a pointer to the string in the SV, or a stringified char* SvPV(SV* sv, STRLEN len) SvPVx A version of "SvPV" which guarantees to evaluate sv only once. char* SvPVx(SV* sv, STRLEN len) There is *nothing* that states that len will be assigned the length of Flavio Poletti (polettix [at] cpan.org) |
@iabyn - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#38744 (status was 'rejected')
Searchable as RT38744$
The text was updated successfully, but these errors were encountered: