New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in Script Run #16704
Comments
From ph10@hermes.cam.ac.ukCreated by ph10@cam.ac.ukI was running some tests on the new (*script_run:...) regex feature, $ perl -e 'if ("\x{3041}12\x{3041}" =~ /^(*sr:.{4})/) { print "yes >$&<\n"; } else { print "no \n"; }' In this example, the two ASCII digits "12" are flanked by two Hiragana $ perl -e 'if ("\x{0980}12\x{0993}" =~ /^(*sr:.{4})/) { print "yes >$&<\n"; } else { print "no \n"; }' In this example, the two ASCII digits "12" are flanged by two Bengali Why the difference? I haven't exhaustively tested all possible scripts, and I Philip Perl Info
|
From @AbigailOn Thu, Sep 27, 2018 at 10:04:22AM -0700, Philip Hazel (via RT) wrote:
Can you check with blead? I reported this in August, and Karl fixed Regards, Abigail |
The RT System itself - Status changed from 'new' to 'open' |
From ph10@hermes.cam.ac.ukOn Thu, 27 Sep 2018, Abigail via RT wrote:
Not without some research and learning how to do that. :-) But if I get
I'm pleased to learn that it *is* a bug, and not some misunderstanding Regards, -- |
From @khwilliamsonThis is fixed by commit 393e5a4 PATCH: [perl #133547]: script run broken -- |
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonOn 09/28/2018 01:33 AM, ph10@hermes.cam.ac.uk wrote:
The fix for this should be put in 5.28.1. perlre has been updated since 5.28.0 to make clearer the acceptable https://perl5.git.perl.org/perl.git/commitdiff/4a1d964056983f26f5646fdb7aadb4b5e7b5235f |
From ph10@hermes.cam.ac.ukOn Sun, 30 Sep 2018, Karl Williamson wrote:
Many thanks, Karl. That confirms what I had (finally :-) deduced myself, Regards, -- |
From ph10@hermes.cam.ac.ukOn Sun, 30 Sep 2018, Karl Williamson wrote:
I have downloaded v5.29.4 (v5.29.3-35-g4288c5b93b) and can confirm that These strings match the pattern /^(*sr:.{4})/ \x{ff10}\x{ff19}.. A\x{ff10}\x{ff19}B Regards, -- |
From @khwilliamsonOn 10/02/2018 03:57 AM, ph10@hermes.cam.ac.uk wrote:
Technically, this isn't a bug, but a design flaw. My design was to allow only ASCII 0-9 to be allowed with other scripts. But that is not what a reasonable person would expect, and so the design I see two choices: 1) Allow the non-ASCII digits that are considered Common to match the 2) Allow these to match any script, just like the ASCII ones already do. The second solution seems more in keeping with Unicode's intent, since I'm open to hearing arguments either way, or some third way. |
From ph10@hermes.cam.ac.ukOn Sun, 30 Sep 2018, Karl Williamson wrote:
Sorry to nag you again, but have I got the following right? Perl allows Regards, -- |
From ph10@hermes.cam.ac.ukOn Tue, 2 Oct 2018, Karl Williamson wrote:
Nice distinction! :-)
That is what I expected, and what I have tentatively implemented.
Yes, indeed. Regards, -- |
From @khwilliamsonOn 10/02/2018 09:12 AM, ph10@hermes.cam.ac.uk wrote:
1cf7 is not a Common character in the Script Extensions property, and so |
From ph10@hermes.cam.ac.ukOn Tue, 2 Oct 2018, Karl Williamson wrote:
I must be misunderstanding something. I do not see the word "common" Regards, -- |
From @khwilliamsonOn 10/02/2018 10:10 AM, ph10@hermes.cam.ac.uk wrote:
The top of ScriptExtensions.txt says: # All code points not explicitly listed for Script_Extensions The way mktables creates scx is to create a copy of sc, and then |
From @steve-m-hayOn Sun, 30 Sep 2018 09:51:12 -0700, khw wrote:
Karl, is there any chance you could prepare a patch for applying to maint-5.28? It doesn't cherry-pick cleanly and I think you're probably better placed than me to resolve the conflicts. |
From @khwilliamsonI have now applied: Any Common digit set can match in any script |
From @khwilliamsonOn 1/9/19 11:16 AM, Steve Hay via RT wrote:
I didn't do this because of the design flaw in 5.30 this ticket showed.
|
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133547 (status was 'resolved')
Searchable as RT133547$
The text was updated successfully, but these errors were encountered: