New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devel::PPPort migration to dist/ is incomplete #16438
Comments
From @dur-randirCreated by @dur-randirSince the commit [1], Devel::PPPort resides under dist/ which, - CPAN still points to github [2] for both module's sources and bug tracker What are the next steps to be taken? Who should take them? [1] commit 7baf245 mv Devel-PPPort from cpan to dist It was decided at the perl core hackathon in October 2017 to go ahead [2] https://github.com/mhx/Devel-PPPort/ Perl Info
|
From @xsawyerxOn Sat, 24 Feb 2018 10:48:58 -0800, randir wrote:
We need to determine what level of backwards compatibility Devel::PPPort provides. At the moment this i 5.3.x, which is hard to maintain (and provides little value consider toolchain doesn't support back to it). Then we need to transfer ownership (or at least comaint) to P5P so we could make releases. Then we would like to make sure we know how to test it and release it. The testing phase requires building the Perl versions and testing the code on all of them. We are waiting for mhx for the first item. We had little luck in reaching him so far. |
The RT System itself - Status changed from 'new' to 'open' |
From @TuxOn Mon, 26 Feb 2018 03:10:06 -0800, "Sawyer X via RT"
If Devel::PPPort raises its own major version number when minimum @Peter, does that sound feasible, or do you still use 5.005 with
-- |
From @ribasushiOn 02/26/2018 12:24 PM, H.Merijn Brand wrote:
Yes, minimum of 5.6.1 ( note: .1 not .2 ) is reasonable. |
From @TuxOn Tue, 27 Feb 2018 12:24:19 +0100, Peter Rabbitson
Makes sense, even though a *new* build is most likely to FAIL on 5.6.1 So my 👍/ +1 for dropping all support for perl < 5.6.1 in Devel::PPPort -- |
From @xsawyerxOn 02/27/2018 01:44 PM, H.Merijn Brand wrote:
In a conversation with the previous maintainer of Devel::PPPort, |
From @xsawyerxOn 02/28/2018 01:33 PM, Sawyer X wrote:
No, I was wrong. I found emails in which I explicitly said "< 5.6". |
From @xsawyerxOn 02/26/2018 01:10 PM, Sawyer X via RT wrote:
I have spoken to mhx. He has added P5P as a PAUSE as firstcome, so we |
From @dur-randirI've attached a patch to this message that changes RT and other urls for Devel::PPPort to point to perl's own ones. |
From @dur-randir0001-Update-RT-path-for-Devel-PPPort.patchFrom 4a38f8e7a6a2cc488a8c9bcb99c3a4ad1e556a66 Mon Sep 17 00:00:00 2001
From: Sergey Aleynikov <sergey.aleynikov@gmail.com>
Date: Mon, 26 Mar 2018 02:05:47 +0300
Subject: [PATCH] Update RT path for Devel::PPPort
---
dist/Devel-PPPort/Makefile.PL | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/dist/Devel-PPPort/Makefile.PL b/dist/Devel-PPPort/Makefile.PL
index 25e352e641..b67800dfa2 100644
--- a/dist/Devel-PPPort/Makefile.PL
+++ b/dist/Devel-PPPort/Makefile.PL
@@ -39,14 +39,9 @@ WriteMakefile(
version => 2,
},
resources => {
- bugtracker => {
- web => 'https://github.com/mhx/Devel-PPPort/issues/',
- },
- repository => {
- type => 'git',
- url => 'git://github.com/mhx/Devel-PPPort.git',
- web => 'https://github.com/mhx/Devel-PPPort/',
- },
+ repository => 'git://perl5.git.perl.org/perl.git',
+ bugtracker => 'https://rt.perl.org/rt3/',
+ homepage => "http://dev.perl.org/",
},
},
);
--
2.14.2
|
From @GrinnzOn Sun, Mar 25, 2018 at 7:06 PM, Sergey Aleynikov via RT <
|
From @dur-randirOn Sun, 25 Mar 2018 18:36:06 -0700, grinnz@gmail.com wrote:
Here's an updated patch series that also includes updates in other places in the docs mentioning github. |
From @dur-randir0002-Update-links-in-Devel-PPPort-documentation.patchFrom b706d31c69be5b0bd1744acdd78f7be5d59c8c0a Mon Sep 17 00:00:00 2001
From: Sergey Aleynikov <sergey.aleynikov@gmail.com>
Date: Mon, 26 Mar 2018 23:39:45 +0300
Subject: [PATCH 2/2] Update links in Devel::PPPort documentation
So they no longer point to github, as it's now maintained in-core.
---
dist/Devel-PPPort/HACKERS | 5 ++---
dist/Devel-PPPort/PPPort_pm.PL | 3 +--
dist/Devel-PPPort/parts/inc/ppphdoc | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/dist/Devel-PPPort/HACKERS b/dist/Devel-PPPort/HACKERS
index 4f354043aa..2e035dfc7e 100644
--- a/dist/Devel-PPPort/HACKERS
+++ b/dist/Devel-PPPort/HACKERS
@@ -287,9 +287,8 @@ That's it.
=head2 Submitting Patches
If you've added some functionality to C<Devel::PPPort>, please
-consider submitting a patch with your work to GitHub here:
-L<https://github.com/mhx/Devel-PPPort/issues/>, or by sending a
-Pull Request.
+consider submitting a patch with your work to P5P by sending a mail
+to L<perlbug@perl.org>.
When submitting patches, please only add the relevant changes
and don't include the differences of the generated files. You
diff --git a/dist/Devel-PPPort/PPPort_pm.PL b/dist/Devel-PPPort/PPPort_pm.PL
index 15cfe63405..78d35e58af 100644
--- a/dist/Devel-PPPort/PPPort_pm.PL
+++ b/dist/Devel-PPPort/PPPort_pm.PL
@@ -492,8 +492,7 @@ __UNSUPPORTED_API__
=head1 BUGS
If you find any bugs, C<Devel::PPPort> doesn't seem to build on your
-system, or any of its tests fail, please file an issue here:
-L<https://github.com/mhx/Devel-PPPort/issues/>
+system, or any of its tests fail, please send a bug report to L<perlbug@perl.org>.
=head1 AUTHORS
diff --git a/dist/Devel-PPPort/parts/inc/ppphdoc b/dist/Devel-PPPort/parts/inc/ppphdoc
index 2b4d857470..6382ab1ad4 100644
--- a/dist/Devel-PPPort/parts/inc/ppphdoc
+++ b/dist/Devel-PPPort/parts/inc/ppphdoc
@@ -297,7 +297,7 @@ before sending a bug report.
If F<ppport.h> was generated using the latest version of
C<Devel::PPPort> and is causing failure of this module, please
-file a bug report here: L<https://github.com/mhx/Devel-PPPort/issues/>
+send a bug report to L<perlbug@perl.org>.
Please include the following information:
--
2.14.2
|
From @dur-randirThe first patch in series seems to be missing, resending it. |
From @dur-randir0001-Update-RT-path-for-Devel-PPPort.patchFrom e995f577bb800e5336d1fc13bbae9256bd7ac49f Mon Sep 17 00:00:00 2001
From: Sergey Aleynikov <sergey.aleynikov@gmail.com>
Date: Mon, 26 Mar 2018 23:26:47 +0300
Subject: [PATCH 1/2] Update RT path for Devel::PPPort
---
dist/Devel-PPPort/Makefile.PL | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dist/Devel-PPPort/Makefile.PL b/dist/Devel-PPPort/Makefile.PL
index 25e352e641..117f9d107a 100644
--- a/dist/Devel-PPPort/Makefile.PL
+++ b/dist/Devel-PPPort/Makefile.PL
@@ -40,12 +40,12 @@ WriteMakefile(
},
resources => {
bugtracker => {
- web => 'https://github.com/mhx/Devel-PPPort/issues/',
+ web => 'https://rt.perl.org/rt3/',
},
repository => {
type => 'git',
- url => 'git://github.com/mhx/Devel-PPPort.git',
- web => 'https://github.com/mhx/Devel-PPPort/',
+ url => 'git://perl5.git.perl.org/perl.git',
+ web => 'https://perl5.git.perl.org/perl.git',
},
},
},
--
2.14.2
|
From @khwilliamsonOn 03/26/2018 02:48 PM, Sergey Aleynikov via RT wrote:
Thanks, applied as 5936215 |
From @dur-randirOn Tue, 27 Mar 2018 12:06:06 -0700, public@khwilliamson.com wrote:
Thanks, but there're still some links to github, which were updated by 0002-Update-links-in-Devel-PPPort-documentation.patch. Is it postponed until after the freeze ends? |
From @khwilliamsonOn 03/28/2018 03:02 PM, Sergey Aleynikov via RT wrote:
An oversight. The full freeze isn't until April 20th Thanks, pushed as c601e8c Anything else that needs to be done for this ticket?
|
From @dur-randirOn Wed, 28 Mar 2018 17:34:58 -0700, public@khwilliamson.com wrote:
Release a fresh D::P version to CPAN?) Other than that, I see nothing pending here. Github -> RT transition for tickets can be done separately. |
From @khwilliamsonOP says this is ok to close |
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132906 (status was 'resolved')
Searchable as RT132906$
The text was updated successfully, but these errors were encountered: