New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBC: recent commit breaks App::perlbrew #16268
Comments
From @jkeenanCPAN module App::perlbrew is broken in blead. The breakage, which ##### # Failed test 'compgen command, when there is a part of a subcommand # Failed test 'compgen command, when there is a part of a subcommand Test Summary Report t/09.exit_status.t (Wstat: 256 Tests: 3 Failed: 1) Summary of my perl5 (revision 5 version 27 subversion 7) configuration: Characteristics of this binary (from libperl): PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin" |
From @xsawyerxTaking a look at the code, I imagine it's the following check: if(defined *$glob{CODE}) {...} I'll contact Gugod. On 11/22/2017 03:40 AM, James E Keenan (via RT) wrote:
|
The RT System itself - Status changed from 'new' to 'open' |
From @iabynOn Tue, Nov 21, 2017 at 06:40:46PM -0800, James E Keenan wrote:
To save people looking, that's 177 commits in the range -- |
From @atoomicThanks, James & Dave, after a git bisect on my side it appears that it comes from commit d964025 ___ ... d964025 is the first bad commit Revert "Temporarily revert CV-in-stash optimisation" This reverts commit 6eed25e. :100644 100644 c61bfd08deb1ff7fc5f0795f180adebd635862c0 368f9b146e6284750fa9949a77a88d26e76c2a74 M op.c On Wed, 22 Nov 2017 03:34:24 -0800, davem wrote:
|
From @atoomicThe App::perlbrew code is expecting that any stash entry points to a GV, whereas now since 5.27.ish it can be a simple CV... I suspect that this might not be the only module expecting a GV for a stash entry... I've submitted upstream ( App::perlbrew repo a fix for it) I think we should close this ticket as this an upstream issue. thanks On Wed, 22 Nov 2017 08:10:24 -0800, atoomic@cpan.org wrote:
|
From @jkeenanOn Wed, 22 Nov 2017 17:00:24 GMT, atoomic@cpan.org wrote:
Nicolas, Dave M, thanks for that analysis. I'm reluctant to close this ticket at this time because I suspect that the number of CPAN distros that will have to modify their code to accommodate this change will be significant. I have confirmed that MOP is now failing against blead, as is QBit-WebInterface (though that is obscured by absence of an upstream C library). While I don't think that the amount of repair work to be done on CPAN will be as great as, say, that needed for no-dot-in-@INC in perl-5.26.0, that work will still be significant. I wonder whether the commit(s) which triggered these failures was absolutely necessary -- but I don't claim to understand those issues well enough. Thank you very much. -- |
From @cpansproutOn Wed, 22 Nov 2017 09:44:45 -0800, jkeenan wrote:
But we already have #132252 to cover this issue. Tracking it in two separate tickets is just going to be confusing. -- Father Chrysostomos |
From @iabynOn Wed, Nov 22, 2017 at 10:07:11AM -0800, Father Chrysostomos via RT wrote:
Closing. -- |
@iabyn - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132483 (status was 'resolved')
Searchable as RT132483$
The text was updated successfully, but these errors were encountered: