New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBC: Commit 7a831b72 breaks UNIVERAL::isa tests #16222
Comments
From @jkeenanAs first reported to me by Carlos Guevara: ##### No report available, since the install just hangs at: Here is the output from attempting to install UNIVERSAL-isa via 'cpanm' ##### [snip: all Requires, Recommends look fine] # === Other Modules === t/basic.t hangs going into test 41: ##### Here's what the next tests scheduled look like: ##### However, experimentation suggests that the indefinite hang will occur Separately, one TODO test in t/warnings.t may need modification: ##### This may be related to certain bug tickets in UNIVERSAL::isa's queue at Thank you very much. |
From @jkeenanSummary of my perl5 (revision 5 version 27 subversion 6) configuration: Characteristics of this binary (from libperl): |
From @iabynOn Sat, Nov 04, 2017 at 07:03:16AM -0700, James E Keenan wrote:
which is: commit 7a831b7 Speed up Carp.pm when backtrace arguments are references -- |
The RT System itself - Status changed from 'new' to 'open' |
From zefram@fysh.orgDave Mitchell wrote:
That commit should never have been applied, and should be reverted -zefram |
From @karenetheridge
What is this bit referring to? Is this patch intended to fix an issue that cPanel is having? |
From zefram@fysh.orgKaren Etheridge via RT wrote:
The original version of the patch came with a Changes entry, which In testing this decreased the Carp backtrace time by about -zefram |
From zefram@fysh.orgI wrote:
Now reverted as commit 0ebeacd. However, the part of the commit that seems potentially useful would -zefram |
From @bdracoIt looks like lib/UNIVERSAL/isa.pm:_report_warning is handling the same problem for Test::Builder and Test::Stream with an explicit check: 96 # check calling sub Adding this for Carp allows it to pass: 101 return if (( caller(2) )[0] || '') =~ /^Carp/; However there is probably a better way to handle this. -Nick
|
From @xsawyerxI think some of it can be applied since they are less pervasive, but Meanwhile, I think considering the breakage, it makes sense to revert. On 11/05/2017 02:35 AM, J. Nick Koston wrote:
|
From @karenetheridgeThe blead commit has been reverted. |
@karenetheridge - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132395 (status was 'resolved')
Searchable as RT132395$
The text was updated successfully, but these errors were encountered: