New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perl-5.26.1/doio.c:1529]: (style) Suspicious condition #16168
Comments
From dcb314@hotmail.comHello there, perl-5.26.1/doio.c:1529]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ( ( (SvROK(sv) && ( isGV_with_GP(SvRV(sv)) Maybe better code if ( ( (SvROK(sv) && ( isGV_with_GP(SvRV(sv)) Regards David Binderman |
From @jkeenanOn Sat, 23 Sep 2017 22:43:07 GMT, dcb314@hotmail.com wrote:
Can you provide (as an attachment) the output of 'perl -V' for the perl build that generated this warning? We will, in particular, be looking for information on the C compiler you used for 'make' and the operating system on which you are running. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @LeontOn Sun, Sep 24, 2017 at 12:43 AM, David Binderman <perlbug-followup@perl.org
I can see why why your compiler/linter could conclude that looks
No, that's exactly the wrong thing to do. If we add parentheses to please Leon |
Migrated from rt.perl.org#132153 (status was 'open')
Searchable as RT132153$
The text was updated successfully, but these errors were encountered: