Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match.made leaks a NQPMu #6460

Closed
p6rt opened this issue Aug 20, 2017 · 4 comments
Closed

Match.made leaks a NQPMu #6460

p6rt opened this issue Aug 20, 2017 · 4 comments
Labels
regex Regular expressions, pattern matching, user-defined grammars, tokens and rules regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Aug 20, 2017

Migrated from rt.perl.org#131936 (status was 'resolved')

Searchable as RT131936$

@p6rt
Copy link
Author

p6rt commented Aug 20, 2017

From @smls

It happens when `.made` is called on a Match on which `.make` was never
called​:

  say "a".match(/a/).made.^name; # NQPMu

This used to return `Any`. (Arguably, `Nil` would be ideal.)

The `NQPMu` is a problem because it blows up when you pass it to `say`
or `dd`, among other things.


As for figuring out what caused the regression, bisectable can merely
narrow it down to 20 commits​:
https://gist.github.com/Whateverable/1176206b14ad722b53e6c6e920e60357

But based on the commit messages, this one sounds most relevant​:
rakudo/rakudo@18bb9be


This is Rakudo version 2017.07-214-g2545e6d65 built on MoarVM version
2017.07-467-gf22f8d7c
implementing Perl 6.c.

@p6rt
Copy link
Author

p6rt commented Aug 27, 2017

From @smls

Fixed by lizmat in commit​:

  rakudo/rakudo@5db5b1d

Tests needed.

@p6rt
Copy link
Author

p6rt commented Oct 6, 2017

From @smls

Test were added by Zoffix a month ago​:
Raku/roast@8674f1e8c

Closing.

@p6rt
Copy link
Author

p6rt commented Oct 6, 2017

@smls - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Oct 6, 2017
@p6rt p6rt added regex Regular expressions, pattern matching, user-defined grammars, tokens and rules regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regex Regular expressions, pattern matching, user-defined grammars, tokens and rules regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant