New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.27.0-228-g34f8e9c776 breaks JREFIOR/Finance-StockAccount-0.01.tar.gz #16046
Comments
From @andkKudos to Slaven who digged it up! bisect commit 34f8e9c Perl_sv_vcatpvfn_flags: simplify float_need calc diagnostics t/realization.t ............ 1/? panic: snprintf buffer overflow at /tmp/loop_over_bdir-114 perl -V Summary of my perl5 (revision 5 version 27 subversion 1) configuration: Characteristics of this binary (from libperl): -- |
From @jkeenanOn Mon, 26 Jun 2017 20:04:36 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
This is curious. When I try to install Finance::StockAccount via 'cpanm' I get the same failures as reported here, viz., 3 instances of this error: ##### ... one for each of t/allactivityregression.t, t/realization.t, and t/set.t. Now suppose that (a) I change into the .cpanm build directory and try to run the tests with 'prove': ##### All tests PASS. But, of course, there's a cheat here. I should have been running with the 'prove' that was built in my 'blead' version of perl -- not the 'prove' that was installed with perl-5.26.0. When I do the right thing: ##### ... I get the same panics, e.g.: ##### Here is the relevant subroutine from Finance::StockAccount: ##### This bug has not yet been reported to https://rt.cpan.org/Dist/Display.html?Name=Finance-StockAccount. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Mon, 26 Jun 2017 20:04:36 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
This can be reduced to the test case attached. Run it against blead. The panic is associated with the addition of the 5th item in the printf formatting string: %53.2f Thank you very much. -- |
From @jkeenanOn Mon, 26 Jun 2017 22:34:33 GMT, jkeenan wrote:
Or more simply to the second attachment. -- |
From @iabynOn Mon, Jun 26, 2017 at 03:42:59PM -0700, James E Keenan via RT wrote:
Thanks for the reduction. I've just pushed this, which should fix it: commit 571ee10 PERL_SNPRINTF_CHECK(): off by 1 error -- |
From @jkeenanOn Tue, 27 Jun 2017 09:09:56 GMT, davem wrote:
Confirmed. ##### $ ./bin/cpanm Finance::StockAccount I'll take this ticket for the purpose of closing it within 7 days unless Slaven or Andreas indicates otherwise. Thank you very much. -- |
From @maukeAm 27.06.2017 um 11:09 schrieb Dave Mitchell:
I haven't looked at the code but this part of the commit message looks char buf[3]; I'd expect buf = { '9', '8', '\0' } (truncated) and ret = 4 (because ret In other words, it sounds like adding 1 is actually a hard requirement -- |
From @iabynOn Sun, Jul 02, 2017 at 10:37:07AM +0200, Lukas Mai wrote:
Ah so it is. So my commit was correct, but for the wrong reasons (and the -- |
From @jkeenanOn Mon, 03 Jul 2017 08:11:10 GMT, davem wrote:
Since the commit itself was correct, I'm marking the ticket Resolved as per schedule. Perhaps Dave could make another (whitespace?) commit which provides a better commit message. Thank you very much. -- |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#131659 (status was 'resolved')
Searchable as RT131659$
The text was updated successfully, but these errors were encountered: