Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoarVM panic if you check for membership in undefined Set #6240

Closed
p6rt opened this issue May 12, 2017 · 8 comments
Closed

MoarVM panic if you check for membership in undefined Set #6240

p6rt opened this issue May 12, 2017 · 8 comments

Comments

@p6rt
Copy link

p6rt commented May 12, 2017

Migrated from rt.perl.org#131300 (status was 'resolved')

Searchable as RT131300$

@p6rt
Copy link
Author

p6rt commented May 12, 2017

From curt@tilmes.org

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed; could
not allocate 83968 bytes␤»

@p6rt
Copy link
Author

p6rt commented May 12, 2017

From @zoffixznet

On Fri, 12 May 2017 12​:07​:11 -0700, curt@​tilmes.org wrote​:

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed; could
not allocate 83968 bytes␤»

To add from https://irclog.perlgeek.de/perl6/2017-05-12#i_14573414

19​:16 Zoffix it infini-loops in dispatch because Set.Set returns Set. And so far I see (elem), (cont), ∉, ∋, ∌ similarly affected. There might be more. Would you mind filing a bug for it?
19​:20 Zoffix And some ops like ⊇ and ⊉ crash with "can't look up attributes... " error. There's probably a meaning for type objects we could implement; like Set eqv set()

@p6rt
Copy link
Author

p6rt commented May 12, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 12, 2017

From @lizmat

Fixed for (elem) and (cont) with rakudo/rakudo@ba0581d75b .
Tests needed.

On 12 May 2017, at 21​:22, Zoffix Znet via RT <perl6-bugs-followup@​perl.org> wrote​:

On Fri, 12 May 2017 12​:07​:11 -0700, curt@​tilmes.org wrote​:

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed; could
not allocate 83968 bytes␤»

To add from https://irclog.perlgeek.de/perl6/2017-05-12#i_14573414

19​:16 Zoffix it infini-loops in dispatch because Set.Set returns Set. And so far I see (elem), (cont), ∉, ∋, ∌ similarly affected. There might be more. Would you mind filing a bug for it?
19​:20 Zoffix And some ops like ⊇ and ⊉ crash with "can't look up attributes... " error. There's probably a meaning for type objects we could implement; like Set eqv set()

@p6rt
Copy link
Author

p6rt commented May 13, 2017

From @lizmat

All issues appear to be fixed with rakudo/rakudo@407bce1dc2 .
Tests are needed, also for the ⊇ and ⊉ and associated cases.

On 12 May 2017, at 21​:22, Zoffix Znet via RT <perl6-bugs-followup@​perl.org> wrote​:
On Fri, 12 May 2017 12​:07​:11 -0700, curt@​tilmes.org wrote​:

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed; could
not allocate 83968 bytes␤»

To add from https://irclog.perlgeek.de/perl6/2017-05-12#i_14573414

19​:16 Zoffix it infini-loops in dispatch because Set.Set returns Set. And so far I see (elem), (cont), ∉, ∋, ∌ similarly affected. There might be more. Would you mind filing a bug for it?
19​:20 Zoffix And some ops like ⊇ and ⊉ crash with "can't look up attributes... " error. There's probably a meaning for type objects we could implement; like Set eqv set()

@p6rt
Copy link
Author

p6rt commented Oct 15, 2017

From @zoffixznet

On Sat, 13 May 2017 01​:24​:28 -0700, elizabeth wrote​:

All issues appear to be fixed with
rakudo/rakudo@407bce1dc2 .
Tests are needed, also for the ⊇ and ⊉ and associated cases.

On 12 May 2017, at 21​:22, Zoffix Znet via RT <perl6-bugs-
followup@​perl.org> wrote​:
On Fri, 12 May 2017 12​:07​:11 -0700, curt@​tilmes.org wrote​:

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed;
could
not allocate 83968 bytes␤»

To add from https://irclog.perlgeek.de/perl6/2017-05-12#i_14573414

19​:16 Zoffix it infini-loops in dispatch because Set.Set
returns Set. And so far I see (elem), (cont), ∉, ∋, ∌ similarly
affected. There might be more. Would you mind filing a bug for it?
19​:20 Zoffix And some ops like ⊇ and ⊉ crash with "can't
look up attributes... " error. There's probably a meaning for type
objects we could implement; like Set eqv set()

Tests committed[^1], but they show this ticket is not entirely resolved​:

  Still hangs for​: ∩ (&) ⊍ (.)

  Still have "Cannot lookup attributes in type object" for​: ∖ (-)

The problematic tests are currently (manually) skip-fudged.

[1] Raku/roast@87889891d1

@p6rt
Copy link
Author

p6rt commented Oct 17, 2017

From @lizmat

Fixed with 8a88d14905248526415 , unfudged tests, can be closed now.

On 15 Oct 2017, at 08​:54, Zoffix Znet via RT <perl6-bugs-followup@​perl.org> wrote​:

On Sat, 13 May 2017 01​:24​:28 -0700, elizabeth wrote​:

All issues appear to be fixed with
rakudo/rakudo@407bce1dc2 .
Tests are needed, also for the ⊇ and ⊉ and associated cases.

On 12 May 2017, at 21​:22, Zoffix Znet via RT <perl6-bugs-
followup@​perl.org> wrote​:
On Fri, 12 May 2017 12​:07​:11 -0700, curt@​tilmes.org wrote​:

m​: say 1 ∈ (Set) ?? 'present' !! 'not present';
rakudo-moar dc5eec​: OUTPUT​: «MoarVM panic​: Memory allocation failed;
could
not allocate 83968 bytes␤»

To add from https://irclog.perlgeek.de/perl6/2017-05-12#i_14573414

19​:16 Zoffix it infini-loops in dispatch because Set.Set
returns Set. And so far I see (elem), (cont), ∉, ∋, ∌ similarly
affected. There might be more. Would you mind filing a bug for it?
19​:20 Zoffix And some ops like ⊇ and ⊉ crash with "can't
look up attributes... " error. There's probably a meaning for type
objects we could implement; like Set eqv set()

Tests committed[^1], but they show this ticket is not entirely resolved​:

Still hangs for​: ∩ (&) ⊍ (.)

Still have "Cannot lookup attributes in type object" for​: ∖ (-)

The problematic tests are currently (manually) skip-fudged.

[1] Raku/roast@87889891d1

@p6rt
Copy link
Author

p6rt commented Oct 17, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant