Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunked xx not calling pull-one deep enough? #6149

Closed
p6rt opened this issue Mar 11, 2017 · 4 comments
Closed

Thunked xx not calling pull-one deep enough? #6149

p6rt opened this issue Mar 11, 2017 · 4 comments

Comments

@p6rt
Copy link

p6rt commented Mar 11, 2017

Migrated from rt.perl.org#130980 (status was 'resolved')

Searchable as RT130980$

@p6rt
Copy link
Author

p6rt commented Mar 11, 2017

From @lizmat

$ 6 'my $a = 0; ($a++,) Zxx 42; say $a’
0

$ 6 'my $a = 0; ($a++,) Xxx 42; say $a’
0

Before rakudo/rakudo@1754dc5f7e , this would have yielded 42 in both cases. However, this was a side-effect (pun intended) of thunk xx 42 being eager internally. Since this commit, it is no longer, and this case the inner thunk does not get called when in a sink context.

This *could* be a bug, but I’m not sure. Since the commit made 4 spectests that assume the old behaviour fail, it seemed wise to make a ticket before fudging the tests.

Please close this bug report if it’s not a bug, and remove/adapt the associated tests.

@p6rt
Copy link
Author

p6rt commented Mar 16, 2018

From @dogbert17

On Sat, 11 Mar 2017 03​:02​:39 -0800, elizabeth wrote​:

$ 6 'my $a = 0; ($a++,) Zxx 42; say $a’
0

$ 6 'my $a = 0; ($a++,) Xxx 42; say $a’
0

Before rakudo/rakudo@1754dc5f7e , this would
have yielded 42 in both cases. However, this was a side-effect (pun
intended) of thunk xx 42 being eager internally. Since this commit,
it is no longer, and this case the inner thunk does not get called
when in a sink context.

This *could* be a bug, but I’m not sure. Since the commit made 4
spectests that assume the old behaviour fail, it seemed wise to make a
ticket before fudging the tests.

Please close this bug report if it’s not a bug, and remove/adapt the
associated tests.

Tests unfudged with roast commit 6e56c434f46dbb67f5c

@p6rt
Copy link
Author

p6rt commented Mar 16, 2018

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 16, 2018

@dogbert17 - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Mar 16, 2018
@p6rt p6rt added the testneeded label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant