Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care of cas #5920

Closed
p6rt opened this issue Dec 27, 2016 · 4 comments
Closed

Take care of cas #5920

p6rt opened this issue Dec 27, 2016 · 4 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Dec 27, 2016

Migrated from rt.perl.org#130417 (status was 'resolved')

Searchable as RT130417$

@p6rt
Copy link
Author

p6rt commented Dec 27, 2016

From @AlexDaniel

https://github.com/rakudo/rakudo/blob/9594a3ece38ca212023cf3ece7405d955303db13/src/core/asyncops.pm#L50

<jnthn> I thought I killed that off once
<jnthn> I did in 539b5f44ef3f pre-xmas
<jnthn> Because I thought it was pretty ridiculous having a non-atomic CAS in there :/
<jnthn> I made the mistake of tossing it with something else and it seems it got restored later as if I did it by accident rather than by quiet sleight of hand :P
<AlexDaniel> jnthn​: can you take care of it now? :)
<jnthn> AlexDaniel​: Well, we could actually do with a working cas... :P
<jnthn> (A few things I'd like to do could use it)
<jnthn> So I'll probably just fix it sometime next year :)
<jnthn> AlexDaniel​: Feel free, and mark it [CONC]; I watch the CONC list for stuff to do :)

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

From @jnthn

On Tue, 27 Dec 2016 12​:32​:50 -0800, alex.jakimenko@​gmail.com wrote​:

https://github.com/rakudo/rakudo/blob/9594a3ece38ca212023cf3ece7405d955303db13/src/core/asyncops.pm#L50

<jnthn> I thought I killed that off once
<jnthn> I did in 539b5f44ef3f pre-xmas
<jnthn> Because I thought it was pretty ridiculous having a non-atomic
CAS in there :/
<jnthn> I made the mistake of tossing it with something else and it
seems it got restored later as if I did it by accident rather than by
quiet sleight of hand :P
<AlexDaniel> jnthn​: can you take care of it now? :)
<jnthn> AlexDaniel​: Well, we could actually do with a working cas...
:P
<jnthn> (A few things I'd like to do could use it)
<jnthn> So I'll probably just fix it sometime next year :)
<jnthn> AlexDaniel​: Feel free, and mark it [CONC]; I watch the CONC
list for stuff to do :)

This got sorted out. There's now lots of tests that cas really does an atomic compare and swap (e.g. S17-lowlevel/cas.t).

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Sep 12, 2017
@p6rt p6rt added the conc label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant