New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply to maint-5.14: #95748 IPC::Open3::open3(..., '-') broken #12327
Comments
From @jmdh[This is possibly a duplicate ticket, but the first one hasn't shown Attached is a trivial backport of f8b0429 to maint-5.14; this has The patch did not quite apply cleanly owing to some refactoring between Please consider this for inclusion in 5.14.3. Thanks! [1] <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683894> -- |
From @jmdh0001-perl-95748-IPC-Open3-open3-.-broken.patchFrom 55ec0f83de941e2c2415500e26d005b8758b3bb7 Mon Sep 17 00:00:00 2001
From: Salvador Fandino <sfandino@yahoo.com>
Date: Wed, 27 Jul 2011 09:20:29 -0700
Subject: [PATCH] [perl #95748] IPC::Open3::open3(..., '-') broken
IPC::Open3::open3($in, $out, $err, '-') is broken in 5.14.1
Because the old "return 0" used to return to user code now is wrapped inside and eval block.
This patch solves the problem.
---
ext/IPC-Open3/lib/IPC/Open3.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ext/IPC-Open3/lib/IPC/Open3.pm b/ext/IPC-Open3/lib/IPC/Open3.pm
index 7015d27..e238528 100644
--- a/ext/IPC-Open3/lib/IPC/Open3.pm
+++ b/ext/IPC-Open3/lib/IPC/Open3.pm
@@ -284,11 +284,14 @@ sub _open3 {
} else {
xopen \*STDERR, ">&STDOUT" if fileno(STDERR) != fileno(STDOUT);
}
- return 0 if ($cmd[0] eq '-');
+ return 1 if ($cmd[0] eq '-');
exec @cmd or do {
local($")=(" ");
croak "$Me: exec of @cmd failed";
};
+ } and do {
+ close $stat_w;
+ return 0;
};
my $bang = 0+$!;
|
From @jmdhOn Sat, Aug 11, 2012 at 05:03:36AM -0700, Dominic Hargreaves wrote:
This was already voted on in cherrymaint, and I've now applied this -- |
@jmdh - Status changed from 'new' to 'resolved' |
Migrated from rt.perl.org#114454 (status was 'resolved')
Searchable as RT114454$
The text was updated successfully, but these errors were encountered: