Data::Dumper -- undef not recognized as "false" in config booleans #12135
Comments
From @jimavCreated by @jimavThis is a bug report for perl from james_avera@yahoo.com, ----------------------------------------------------------------- This is not a big deal, but if you want to make them accept undef Inline Patch--- Dumper.pm 2012-05-26 04:25:18.236706958 +0000
+++ Dumper.pm.ORIG 2012-05-25 19:06:41.775175838 +0000
@@ -607,17 +607,17 @@
sub Purity {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{purity} = $v), return $s) : $s->{purity};
+ defined($v) ? (($s->{purity} = $v), return $s) : $s->{purity};
}
sub Useqq {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{useqq} = $v), return $s) : $s->{useqq};
+ defined($v) ? (($s->{useqq} = $v), return $s) : $s->{useqq};
}
sub Terse {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{terse} = $v), return $s) : $s->{terse};
+ defined($v) ? (($s->{terse} = $v), return $s) : $s->{terse};
}
sub Freezer {
@@ -632,12 +632,12 @@
sub Deepcopy {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{deepcopy} = $v), return $s) : $s->{deepcopy};
+ defined($v) ? (($s->{deepcopy} = $v), return $s) : $s->{deepcopy};
}
sub Quotekeys {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{quotekeys} = $v), return $s) : $s->{quotekeys};
+ defined($v) ? (($s->{quotekeys} = $v), return $s) : $s->{quotekeys};
}
sub Bless {
@@ -652,17 +652,17 @@
sub Useperl {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{'useperl'} = $v), return $s) : $s->{'useperl'};
+ defined($v) ? (($s->{'useperl'} = $v), return $s) : $s->{'useperl'};
}
sub Sortkeys {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{'sortkeys'} = $v), return $s) : $s->{'sortkeys'};
+ defined($v) ? (($s->{'sortkeys'} = $v), return $s) : $s->{'sortkeys'};
}
sub Deparse {
my($s, $v) = @_;
- @_ >= 2 ? (($s->{'deparse'} = $v), return $s) : $s->{'deparse'};
+ defined($v) ? (($s->{'deparse'} = $v), return $s) : $s->{'deparse'};
}
# used by qquote belowPerl Info |
From @cpansproutOn Fri May 25 21:30:52 2012, jimav wrote:
I think this is a good idea, and that Freezer and Toaster should also Could you perhaps include some tests for this? Also, please note that
PATH=/home/jima/bin:/home/jima/local/bin:/home/jima/jima_tools/x86_64/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/bin/X11:/usr/local/bin:/opt/openoffice.org3/program:/usr/local/games:/usr/games:.
-- Father Chrysostomos |
|
The RT System itself - Status changed from 'new' to 'open' |
From @demerphqOn 26 May 2012 06:56, Father Chrysostomos via RT
We should check that this does not interact with the dynamically Yves -- |
From @jimavSorry about the reversed patch. A corrected patch (including Freezer & I have used the modified code, but not exhaustively tested every method. |
From @jimavInline Patch--- Dumper.pm.ORIG 2012-05-25 19:06:41.775175838 +0000
+++ Dumper.pm 2012-05-26 21:28:30.603511523 +0000
@@ -607,37 +607,37 @@
sub Purity {
my($s, $v) = @_;
- defined($v) ? (($s->{purity} = $v), return $s) : $s->{purity};
+ @_ >= 2 ? (($s->{purity} = $v), return $s) : $s->{purity};
}
sub Useqq {
my($s, $v) = @_;
- defined($v) ? (($s->{useqq} = $v), return $s) : $s->{useqq};
+ @_ >= 2 ? (($s->{useqq} = $v), return $s) : $s->{useqq};
}
sub Terse {
my($s, $v) = @_;
- defined($v) ? (($s->{terse} = $v), return $s) : $s->{terse};
+ @_ >= 2 ? (($s->{terse} = $v), return $s) : $s->{terse};
}
sub Freezer {
my($s, $v) = @_;
- defined($v) ? (($s->{freezer} = $v), return $s) : $s->{freezer};
+ @_ >= 2 ? (($s->{freezer} = $v), return $s) : $s->{freezer};
}
sub Toaster {
my($s, $v) = @_;
- defined($v) ? (($s->{toaster} = $v), return $s) : $s->{toaster};
+ @_ >= 2 ? (($s->{toaster} = $v), return $s) : $s->{toaster};
}
sub Deepcopy {
my($s, $v) = @_;
- defined($v) ? (($s->{deepcopy} = $v), return $s) : $s->{deepcopy};
+ @_ >= 2 ? (($s->{deepcopy} = $v), return $s) : $s->{deepcopy};
}
sub Quotekeys {
my($s, $v) = @_;
- defined($v) ? (($s->{quotekeys} = $v), return $s) : $s->{quotekeys};
+ @_ >= 2 ? (($s->{quotekeys} = $v), return $s) : $s->{quotekeys};
}
sub Bless {
@@ -652,17 +652,17 @@
sub Useperl {
my($s, $v) = @_;
- defined($v) ? (($s->{'useperl'} = $v), return $s) : $s->{'useperl'};
+ @_ >= 2 ? (($s->{'useperl'} = $v), return $s) : $s->{'useperl'};
}
sub Sortkeys {
my($s, $v) = @_;
- defined($v) ? (($s->{'sortkeys'} = $v), return $s) : $s->{'sortkeys'};
+ @_ >= 2 ? (($s->{'sortkeys'} = $v), return $s) : $s->{'sortkeys'};
}
sub Deparse {
my($s, $v) = @_;
- defined($v) ? (($s->{'deparse'} = $v), return $s) : $s->{'deparse'};
+ @_ >= 2 ? (($s->{'deparse'} = $v), return $s) : $s->{'deparse'};
}
# used by qquote below |
From zefram@fysh.orgFixed by commit dd9e86b. -zefram |
|
@iabyn - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#113090 (status was 'resolved')
Searchable as RT113090$
The text was updated successfully, but these errors were encountered: