Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a multi variant to .comb for the common case #2383

Closed
p6rt opened this issue Mar 7, 2011 · 4 comments
Closed

Add a multi variant to .comb for the common case #2383

p6rt opened this issue Mar 7, 2011 · 4 comments
Labels
LHF Low-hanging fruit, easy to resolve Todo

Comments

@p6rt
Copy link

p6rt commented Mar 7, 2011

Migrated from rt.perl.org#85602 (status was 'resolved')

Searchable as RT85602$

@p6rt
Copy link
Author

p6rt commented Mar 7, 2011

From @masak

So, currently if you do .comb(), the multi that gets called does the
splitting into one-char strings by matching /./ repeatedly on the
whole string. In the best case one wouldn't have to use regexes at all
for this, and it'd be a lot faster.

Someone pls write a nice multi for the common case. Keeping it lazy
like the general .comb would be nice, too.

@p6rt
Copy link
Author

p6rt commented May 2, 2011

From @tadzik

On Mon Mar 07 07​:31​:06 2011, masak wrote​:

Someone pls write a nice multi for the common case. Keeping it lazy
like the general .comb would be nice, too.

Fixed in rakudo/rakudo@6ca6140a468. According
to Benchmark.pm6 it's about 7-10 times faster. And it's lazy of course.

@p6rt
Copy link
Author

p6rt commented May 2, 2011

From @moritz

fixed by tadzik++ in 6ca6140a4683a66b9f7d54e9a336051d5f564924.
No separate test coverage needed, since it's the same behavior as
before, just faster.

@p6rt
Copy link
Author

p6rt commented May 2, 2011

@moritz - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed May 2, 2011
@p6rt p6rt added LHF Low-hanging fruit, easy to resolve Todo labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LHF Low-hanging fruit, easy to resolve Todo
Projects
None yet
Development

No branches or pull requests

1 participant