Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniq should use === semantics, not eq semantics in Rakudo #2350

Closed
p6rt opened this issue Feb 6, 2011 · 5 comments
Closed

uniq should use === semantics, not eq semantics in Rakudo #2350

p6rt opened this issue Feb 6, 2011 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Feb 6, 2011

Migrated from rt.perl.org#83454 (status was 'resolved')

Searchable as RT83454$

@p6rt
Copy link
Author

p6rt commented Feb 6, 2011

From @masak

<masak> rakudo​: say (uniq 1, "1").perl
<p6eval> rakudo 924242​: OUTPUT«(1)␤»
<masak> is that what we expect of uniq?
<TimToady> no, I expect === semantics
* masak submits rakudobug
<TimToady> Cat.new("mitsy") and Dog.new("mitsy") are obviously two
different critters [01​:11]
<masak> yap.

@p6rt
Copy link
Author

p6rt commented Dec 10, 2012

From @jnthn

On Sat Feb 05 16​:17​:52 2011, masak wrote​:

<masak> rakudo​: say (uniq 1, "1").perl
<p6eval> rakudo 924242​: OUTPUT«(1)␤»
<masak> is that what we expect of uniq?
<TimToady> no, I expect === semantics
* masak submits rakudobug
<TimToady> Cat.new("mitsy") and Dog.new("mitsy") are obviously two
different critters [01​:11]
<masak> yap.

Fixed now​:

say (uniq 1, "1").perl
(1, "1").list

Tagging testneeded.

/jnthn

@p6rt
Copy link
Author

p6rt commented Dec 10, 2012

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 29, 2013

From @coke

On Mon Dec 10 10​:39​:12 2012, jnthn@​jnthn.net wrote​:

On Sat Feb 05 16​:17​:52 2011, masak wrote​:

<masak> rakudo​: say (uniq 1, "1").perl
<p6eval> rakudo 924242​: OUTPUT«(1)␤»
<masak> is that what we expect of uniq?
<TimToady> no, I expect === semantics
* masak submits rakudobug
<TimToady> Cat.new("mitsy") and Dog.new("mitsy") are obviously two
different critters [01​:11]
<masak> yap.

Fixed now​:

say (uniq 1, "1").perl
(1, "1").list

Tagging testneeded.

/jnthn

Added test to S32-list/uniq.t , which had another related test for RT#​111360.

Resolving ticket.
--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Mar 29, 2013

@coke - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant