"open FH, '<:raw', $filehandle" makes filehandle unbuffered #10904
Comments
From leon@leon-laptop.This is a bug report for perl from leon@leon-laptop.(none), Opening a file with :raw doesn't work as documented. It opens the file with only the :unix layer, without a perlio layer, hence it will be unbuffered. Opening a file without a specific mode and using binmode later does give the correct result. I've could replicate this bug on 5.8.9, 5.10.1, 5.12.1 and blead. Example code: use Data::Dumper; #works incorrectly #works correctly Flags: Site configuration information for perl 5.12.1: Configured by leon at Fri Aug 20 20:56:31 EEST 2010. Summary of my perl5 (revision 5 version 12 subversion 1) configuration: Locally applied patches: @INC for perl 5.12.1: Environment for perl 5.12.1: |
From @LeontThe attached patch makes «open FH, ':raw' $filename» do what it I have only tested it on Linux though, testing on Windows is required. |
From @Leont0001-Fixes-raw-layer.patchFrom 4977fc22afd079b28032afbd5b5257b4772eb0c2 Mon Sep 17 00:00:00 2001
From: Leon Timmermans <fawaka@gmail.com>
Date: Mon, 3 Jan 2011 22:48:47 +0100
Subject: [PATCH] Fixes 'raw' layer for perl#80764
Made a ':raw' open do what it advertises to do (first open the file,
then binmode it), instead of leaving off the top layer.
---
perlio.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/perlio.c b/perlio.c
index cd58448..9b3f37b 100644
--- a/perlio.c
+++ b/perlio.c
@@ -2008,11 +2008,15 @@ PerlIORaw_open(pTHX_ PerlIO_funcs *self, PerlIO_list_t *layers,
IV n, const char *mode, int fd, int imode, int perm,
PerlIO *old, int narg, SV **args)
{
- PerlIO_funcs * const tab = PerlIO_default_btm();
+ PerlIO_funcs * const tab = PerlIO_default_top();
PERL_UNUSED_ARG(self);
- if (tab && tab->Open)
- return (*tab->Open) (aTHX_ tab, layers, n - 1, mode, fd, imode, perm,
- old, narg, args);
+ if (tab && tab->Open) {
+ PerlIO* ret = (*tab->Open) (aTHX_ tab, layers, n - 1, mode, fd, imode,
+ perm, old, narg, args);
+ PerlIO_push(aTHX_ ret, PERLIO_FUNCS_CAST(&PerlIO_raw), NULL, NULL);
+ return ret;
+ }
+
SETERRNO(EINVAL, LIB_INVARG);
return NULL;
}
--
1.7.1
|
From [Unknown Contact. See original ticket]The attached patch makes «open FH, ':raw' $filename» do what it I have only tested it on Linux though, testing on Windows is required. |
|
@Leont - Status changed from 'new' to 'open' |
From @ikegamiOn Mon, Jan 3, 2011 at 5:12 PM, fawaka@gmail.com via RT <
Does it fix the following? use Test::More tests => 1; If so, that would be worth mentioning in the release notes and a test should Does the following still work on Windows? open(my $fh, ">:raw:perlio:encoding(UTF-16le):crlf", - Eric |
From @LeontOn Tue, Jan 4, 2011 at 3:18 AM, Eric Brine <ikegami@adaelis.com> wrote:
Apparently it doesn't work with my patch either, but I just fixed that
It works on Linux and I see no reason why it shouldn't work on Leon |
From @ikegamiOn Mon, Jan 3, 2011 at 10:59 PM, Leon Timmermans <fawaka@gmail.com> wrote:
sweet :)
If you end up with an extra :crlf below, then it's not working. The explicit :perlio instead of the desired :perlio or :perlio It seems to me we should have a solution to the :crlf and :encoding ordering - Eric |
From @LeontOn Tue, Jan 4, 2011 at 9:15 AM, Eric Brine <ikegami@adaelis.com> wrote:
I've attached a second patch that I think will solve that issue. Leon |
From @Leont0001-Fixes-raw-layer-for-perl-80764.patchFrom 2972bd1ff9f9773dc5c197aa88e4010a40d430ab Mon Sep 17 00:00:00 2001
From: Leon Timmermans <fawaka@gmail.com>
Date: Mon, 3 Jan 2011 22:48:47 +0100
Subject: [PATCH 1/2] Fixes 'raw' layer for perl#80764
Made a ':raw' open do what it advertises to do (first open the file,
then binmode it), instead of leaving off the top layer.
---
perlio.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/perlio.c b/perlio.c
index 0eee430..4030180 100644
--- a/perlio.c
+++ b/perlio.c
@@ -2008,11 +2008,15 @@ PerlIORaw_open(pTHX_ PerlIO_funcs *self, PerlIO_list_t *layers,
IV n, const char *mode, int fd, int imode, int perm,
PerlIO *old, int narg, SV **args)
{
- PerlIO_funcs * const tab = PerlIO_default_btm();
- PERL_UNUSED_ARG(self);
- if (tab && tab->Open)
- return (*tab->Open) (aTHX_ tab, layers, n - 1, mode, fd, imode, perm,
- old, narg, args);
+ PerlIO_funcs * const tab =
+ PerlIO_layer_fetch(aTHX_ layers, n - 1, PerlIO_default_btm());
+ if (tab && tab->Open) {
+ PerlIO* ret = (*tab->Open) (aTHX_ tab, layers, n - 1, mode, fd, imode,
+ perm, old, narg, args);
+ PerlIO_push(aTHX_ ret, PERLIO_FUNCS_CAST(&PerlIO_raw), NULL, NULL);
+ return ret;
+ }
+
SETERRNO(EINVAL, LIB_INVARG);
return NULL;
}
--
1.7.1
|
From @Leont0002-binmode-FH-crlf-only-modifies-top-crlf-layer.patchFrom 78cc11c9ad89f424cb97b2805a763c53d60a4a83 Mon Sep 17 00:00:00 2001
From: Leon Timmermans <fawaka@gmail.com>
Date: Thu, 20 Jan 2011 01:59:56 +0100
Subject: [PATCH 2/2] binmode FH, ":crlf" only modifies top crlf layer
When pushed on top of the stack, crlf will no longer enable crlf layers
lower in the stack. This will prevent unexpected results.
---
perlio.c | 5 ++---
t/io/layers.t | 18 +++++++++++++++---
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/perlio.c b/perlio.c
index 4030180..48c32ff 100644
--- a/perlio.c
+++ b/perlio.c
@@ -4513,7 +4513,7 @@ PerlIOCrlf_pushed(pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab)
* any given moment at most one CRLF-capable layer being enabled
* in the whole layer stack. */
PerlIO *g = PerlIONext(f);
- while (PerlIOValid(g)) {
+ if (PerlIOValid(g)) {
PerlIOl *b = PerlIOBase(g);
if (b && b->tab == &PerlIO_crlf) {
if (!(b->flags & PERLIO_F_CRLF))
@@ -4521,8 +4521,7 @@ PerlIOCrlf_pushed(pTHX_ PerlIO *f, const char *mode, SV *arg, PerlIO_funcs *tab)
S_inherit_utf8_flag(g);
PerlIO_pop(aTHX_ f);
return code;
- }
- g = PerlIONext(g);
+ }
}
}
S_inherit_utf8_flag(f);
diff --git a/t/io/layers.t b/t/io/layers.t
index dea3d09..b0bcf1e 100644
--- a/t/io/layers.t
+++ b/t/io/layers.t
@@ -43,7 +43,7 @@ if (${^UNICODE} & 1) {
} else {
$UTF8_STDIN = 0;
}
-my $NTEST = 45 - (($DOSISH || !$FASTSTDIO) ? 7 : 0) - ($DOSISH ? 5 : 0)
+my $NTEST = 55 - (($DOSISH || !$FASTSTDIO) ? 7 : 0) - ($DOSISH ? 7 : 0)
+ $UTF8_STDIN;
sub PerlIO::F_UTF8 () { 0x00008000 } # from perliol.h
@@ -105,7 +105,7 @@ SKIP: {
# 5 tests potentially skipped because
# DOSISH systems already have a CRLF layer
# which will make new ones not stick.
- @$expected = grep { $_ ne 'crlf' } @$expected;
+ splice @$expected, 1, 1 if $expected->[1] eq 'crlf';
}
my $n = scalar @$expected;
is(scalar @$result, $n, "$id - layers == $n");
@@ -132,13 +132,25 @@ SKIP: {
[ qw(stdio crlf) ],
"open :crlf");
+ binmode(F, ":crlf");
+
+ check([ PerlIO::get_layers(F) ],
+ [ qw(stdio crlf) ],
+ "binmode :crlf");
+
binmode(F, ":encoding(cp1047)");
check([ PerlIO::get_layers(F) ],
[ qw[stdio crlf encoding(cp1047) utf8] ],
":encoding(cp1047)");
+
+ binmode(F, ":crlf");
+
+ check([ PerlIO::get_layers(F) ],
+ [ qw[stdio crlf encoding(cp1047) utf8 crlf utf8] ],
+ ":encoding(cp1047):crlf");
- binmode(F, ":pop");
+ binmode(F, ":pop:pop");
check([ PerlIO::get_layers(F) ],
[ qw(stdio crlf) ],
--
1.7.1
|
From @cpansproutThis has now been fixed by one of the patches from ticket #82484. |
|
@cpansprout - Status changed from 'open' to 'resolved' |
From @ikegamiOn Thu, Jan 20, 2011 at 10:30 AM, Leon Timmermans <fawaka@gmail.com> wrote:
Indeed, thanks! |
1 similar comment
From @ikegamiOn Thu, Jan 20, 2011 at 10:30 AM, Leon Timmermans <fawaka@gmail.com> wrote:
Indeed, thanks! |
Migrated from rt.perl.org#80764 (status was 'resolved')
Searchable as RT80764$
The text was updated successfully, but these errors were encountered: