IPC::Open3 doesn't handle file descriptors correctly #10483

p5pRT · 2010-07-12T15:30:06Z

Migrated from rt.perl.org#76474 (status was 'resolved')

Searchable as RT76474$

p5pRT · 2010-07-12T15:30:07Z

From vlyon@cpan.org

This is a bug report for perl from vlyon@cpan.org,
generated with the help of perlbug 1.39 running under perl 5.10.1.

In the POD docs it says:
"The filehandles may also be integers, in which case they are understood as file descriptors."

However IPC::Open3 doesn't handle the file descriptors correctly.
As an example, if we try to dup STDIN in a child process by using it's file descriptor, we get:

perl -MIPC::Open3 -wle 'open3("<&1", my $out, undef, $^X)'
close() on unopened filehandle 1 at /usr/share/perl/5.10/IPC/Open3.pm line 70.
open3: close(1) failed: Bad file descriptor at -e line 1

This is because in IPC::Open3 the subroutines xpipe*, xclose* and xopen don't cater for
descriptors being passed in instead of filehandles.

A simple fix for xclose in version 1.06 is:

Inline Patch

--- Open3-1.06.pm       2010-06-23 00:36:14.000000000 +0100
+++ Open3.pm    2010-07-12 15:53:18.728132480 +0100
@@ -182,5 +182,6 @@

 sub xclose {
-    close $_[0] or croak "$Me: close($_[0]) failed: $!";
+    $_[0] =~ /\A=?(\d+)\z/ ? eval { require POSIX; POSIX::close($1); } : close $_[0]
+        or croak "$Me: close($_[0]) failed: $!";
 }

This patch makes it possible to use open3 in Apache to handle uploads, without it it dies.

Thanx,
Vernon

Flags:
    category=library
    severity=medium
    module=IPC::Open3

Site configuration information for perl 5.10.1:

Configured by Debian Project at Fri Apr 23 07:59:14 UTC 2010.

Summary of my perl5 (revision 5 version 10 subversion 1) configuration:

Platform:
    osname=linux, osvers=2.6.24-27-server, archname=i486-linux-gnu-thread-multi
    uname='linux vernadsky 2.6.24-27-server #1 smp fri mar 12 01:45:06 utc 2010 i686 gnulinux '
    config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.10 -Darchlib=/usr/lib/perl/5.10 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.10.1 -Dsitearch=/usr/local/lib/perl/5.10.1 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.10.1 -Dd_dosuid -des'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -g',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.4.3', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib /usr/lib64
    libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
    perllibs=-ldl -lm -lpthread -lc -lcrypt
    libc=/lib/libc-2.11.1.so, so=so, useshrplib=true, libperl=libperl.so.5.10.1
    gnulibc_version='2.11.1'
Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Locally applied patches:

@INC for perl 5.10.1:
    /etc/perl
    /usr/local/lib/perl/5.10.1
    /usr/local/share/perl/5.10.1
    /usr/lib/perl5
    /usr/share/perl5
    /usr/lib/perl/5.10
    /usr/share/perl/5.10
    /usr/local/lib/site_perl
    .

Environment for perl 5.10.1:
    HOME=/home/vlyon
    LANG=en_GB.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
    PERL_BADLANG (unset)
    SHELL=/bin/bash

_________________________________________________________________
http://clk.atdmt.com/UKM/go/197222280/direct/01/
Do you have a story that started on Hotmail? Tell us now

p5pRT · 2010-09-26T13:46:54Z

From @cpansprout

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle uploads,
without it it dies.

Thank you. I’ve applied this as fb9b5b3.

p5pRT · 2010-09-26T13:46:55Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2010-09-26T13:46:55Z

@cpansprout - Status changed from 'open' to 'resolved'

p5pRT · 2010-09-27T01:21:46Z

From @tonycoz

On Sun Sep 26 06:46:54 2010, sprout wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle uploads,
without it it dies.

Thank you. I’ve applied this as fb9b5b3.

The test for this added in a0ed8b7 fails with PERLIO=stdio:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.01 cusr
0.01 csys = 0.03 CPU)
Result: FAIL

p5pRT · 2010-09-27T11:04:48Z

From @tonycoz

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle uploads,
without it it dies.

Thank you. I’ve applied this as fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.02 cusr 0.00 csys = 0.03 CPU)
Result: FAIL

On Win32 it blocks:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1

unless you supply some input:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
some input
^Z
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 6 wallclock secs ( 0.00 usr + 0.00 sys = 0.00 CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 1 wallclock secs ( 0.01 usr + 0.00 sys = 0.01 CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>

Tony

p5pRT · 2010-09-27T13:48:11Z

From @cpansprout

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem go away?

p5pRT · 2010-09-27T14:24:21Z

From @tonycoz

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via RT wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

p5pRT · 2010-09-27T14:48:34Z

From @cpansprout

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test just
be skipped on Windows?

p5pRT · 2010-09-27T14:48:34Z

From [Unknown Contact. See original ticket]

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test just
be skipped on Windows?

p5pRT · 2010-09-27T15:06:37Z

From @tonycoz

On Mon, Sep 27, 2010 at 07:48:34AM -0700, Father Chrysostomos via RT wrote:

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v ../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test just
be skipped on Windows?

It's trying to reading something (anything!) from stdin:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
any sort of input
more input
^Z
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 13 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report

../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.02 usr + 0.00 sys = 0.02 CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>

It may be the stderr key causing the failure, if I comment it out:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00 CPU)
Result: PASS

C:\Users\tony\dev\perl\git\perl\t>

If I also set stdin => '' then:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr + 0.00 sys = 0.03 CPU)
Result: PASS

Does that warning indicate another issue, or is it expected?

Tony

p5pRT · 2010-09-27T23:53:05Z

From @cpansprout

On Mon Sep 27 08:06:37 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 07:48:34AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via
RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos
via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to
handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on
Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v
../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file
descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem
go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test
just
be skipped on Windows?

It's trying to reading something (anything!) from stdin:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
any sort of input
more input
^Z
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 13 wallclock secs ( 0.00 usr + 0.02 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.02 usr + 0.00 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>

It may be the stderr key causing the failure, if I comment it out:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00
CPU)
Result: PASS

C:\Users\tony\dev\perl\git\perl\t>

If I also set stdin => '' then:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr + 0.00 sys = 0.03
CPU)
Result: PASS

Does that warning indicate another issue, or is it expected?

It’s another issue. Could you file a separate ticket for that?

I’ve added stdin => '' as you suggested and made the test more forgiving
of random stderr output. Can you confirm that
45a1ce9 works?

p5pRT · 2010-09-27T23:53:05Z

From [Unknown Contact. See original ticket]

On Mon Sep 27 08:06:37 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 07:48:34AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via
RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos
via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to
handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on
Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v
../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file
descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem
go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test
just
be skipped on Windows?

It's trying to reading something (anything!) from stdin:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
any sort of input
more input
^Z
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 13 wallclock secs ( 0.00 usr + 0.02 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.02 usr + 0.00 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>

It may be the stderr key causing the failure, if I comment it out:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00
CPU)
Result: PASS

C:\Users\tony\dev\perl\git\perl\t>

If I also set stdin => '' then:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr + 0.00 sys = 0.03
CPU)
Result: PASS

Does that warning indicate another issue, or is it expected?

It’s another issue. Could you file a separate ticket for that?

I’ve added stdin => '' as you suggested and made the test more forgiving
of random stderr output. Can you confirm that
45a1ce9 works?

p5pRT · 2010-09-28T00:18:51Z

From @tonycoz

On Mon, Sep 27, 2010 at 04:53:05PM -0700, Father Chrysostomos via RT wrote:

On Mon Sep 27 08:06:37 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 07:48:34AM -0700, Father Chrysostomos via RT
wrote:

On Mon Sep 27 07:24:21 2010, tonyc wrote:

On Mon, Sep 27, 2010 at 06:48:11AM -0700, Father Chrysostomos via
RT
wrote:

On Mon Sep 27 04:04:48 2010, tonyc wrote:

On Sun, Sep 26, 2010 at 06:46:55AM -0700, Father Chrysostomos
via RT
wrote:

On Mon Jul 12 08:30:07 2010, vernonlyon wrote:

This patch makes it possible to use open3 in Apache to
handle
uploads,
without it it dies.

Thank you. I’ve applied this as
fb9b5b3.

The test added in a0ed8b7 fails with PERLIO=stdio on
Linux:

tony@mars:.../perl/t$ PERLIO=stdio ./perl harness -v
../ext/IPC-
Open3/t/fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 10
not ok 1 - dup STDIN in a child process by using its file
descriptor
Failed 1/1 subtests

Does 0c24d26 make the problem
go away?

It fixes the PERLIO=stdio failure.

It doesn't fix the block (or failure) under Win32.

Tony

I’m not sure how to fix that. Why is it blocking? Should this test
just
be skipped on Windows?

It's trying to reading something (anything!) from stdin:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
any sort of input
more input
^Z
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 13 wallclock secs ( 0.00 usr + 0.02 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
# Failed at t/fd.t line 16
not ok 1 - dup STDIN in a child process by using its file descriptor
Failed 1/1 subtests

Test Summary Report
-------------------
../ext/IPC-Open3/t/fd.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
Files=1, Tests=1, 0 wallclock secs ( 0.02 usr + 0.00 sys = 0.02
CPU)
Result: FAIL

C:\Users\tony\dev\perl\git\perl\t>

It may be the stderr key causing the failure, if I comment it out:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t <nul

../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00
CPU)
Result: PASS

C:\Users\tony\dev\perl\git\perl\t>

If I also set stdin => '' then:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-
Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
Use of uninitialized value in hash element at ../../lib/IPC/Open3.pm
line 399.
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr + 0.00 sys = 0.03
CPU)
Result: PASS

Does that warning indicate another issue, or is it expected?

It’s another issue. Could you file a separate ticket for that?

I’ve added stdin => '' as you suggested and made the test more forgiving
of random stderr output. Can you confirm that
45a1ce9 works?

Thanks, that fixed it:

C:\Users\tony\dev\perl\git\perl\t>.\perl harness -v ..\ext\IPC-Open3\t\fd.t
../ext/IPC-Open3/t/fd.t ..
1..1
ok 1 - dup STDIN in a child process by using its file descriptor
ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00 CPU)
Result: PASS

This should allow Win32 smokes to complete.

Tony

p5pRT · 2011-05-05T18:11:23Z

vlyon@cpan.org - Status changed from 'resolved' to 'open'

p5pRT · 2011-05-05T18:22:53Z

From vlyon@cpan.org

I'm re-opening this ticket, because the patch supplied was misapplied
and it only solves a part of the problem.

1. The correct patch:
sub xclose {
- close $_[0] or croak "$Me: close($_[0]) failed: $!";
+ $_[0] =~ /\A=?(\d+)\z/ ? eval { require POSIX; POSIX::close($1); }
: close $_[0]
+ or croak "$Me: close($_[0]) failed: $!";
}

The "or croak ..." line was never added, please apply this. Thanx.

2. xopen & xpipe:
These 2 subroutines don't handle file descriptors properly.
I'll look into a way to fix xopen, but I doubt I'll be able to fix xpipe.

Vernon

p5pRT · 2011-05-22T20:37:33Z

From @cpansprout

On Thu May 05 11:22:53 2011, vernonlyon wrote:

I'm re-opening this ticket, because the patch supplied was misapplied
and it only solves a part of the problem.

1. The correct patch:
sub xclose {
- close $_[0] or croak "$Me: close($_[0]) failed: $!";
+ $_[0] =~ /\A=?(\d+)\z/ ? eval { require POSIX; POSIX::close($1); }
: close $_[0]
+ or croak "$Me: close($_[0]) failed: $!";
}

The "or croak ..." line was never added, please apply this. Thanx.

Oops. Sorry, that was my fault. Now fixed in f6f8630. But your
original patch did get mangled a bit, so I had to piece it together
manually. Could you send future patches as attachments?

p5pRT · 2011-05-22T20:37:34Z

@cpansprout - Status changed from 'open' to 'resolved'

p5pRT closed this as completed May 22, 2011

p5pRT added Severity Medium distro-Linux hasPatch type-OS-interaction type-library labels Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IPC::Open3 doesn't handle file descriptors correctly #10483

IPC::Open3 doesn't handle file descriptors correctly #10483

p5pRT commented Jul 12, 2010

p5pRT commented Jul 12, 2010

p5pRT commented Sep 26, 2010

p5pRT commented Sep 26, 2010

p5pRT commented Sep 26, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 27, 2010

p5pRT commented Sep 28, 2010

p5pRT commented May 5, 2011

p5pRT commented May 5, 2011

p5pRT commented May 22, 2011

p5pRT commented May 22, 2011

IPC::Open3 doesn't handle file descriptors correctly #10483

IPC::Open3 doesn't handle file descriptors correctly #10483

Comments

p5pRT commented Jul 12, 2010

p5pRT commented Jul 12, 2010

From vlyon@cpan.org

p5pRT commented Sep 26, 2010

From @cpansprout

p5pRT commented Sep 26, 2010

p5pRT commented Sep 26, 2010

p5pRT commented Sep 27, 2010

From @tonycoz

p5pRT commented Sep 27, 2010

From @tonycoz

p5pRT commented Sep 27, 2010

From @cpansprout

p5pRT commented Sep 27, 2010

From @tonycoz

p5pRT commented Sep 27, 2010

From @cpansprout

p5pRT commented Sep 27, 2010

From [Unknown Contact. See original ticket]

p5pRT commented Sep 27, 2010

From @tonycoz

p5pRT commented Sep 27, 2010

From @cpansprout

p5pRT commented Sep 27, 2010

From [Unknown Contact. See original ticket]

p5pRT commented Sep 28, 2010

From @tonycoz

p5pRT commented May 5, 2011

p5pRT commented May 5, 2011

From vlyon@cpan.org

p5pRT commented May 22, 2011

From @cpansprout

p5pRT commented May 22, 2011