Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-dup item_str in p6opaque.pmc #1755

Closed
p6rt opened this issue May 9, 2010 · 5 comments
Closed

de-dup item_str in p6opaque.pmc #1755

p6rt opened this issue May 9, 2010 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented May 9, 2010

Migrated from rt.perl.org#74996 (status was 'resolved')

Searchable as RT74996$

@p6rt
Copy link
Author

p6rt commented May 9, 2010

From plobsing@gmail.com

eliminates warnings when compiling p6opaque.c

@p6rt
Copy link
Author

p6rt commented May 9, 2010

From plobsing@gmail.com

item_str.patch
diff --git a/src/pmc/p6opaque.pmc b/src/pmc/p6opaque.pmc
index 6d04256..3c1718c 100644
--- a/src/pmc/p6opaque.pmc
+++ b/src/pmc/p6opaque.pmc
@@ -67,7 +67,6 @@ static STRING *Perl6Role_str;
 static STRING *postcircumfix_str;
 static STRING *proxy_str;
 static STRING *pun_helper_str;
-static STRING *item_str;
 static STRING *select_str;
 static STRING *Sub_str;
 static STRING *Submethod_str;
@@ -307,7 +306,6 @@ pmclass P6opaque extends Object need_ext dynpmc group perl6_group auto_attrs {
         postcircumfix_str            = CONST_STRING(interp, "postcircumfix:<[ ]>");
         proxy_str                    = CONST_STRING(interp, "proxy");
         pun_helper_str               = CONST_STRING(interp, "!pun_helper");
-        item_str                     = CONST_STRING(interp, "item");
         select_str                   = CONST_STRING(interp, "!select");
         Sub_str                      = CONST_STRING(interp, "Sub");
         Submethod_str                = CONST_STRING(interp, "Submethod");
@@ -400,7 +398,6 @@ back some kind of iterator to let us get all of the possible candidates.
                 !Parrot_str_equal(interp, name, ACCEPTS_str) &&
                 !Parrot_str_equal(interp, name, isa_str) &&
                 !Parrot_str_equal(interp, name, item_str) &&
-                !Parrot_str_equal(interp, name, item_str) &&
                 !Parrot_str_equal(interp, name, defined_str) &&
                 !Parrot_str_equal(interp, name, FETCH_str)) {
             /* Look up closure maker, clone it, attach name and return that. */

@p6rt
Copy link
Author

p6rt commented May 11, 2010

From @moritz

On Sun May 09 11​:18​:48 2010, plobsing@​gmail.com wrote​:

eliminates warnings when compiling p6opaque.c

Thank you very much, applied at efbcce6e8ae07d0fbf4faad88ea5874989226a63

Cheers,
Moritz

@p6rt
Copy link
Author

p6rt commented May 11, 2010

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 11, 2010

@moritz - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed May 11, 2010
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant