New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cygwin-1.7 mount, t/lib/cygwin.t regression #10217
Comments
From cygwin@cygwin.comThis is a bug report for perl from cygwin@cygwin.com, We need to support the new cygwin-1.7 mount syntax From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001 t/lib/cygwin.t | 6 +++--- Inline Patchdiff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
is(Cygwin::is_binmount("/"), $binmode ? 1 : '', "check / for binmount");
my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/, 1, "check cygdrive mount_flags");
# Cygdrive mount prefix
--
Flags: This perlbug was built using Perl 5.10.1 - Fri Dec 18 14:51:24 GMT 2009 Site configuration information for perl 5.11.5: Configured by rurban at Wed Mar 3 17:37:50 GMT 2010. Summary of my perl5 (revision 5 version 11 subversion 5) configuration: Locally applied patches: @INC for perl 5.11.5: Environment for perl 5.11.5: |
From @rurbanPatch as attachment Solves ticket #73382 |
From @rurban0001-Support-cygwin-1.7-mount.patchFrom b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Thu, 4 Mar 2010 17:09:35 +0000
Subject: [PATCH] Support cygwin-1.7 mount
---
t/lib/cygwin.t | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
is(Cygwin::is_binmount("/"), $binmode ? 1 : '', "check / for binmount");
my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/, 1, "check cygdrive mount_flags");
# Cygdrive mount prefix
--
1.6.4.2
|
The RT System itself - Status changed from 'new' to 'open' |
From @rgarciaOn 7 March 2010 11:20, cygwin@cygwin.com <perlbug-followup@perl.org> wrote:
Since the patch only makes the test more forgiving, and is |
@rgs - Status changed from 'open' to 'resolved' |
From @rurbanPatch as attachment Solves ticket #73382 |
From @rurban0001-Support-cygwin-1.7-mount.patch>From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Thu, 4 Mar 2010 17:09:35 +0000
Subject: [PATCH] Support cygwin-1.7 mount
---
t/lib/cygwin.t | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
is(Cygwin::is_binmount("/"), $binmode ? 1 : '', "check / for binmount");
my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/, 1, "check cygdrive mount_flags");
# Cygdrive mount prefix
--
1.6.4.2
|
Migrated from rt.perl.org#73382 (status was 'resolved')
Searchable as RT73382$
The text was updated successfully, but these errors were encountered: