Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cygwin-1.7 mount, t/lib/cygwin.t regression #10217

Closed
p5pRT opened this issue Mar 7, 2010 · 8 comments
Closed

Support cygwin-1.7 mount, t/lib/cygwin.t regression #10217

p5pRT opened this issue Mar 7, 2010 · 8 comments

Comments

@p5pRT
Copy link

p5pRT commented Mar 7, 2010

Migrated from rt.perl.org#73382 (status was 'resolved')

Searchable as RT73382$

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2010

From cygwin@cygwin.com

This is a bug report for perl from cygwin@​cygwin.com,
generated with the help of perlbug 1.39 running under perl 5.11.5.


We need to support the new cygwin-1.7 mount syntax
for the testsuite.

From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Thu, 4 Mar 2010 17​:09​:35 +0000
Subject​: [PATCH] Support cygwin-1.7 mount


t/lib/cygwin.t | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

Inline Patch
diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
 is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
 
 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
 is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");
 
 my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
 is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/,  1, "check cygdrive mount_flags");
 
 # Cygdrive mount prefix
-- 
1.6.4.2

Flags​:
  category=core
  severity=low


This perlbug was built using Perl 5.10.1 - Fri Dec 18 14​:51​:24 GMT 2009
It is being executed now by Perl 5.11.5 - Wed Mar 3 17​:37​:50 GMT 2010.

Site configuration information for perl 5.11.5​:

Configured by rurban at Wed Mar 3 17​:37​:50 GMT 2010.

Summary of my perl5 (revision 5 version 11 subversion 5) configuration​:
  Commit id​: 5a3e69ce9381450c305f461112740cefe42d4684
  Platform​:
  osname=cygwin, osvers=1.7.1(0.21853), archname=cygwin-thread-multi-64int
  uname='cygwin_nt-5.1 reini 1.7.1(0.21853) 2009-12-07 11​:48 i686 cygwin '
  config_args='-de -Dlibperl=cygperl5_11_5@​f1fc40f4.dll -Accflags=-march=pentium4 -Accflags=-mfpmath=sse -Accflags=-mieee-fp -Accflags=-mmmx -Accflags=-msse -Accflags=-msse2 -Dmksymlinks -Dusethreads -Dmad=y -Dusedevel -Doptimize=-O3'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=undef, uselongdouble=undef
  usemymalloc=y, bincompat5005=undef
  Compiler​:
  cc='gcc', ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -march=pentium4 -mfpmath=sse -mieee-fp -mmmx -msse -msse2 -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O3',
  cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -march=pentium4 -mfpmath=sse -mieee-fp -mmmx -msse -msse2 -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.3.4 20090804 (release) 1', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='g++', ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib /lib
  libs=-lgdbm -ldb -ldl -lcrypt -lgdbm_compat
  perllibs=-ldl -lcrypt
  libc=/usr/lib/libc.a, so=dll, useshrplib=true, libperl=cygperl5_11_5@​f1fc40f4.dll
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' --shared -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -L/usr/local/lib -fstack-protector'

Locally applied patches​:
  CYG11 no-bs
  CYG12 no archlib in otherlibdirs
  CYG14 Dynaloader
  CYG15 static-Win32CORE
  CYG17 utf8-paths
  CYG21 LibList-Kid.patch
  CYG22 cygwin-1.7 hints
  CYG23 544-stat
  CYG24 build man pages
  CYG26 Cwd for svk
  Bug#55162 File​::Spec​::case_tolerant performance
  disable ExtUtils​::MakeMaker​::Coverage in Sys-Syslog


@​INC for perl 5.11.5​:
  /usr/lib/perl5/site_perl/5.11.5/i686-cygwin
  /usr/lib/perl5/site_perl/5.11.5
  /usr/lib/perl5/vendor_perl/5.11.5/i686-cygwin
  /usr/lib/perl5/vendor_perl/5.11.5
  /usr/lib/perl5/5.11.5/i686-cygwin
  /usr/lib/perl5/5.11.5
  /usr/lib/perl5/site_perl
  /usr/lib/perl5/vendor_perl
  /usr/lib/perl5/site_perl/5.11
  /usr/lib/perl5/site_perl/5.10
  /usr/lib/perl5/vendor_perl/5.10
  /usr/lib/perl5/site_perl/5.8
  .


Environment for perl 5.11.5​:
  HOME=/home/rurban
  LANG=C.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=~/bin​:/usr/bin​:/usr/sbin​:/usr/local/sbin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/X11R6/bin​:/cygdrive/c/WINDOWS/system32​:/cygdrive/c/WINDOWS​:/usr/bin​:/cyg1/bin​:/cyg1/usr/local/bin​:/cygdrive/c/WINDOWS/System32/Wbem​:/cygdrive/c/Programme/ATI Technologies/ATI.ACE/Core-Static​:/cygdrive/c/Programme/Gemeinsame Dateien/Ulead Systems/MPEG​:/cygdrive/u​:/cygdrive/c/Programme/QuickTime/QTSystem/​:/usr/lib/lapack
  PERL_BADLANG (unset)
  SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2010

From @rurban

Patch as attachment

Solves ticket #73382
META ticket #73298 (But I cannot modify deps there)
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2010

From @rurban

0001-Support-cygwin-1.7-mount.patch
From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Thu, 4 Mar 2010 17:09:35 +0000
Subject: [PATCH] Support cygwin-1.7 mount

---
 t/lib/cygwin.t |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
 is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
 
 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
 is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");
 
 my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
 is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/,  1, "check cygdrive mount_flags");
 
 # Cygdrive mount prefix
-- 
1.6.4.2

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2010

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Mar 8, 2010

From @rgarcia

On 7 March 2010 11​:20, cygwin@​cygwin.com <perlbug-followup@​perl.org> wrote​:

We need to support the new cygwin-1.7 mount syntax
for the testsuite.

From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Thu, 4 Mar 2010 17​:09​:35 +0000
Subject​: [PATCH] Support cygwin-1.7 mount

---
 t/lib/cygwin.t |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@​@​ -44,12 +44,12 @​@​ chdir($pwd);
 is(Cygwin​::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");

 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
 is(Cygwin​::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");

Since the patch only makes the test more forgiving, and is
platform-specific, I applied it to bleadperl now, thanks.

@p5pRT
Copy link
Author

p5pRT commented Mar 8, 2010

@rgs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Mar 8, 2010
@p5pRT
Copy link
Author

p5pRT commented Apr 18, 2010

From @rurban

Patch as attachment

Solves ticket #73382
META ticket #73298 (But I cannot modify deps there)
--
Reini Urban
http​://phpwiki.org/ http​://murbreak.at/

@p5pRT
Copy link
Author

p5pRT commented Apr 18, 2010

From @rurban

0001-Support-cygwin-1.7-mount.patch
>From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Thu, 4 Mar 2010 17:09:35 +0000
Subject: [PATCH] Support cygwin-1.7 mount

---
 t/lib/cygwin.t |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
index 497f381..e4fde17 100644
--- a/t/lib/cygwin.t
+++ b/t/lib/cygwin.t
@@ -44,12 +44,12 @@ chdir($pwd);
 is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
 
 my $mount = join '', `/usr/bin/mount`;
-$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
-my $binmode = $1 eq 'binmode';
+$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
+my $binmode = $1 =~ /binmode|binary/;
 is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");
 
 my $rootmnt = Cygwin::mount_flags("/");
-ok($binmode ? ($rootmnt =~ /,binmode/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
+ok($binmode ? ($rootmnt =~ /,(binmode|binary)/) : ($rootmnt =~ /,textmode/), "check / mount_flags");
 is(Cygwin::mount_flags("/cygdrive") =~ /,cygdrive/,  1, "check cygdrive mount_flags");
 
 # Cygdrive mount prefix
-- 
1.6.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant