Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system troubles #1355

Closed
p6rt opened this issue Oct 9, 2009 · 7 comments
Closed

Build system troubles #1355

p6rt opened this issue Oct 9, 2009 · 7 comments

Comments

@p6rt
Copy link

p6rt commented Oct 9, 2009

Migrated from rt.perl.org#69684 (status was 'resolved')

Searchable as RT69684$

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

From @moritz

There are two new bugs in the build system​:

1) 'make realclean' (sometimes? or on some platforms?) deletes
src/pmc/sigguts.h and the build process fails later on

2) parallel build is broken​:

$ make -j 3
...
cd src/ops && ccache gcc -c -o perl6_ops.o
-I/home/moritz/rakudo/parrot_install/include/1.6.0-devel
-I/home/moritz/rakudo/parrot_install/include/1.6.0-devel/pmc
-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -pipe -I/usr/local/include
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHASATTRIBUTE_CONST
-DHASATTRIBUTE_DEPRECATED -DHASATTRIBUTE_MALLOC -DHASATTRIBUTE_NONNULL
-DHASATTRIBUTE_NORETURN -DHASATTRIBUTE_PURE -DHASATTRIBUTE_UNUSED
-DHASATTRIBUTE_WARN_UNUSED_RESULT -falign-functions=16
-fvisibility=hidden -funit-at-a-time -maccumulate-outgoing-args -W -Wall
-Waggregate-return -Wcast-align -Wcast-qual -Wchar-subscripts -Wcomment
-Wdisabled-optimization -Wendif-labels -Wextra -Wformat
-Wformat-extra-args -Wformat-nonliteral -Wformat-security -Wformat-y2k
-Wimplicit -Wimport -Winit-self -Winline -Winvalid-pch -Wlogical-op
-Wmissing-braces -Wmissing-field-initializers
-Wno-missing-format-attribute -Wmissing-include-dirs -Wpacked
-Wparentheses -Wpointer-arith -Wreturn-type -Wsequence-point -Wno-shadow
-Wsign-compare -Wstrict-aliasing -Wstrict-aliasing=2 -Wswitch
-Wswitch-default -Wtrigraphs -Wundef -Wunknown-pragmas -Wno-unused
-Wvariadic-macros -Wwrite-strings -Wbad-function-cast -Wc++-compat
-Wdeclaration-after-statement -Werror=declaration-after-statement
-Wimplicit-function-declaration -Wimplicit-int -Wmain
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wnonnull
-DDISABLE_GC_DEBUG=1 -DNDEBUG -O2 -g -DHAS_GETTEXT -fPIC
-DHAVE_COMPUTED_GOTO perl6_ops.c
perl6_ops.c​:29​:38​: error​: ../pmc/pmc_p6lowlevelsig.h​: No such file or
directory
perl6.ops​: In function ‘Parrot_allocate_signature_p_i’​:
perl6.ops​:408​: warning​: implicit declaration of function
‘SETATTR_P6LowLevelSig_elements’
perl6.ops​:408​: warning​: nested extern declaration of
‘SETATTR_P6LowLevelSig_elements’
perl6.ops​:411​: warning​: implicit declaration of function
‘SETATTR_P6LowLevelSig_num_elements’
perl6.ops​:411​: warning​: nested extern declaration of
‘SETATTR_P6LowLevelSig_num_elements’
perl6.ops​: In function ‘Parrot_get_signature_size_i_p’​:
perl6.ops​:431​: warning​: implicit declaration of function
‘GETATTR_P6LowLevelSig_num_elements’
perl6.ops​:431​: warning​: nested extern declaration of
‘GETATTR_P6LowLevelSig_num_elements’
perl6.ops​: In function ‘Parrot_set_signature_elem_p_i_s_i_p_p_p_p’​:
perl6.ops​:468​: warning​: implicit declaration of function
‘GETATTR_P6LowLevelSig_elements’
perl6.ops​:468​: warning​: nested extern declaration of
‘GETATTR_P6LowLevelSig_elements’
make​: *** [src/ops/perl6_ops.so] Error 1
make​: *** Waiting for unfinished jobs....

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

From @Util

On Fri Oct 09 08​:16​:57 2009, moritz wrote​:

There are two new bugs in the build system​:

1) 'make realclean' (sometimes? or on some platforms?) deletes
src/pmc/sigguts.h and the build process fails later on

2) parallel build is broken​:

1) I think that this part is already fixed, perhaps by the recent move
of sigguts.h from src/pmc/ to src/binder/.

2) Fixed in my RT_69684 branch. Patch attached.

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

From @Util

0001-RT-69684-Fixed-parallel-build-by-adding-dependency.patch
From b7687a8ce2db0b6376589c08e9887aed41dfaddf Mon Sep 17 00:00:00 2001
From: Bruce Gray <bruce@bruce-grays-computer-2.local>
Date: Sat, 10 Oct 2009 23:03:57 -0500
Subject: [PATCH] RT#69684 Fixed parallel build by adding dependency.

---
 build/Makefile.in |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build/Makefile.in b/build/Makefile.in
index bd25255..a3251eb 100644
--- a/build/Makefile.in
+++ b/build/Makefile.in
@@ -432,12 +432,12 @@ $(DYNPMC): $(PMC_SOURCES) src/binder/sigguts.h
 	cd $(PMC_DIR) && $(CC) -c $(CINCLUDES) $(CFLAGS) *.c
 	$(LD) @ld_out@$(DYNPMC) $(GROUP)$(O) src/pmc/*$(O) $(LINKARGS)
 
-$(OPS_DIR)/$(OPS)$(LOAD_EXT): $(OPS_DIR)/$(OPS_SOURCE) src/binder/sigguts.h src/binder/bind$(O)
+$(OPS_DIR)/$(OPS)$(LOAD_EXT): $(OPS_DIR)/$(OPS_SOURCE) src/binder/sigguts.h src/binder/bind$(O) $(DYNPMC)
 	cd $(OPS_DIR) && $(OPS2C) C --dynamic $(OPS_SOURCE)
 	cd $(OPS_DIR) && $(CC) -c @cc_o_out@$(OPS)$(O) $(CINCLUDES) $(CFLAGS) $(OPS).c
 	cd $(OPS_DIR) && $(LD) @ld_out@$(OPS)$(LOAD_EXT) $(OPS)$(O) ../binder/bind$(O) $(LINKARGS)
 
-$(OPS_DIR)/$(OPS)_switch$(LOAD_EXT): $(OPS_DIR)/$(OPS_SOURCE) src/binder/sigguts.h src/binder/bind$(O)
+$(OPS_DIR)/$(OPS)_switch$(LOAD_EXT): $(OPS_DIR)/$(OPS_SOURCE) src/binder/sigguts.h src/binder/bind$(O) $(DYNPMC)
 	cd $(OPS_DIR) && $(OPS2C) CSwitch --dynamic $(OPS_SOURCE)
 	cd $(OPS_DIR) && $(CC) -c @cc_o_out@$(OPS)_switch$(O) $(CINCLUDES) $(CFLAGS) $(OPS)_switch.c
 	cd $(OPS_DIR) && $(LD) @ld_out@$(OPS)_switch$(LOAD_EXT) $(OPS)_switch$(O) ../binder/bind$(O) $(LINKARGS)
-- 
1.6.1.2

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

From @moritz

Hi,

Bruce Gray via RT wrote​:

On Fri Oct 09 08​:16​:57 2009, moritz wrote​:

There are two new bugs in the build system​:

1) 'make realclean' (sometimes? or on some platforms?) deletes
src/pmc/sigguts.h and the build process fails later on

2) parallel build is broken​:

1) I think that this part is already fixed, perhaps by the recent move
of sigguts.h from src/pmc/ to src/binder/.

Actually it was a once-only bug. In the patch where jonathan introduced
sigguts.h he also changed 'make realclean' not to delete it. But when
somebody would first pull and then 'make realclean', it would disappear
once.

2) Fixed in my RT_69684 branch. Patch attached.

Thank you very much, applied and pushed as
e5562c90e4bc421b562f68f8fa1ddc1e776eab12. Solves the problem for me.

Cheers,
Moritz

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

From @kyleha

On Sat Oct 10 22​:53​:42 2009, util wrote​:

2) Fixed in my RT_69684 branch. Patch attached.

I can confirm that this worked for me just now. Thank you!!

@p6rt
Copy link
Author

p6rt commented Oct 11, 2009

@moritz - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Oct 11, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant