Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures don't advertise required parameters as required when serialized with .perl in Rakudo #1225

Closed
p6rt opened this issue Aug 14, 2009 · 6 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Aug 14, 2009

Migrated from rt.perl.org#68524 (status was 'resolved')

Searchable as RT68524$

@p6rt
Copy link
Author

p6rt commented Aug 14, 2009

From @masak

<masak> rakudo​: sub foo(​:$a!) {}; say &foo.signature.perl
<p6eval> rakudo 0d4fe0​: OUTPUT«​:(Any :$a)␤»

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

From @kyleha

This is an automatically generated mail to inform you that tests are now available in t/spec/S06-signature/named-parameters.t

commit 5ca328e331568e1e30309e8ecef1151fecba019b
Author​: kyle <kyle@​c213334d-75ef-0310-aa23-eaa082d1ae64>
Date​: Fri Oct 9 16​:51​:50 2009 +0000

  [t/spec] Test for RT #​68524
 
  git-svn-id​: http://svn.pugscode.org/pugs@&#8203;28678 c213334d-75ef-0310-aa23-eaa082d1ae64

Inline Patch
diff --git a/t/spec/S06-signature/named-parameters.t b/t/spec/S06-signature/named-parameters.t
index 83efe31..8fff210 100644
--- a/t/spec/S06-signature/named-parameters.t
+++ b/t/spec/S06-signature/named-parameters.t
@@ -1,7 +1,7 @@
 use v6;
 use Test;
 
-plan 76;
+plan 77;
 
 # L<S06/Required parameters/"Passing a named argument that cannot be bound to
 # a normal subroutine is also a fatal error.">
@@ -220,4 +220,12 @@ ok(%fellowship<dwarf> ~~ undef, "dwarf arg was not given");
 #?rakudo todo 'RT #68086'
 eval_dies_ok 'sub rt68086( $a, $a ) { }', 'two sub params with the same name';
 
+# RT #68524
+#?rakudo todo 'RT 68524'
+{
+    sub rt68524( :$a! ) {}
+    ok( &rt68524.signature.perl ~~ m/\!/,
+        '.signature.perl with required parameter includes requirement' );
+}
+
 # vim: ft=perl6

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

From @jnthn

On Fri Aug 14 14​:07​:16 2009, masak wrote​:

<masak> rakudo​: sub foo(​:$a!) {}; say &foo.signature.perl
<p6eval> rakudo 0d4fe0​: OUTPUT«​:(Any :$a)␤»

Fixed in git 174e0d6, during re-write of Signature.perl into the
setting. Assigning to moritz++ for spectests.

Thanks,

Jonathan

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

From @kyleha

The test for this passes now, so I'm marking it resolved.

@p6rt
Copy link
Author

p6rt commented Oct 9, 2009

@kyleha - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Oct 9, 2009
@p6rt p6rt added the Bug label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant