Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakudo doesn't parse embedded comments inside the <> part of <[]> constructs in rules #1113

Closed
p6rt opened this issue Jul 1, 2009 · 6 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Jul 1, 2009

Migrated from rt.perl.org#67124 (status was 'resolved')

Searchable as RT67124$

@p6rt
Copy link
Author

p6rt commented Jul 1, 2009

From @masak

<masak> rakudo​: say "foo" ~~ /<[f] #[comment] + [o]>/
<p6eval> rakudo 5351a3​: OUTPUT«perl6regex parse error​: Error parsing
enumerated character class at offset 30, found '[ [...]
<masak> pmichaud​: I posit that this should work.
<pmichaud> pge doesn't understand embedded comments.
<masak> it does outside of <>.
<pmichaud> right
<masak> rakudo​: say "foo" ~~ / fo #[ comment here! ] o /
<p6eval> rakudo 5351a3​: OUTPUT«foo␤»
<pmichaud> huh.
<pmichaud> well, it's very likely that the part that parses <[ ... ]>
doesn't understand them then.
  [15​:10]
<pmichaud> std​: /<[f] #[comment] + [o]>/
<p6eval> std 27351​: OUTPUT«ok 00​:03 36m␤»
* masak submits rakudobug

@p6rt
Copy link
Author

p6rt commented Jul 5, 2009

From @kyleha

This is an automatically generated mail to inform you that tests are now available in t/t/spec/S05-metasyntax/charset.t

@p6rt
Copy link
Author

p6rt commented Jul 5, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 29, 2012

From @diakopter

On Wed Jul 01 06​:13​:49 2009, masak wrote​:

<masak> rakudo​: say "foo" ~~ /<[f] #[comment] + [o]>/
<p6eval> rakudo 5351a3​: OUTPUT«perl6regex parse error​: Error parsing
enumerated character class at offset 30, found '[ [...]
<masak> pmichaud​: I posit that this should work.
<pmichaud> pge doesn't understand embedded comments.
<masak> it does outside of <>.
<pmichaud> right
<masak> rakudo​: say "foo" ~~ / fo #[ comment here! ] o /
<p6eval> rakudo 5351a3​: OUTPUT«foo␤»
<pmichaud> huh.
<pmichaud> well, it's very likely that the part that parses <[ ... ]>
doesn't understand them then.
[15​:10]
<pmichaud> std​: /<[f] #[comment] + [o]>/
<p6eval> std 27351​: OUTPUT«ok 00​:03 36m␤»
* masak submits rakudobug

new behavior​:

17​:35 <diakopter> rakudo​: say "foo" ~~ /<[f] #[comment] + [o]>/
17​:35 <p6eval> rakudo 024843​: OUTPUT«===SORRY!===␤regex assertion not
terminated by angle
  bracket at line 2, near ""␤»

@p6rt
Copy link
Author

p6rt commented Nov 8, 2013

From @FROGGS

<FROGGS> p​: say "foo" ~~ /<[f] #`[comment] + [o]>/
<camelia> rakudo-parrot 9d8349​: OUTPUT«「f」␤␤»
<FROGGS> p​: say "foo" ~~ /<[f] #`[comment] + [o]>+/
<camelia> rakudo-parrot 9d8349​: OUTPUT«「foo」␤␤»

Tests at​: Raku/roast@62fa996#diff-3

@p6rt
Copy link
Author

p6rt commented Nov 8, 2013

@FROGGS - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Nov 8, 2013
@p6rt p6rt added the Bug label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant