Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/PARROT_REVISION embeds a newline on Win32, makes --gen-parrot fail #899

Closed
p6rt opened this issue Apr 18, 2009 · 4 comments
Closed

build/PARROT_REVISION embeds a newline on Win32, makes --gen-parrot fail #899

p6rt opened this issue Apr 18, 2009 · 4 comments
Labels
patch

Comments

@p6rt
Copy link

p6rt commented Apr 18, 2009

Migrated from rt.perl.org#64816 (status was 'resolved')

Searchable as RT64816$
@p6rt
Copy link
Author

p6rt commented Apr 18, 2009

From @cosimo

I'm on Win32.
Got a fresh checkout of rakudo from git repo just now.

Running `perl Configure.PL --gen-parrot' fails for me
because build/PARROT_REVISION contains a DOS newline,
so the final svn checkout command for parrot fails.

  svn checkout -r37980^M ...

This is my small fix to build/gen_parrot.pl​:

-------8<-------------------------

Inline Patch 
diff --git a/build/gen_parrot.pl b/build/gen_parrot.pl
index a77223a..c4ccac8 100644
--- a/build/gen_parrot.pl
+++ b/build/gen_parrot.pl
@@ -27,7 +27,9 @@ my $slash = $^O eq 'MSWin32' ? '\\' : '/';
 ##  determine what revision of Parrot we require
 open my $REQ, "build/PARROT_REVISION"
   || die "cannot open build/PARROT_REVISION\n";
-my $required = <$REQ>; chomp $required;
+my $required = <$REQ>; # chomp $required;
+# Remove the DOS newline or svn checkout command chokes
+$required =~ s{[\s\r\n]}{}gm;
 close $REQ;
-------8<-------------------------

--

Cosimo

@p6rt
Copy link
Author

p6rt commented Apr 18, 2009

From @pmichaud

This should be fixed in afd8ff1.

Thanks!

Pm

1 similar comment
@p6rt
Copy link
Author

p6rt commented Apr 18, 2009

From @pmichaud

This should be fixed in afd8ff1.

Thanks!

Pm

@p6rt
Copy link
Author

p6rt commented Apr 18, 2009

@pmichaud - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Apr 18, 2009
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p6rt