Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change option name to --gen-parrot-option; minor related cleanups #861

Closed
p6rt opened this issue Apr 4, 2009 · 4 comments
Closed

Change option name to --gen-parrot-option; minor related cleanups #861

p6rt opened this issue Apr 4, 2009 · 4 comments

Comments

@p6rt
Copy link

p6rt commented Apr 4, 2009

Migrated from rt.perl.org#64460 (status was 'resolved')

Searchable as RT64460$

@p6rt
Copy link
Author

p6rt commented Apr 4, 2009

From @japhb


Configure.pl | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)

Inline Patch
diff --git a/Configure.pl b/Configure.pl
index 6e24616..7b5f2d5 100644
--- a/Configure.pl
+++ b/Configure.pl
@@ -8,7 +8,8 @@ use Getopt::Long;
 
 MAIN: {
     my %options;
-    GetOptions(\%options, 'help!', 'parrot-config=s', 'gen-parrot!', 'parrot-opt=s@');
+    GetOptions(\%options, 'help!', 'parrot-config=s',
+               'gen-parrot!', 'gen-parrot-option=s@');
 
     # Print help if it's requested
     if ($options{'help'}) {
@@ -18,7 +19,7 @@ MAIN: {
 
     # Update/generate parrot build if needed
     if ($options{'gen-parrot'}) {
-        my @opts    = $options{'parrot-opt'} ? @{$options{'parrot-opt'}} : ();
+        my @opts    = @{ $options{'gen-parrot-option'} || {} };
         my @command = ($^X, "build/gen_parrot.pl", @opts);
 
         print "Generating Parrot ...\n";
@@ -127,10 +128,10 @@ Configure.pl - Rakudo Configure
 General Options:
     --help             Show this text
     --gen-parrot       Download and build a copy of Parrot to use
+    --gen-parrot-option='--option=value'
+                       Set parrot config option when using --gen-parrot
     --parrot-config=(config)
                        Use configuration information from config
-    --parrot-opt='--option=value'
-                       Set parrot config option when using --gen-parrot
 END
 
     return;
-- 
1.6.2.1

@p6rt
Copy link
Author

p6rt commented Apr 4, 2009

From @moritz

Applied, thanks.

On Sat Apr 04 09​:10​:45 2009, japhb wrote​:

---
Configure.pl | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Configure.pl b/Configure.pl
index 6e24616..7b5f2d5 100644
--- a/Configure.pl
+++ b/Configure.pl
@​@​ -8,7 +8,8 @​@​ use Getopt​::Long;

MAIN​: {
my %options;
- GetOptions(\%options, 'help!', 'parrot-config=s', 'gen-parrot!',
'parrot-opt=s@​');
+ GetOptions(\%options, 'help!', 'parrot-config=s',
+ 'gen-parrot!', 'gen-parrot-option=s@​');

 \# Print help if it's requested
 if \($options\{'help'\}\) \{

@​@​ -18,7 +19,7 @​@​ MAIN​: {

 \# Update/generate parrot build if needed
 if \($options\{'gen\-parrot'\}\) \{

- my @​opts = $options{'parrot-opt'} ? @​{$options{'parrot-
opt'}} : ();
+ my @​opts = @​{ $options{'gen-parrot-option'} || {} };
my @​command = ($^X, "build/gen_parrot.pl", @​opts);

     print "Generating Parrot \.\.\.\\n";

@​@​ -127,10 +128,10 @​@​ Configure.pl - Rakudo Configure
General Options​:
--help Show this text
--gen-parrot Download and build a copy of Parrot to use
+ --gen-parrot-option='--option=value'
+ Set parrot config option when using
--gen-parrot
--parrot-config=(config)
Use configuration information from config
- --parrot-opt='--option=value'
- Set parrot config option when using
--gen-parrot
END

 return;

@p6rt
Copy link
Author

p6rt commented Apr 4, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Apr 4, 2009

@moritz - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant