Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No subject provided #730

Closed
p6rt opened this issue Feb 28, 2009 · 8 comments
Closed

No subject provided #730

p6rt opened this issue Feb 28, 2009 · 8 comments

Comments

@p6rt
Copy link

p6rt commented Feb 28, 2009

Migrated from rt.perl.org#63566 (status was 'resolved')

Searchable as RT63566$

@p6rt
Copy link
Author

p6rt commented Feb 28, 2009

From @bacek

From 116eec4b249f6917187741053006763f96d22496 Mon Sep 17 00​:00​:00 2001
From​: Vasily Chekalkin <bacek@​bacek.com>
Date​: Sun, 1 Mar 2009 09​:08​:30 +1100
Subject​: [PATCH] Fix handling verbosity in t/harness


t/harness | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Inline Patch
diff --git a/t/harness b/t/harness
index 1b42bea..6637ebe 100644
--- a/t/harness
+++ b/t/harness
@@ -19,7 +19,7 @@ $Test::Harness::switches = '';
 GetOptions(
     'tests-from-file=s' => \my $list_file,
     'fudge'             => \my $do_fudge,
-    'verbosity=i'       => \my $verbosity,
+    'verbosity=i'       => \$Test::Harness::verbose,
     'jobs:3'            => \my $jobs,
 );
 my @pass_through_options = grep m/^--?[^-]/, @ARGV;
-- 
1.6.0.1

@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

From @pmichaud

On Sat Feb 28 15​:56​:13 2009, bacek wrote​:

From 116eec4b249f6917187741053006763f96d22496 Mon Sep 17 00​:00​:00 2001
From​: Vasily Chekalkin <bacek@​bacek.com>
Date​: Sun, 1 Mar 2009 09​:08​:30 +1100
Subject​: [PATCH] Fix handling verbosity in t/harness

---
t/harness | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/harness b/t/harness
index 1b42bea..6637ebe 100644
--- a/t/harness
+++ b/t/harness
@​@​ -19,7 +19,7 @​@​ $Test​::Harness​::switches = '';
GetOptions(
'tests-from-file=s' => \my $list_file,
'fudge' => \my $do_fudge,
- 'verbosity=i' => \my $verbosity,
+ 'verbosity=i' => \$Test​::Harness​::verbose,
'jobs​:3' => \my $jobs,
);
my @​pass_through_options = grep m/^--?[^-]/, @​ARGV;

....does this patch work even if someone is running TAP​::Harness instead
of Test​::Harness ?

Pm

@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

From @bacek

Patrick R. Michaud via RT wrote​:

....does this patch work even if someone is running TAP​::Harness instead
of Test​::Harness ?

Probably no. But current t/harness explicitly use Test​::Harness.

--
Bacek

@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

From @pmichaud

Patch applied in 023bb60, thanks!

Pm

1 similar comment
@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

From @pmichaud

Patch applied in 023bb60, thanks!

Pm

@p6rt p6rt closed this as completed Mar 1, 2009
@p6rt
Copy link
Author

p6rt commented Mar 1, 2009

@pmichaud - Status changed from 'open' to 'resolved'

@p6rt
Copy link
Author

p6rt commented Mar 2, 2009

From @pmichaud

On Sun, Mar 01, 2009 at 10​:38​:01AM -0800, Patrick R. Michaud via RT wrote​:

Patch applied in 023bb60, thanks!

I should also note that Test​::Harness 3 actually uses TAP​::Harness,
and that Test​::Harness becomes a somewhat backwards-compatible interface
for TAP​::Harness.

Pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant