Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PCT::HLLCompiler.addstage() #717

Closed
p6rt opened this issue Feb 23, 2009 · 7 comments
Closed

use PCT::HLLCompiler.addstage() #717

p6rt opened this issue Feb 23, 2009 · 7 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Feb 23, 2009

Migrated from rt.perl.org#63408 (status was 'resolved')

Searchable as RT63408$

@p6rt
Copy link
Author

p6rt commented Feb 23, 2009

From @chrisdolan

This trivial patch to perl6.pir changes Perl6​::Compiler to use its
superclass' addstage() mutator instead of directly editing the
@​stages attribute. This should make for better forward
compatibility, as it avoids repeating the list of stages.

@p6rt
Copy link
Author

p6rt commented Feb 23, 2009

From @chrisdolan

addstage.patch
diff --git a/perl6.pir b/perl6.pir
index a7245c4..ac78526 100644
--- a/perl6.pir
+++ b/perl6.pir
@@ -37,9 +37,8 @@ Creates the Perl 6 compiler by subclassing a C<PCT::HLLCompiler> object.
     perl6.'parsegrammar'('Perl6::Grammar')
     perl6.'parseactions'('Perl6::Grammar::Actions')
 
-    ##  set the compilation stages in the @stages attribute
-    $P0 = split ' ', 'parse past check_syntax post pir evalpmc'
-    setattribute perl6, '@stages', $P0
+    ##  insert the check_syntax compilation stage
+    perl6.'addstage'('check_syntax', 'after' => 'past')
 
     ##  set the command line options
     $P0 = split ' ', 'c e=s help|h target=s trace|t=s encoding=s output|o=s version|v'

@p6rt
Copy link
Author

p6rt commented Feb 25, 2009

From @pmichaud

On Sun, Feb 22, 2009 at 06​:53​:33PM -0800, Chris Dolan wrote​:

This trivial patch to perl6.pir changes Perl6​::Compiler to use its
superclass' addstage() mutator instead of directly editing the
@​stages attribute. This should make for better forward
compatibility, as it avoids repeating the list of stages.

Note that the entire stages interface and implementation
are expected to change soon.

Pm

@p6rt
Copy link
Author

p6rt commented Feb 25, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 16, 2011

From @tadzik

On Sun Feb 22 18​:53​:32 2009, chris@​chrisdolan.net wrote​:

This trivial patch to perl6.pir changes Perl6​::Compiler to use its
superclass' addstage() mutator instead of directly editing the
@​stages attribute. This should make for better forward
compatibility, as it avoids repeating the list of stages.

https://github.com/rakudo/rakudo/blob/master/src/Perl6/Compiler.pir#L162

The current implementation seems to use addstage, is the ticket closable?

@p6rt
Copy link
Author

p6rt commented May 17, 2011

From @chrisdolan

Yes, closeable. Thanks.
Chris

"Tadeusz SoÅ�nierz via RT" <perl6-bugs-followup@​perl.org> wrote​:

On Sun Feb 22 18​:53​:32 2009, chris@​chrisdolan.net wrote​: > This trivial patch to perl6.pir changes Perl6​::Compiler to use its > superclass' addstage() mutator instead of directly editing the > @​stages attribute. This should make for better forward > compatibility, as it avoids repeating the list of stages. > https://github.com/rakudo/rakudo/blob/master/src/Perl6/Compiler.pir#L162 The current implementation seems to use addstage, is the ticket closable?

@p6rt
Copy link
Author

p6rt commented May 17, 2011

@moritz - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed May 17, 2011
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant