From @bacek

Hello.

Trivial patch for Array.elems attached.

Quote from spectest​:

t/spec/S29-array/elems.rakudo (Wstat​: 0
Tests​: 12 Failed​: 0)
  TODO passed​: 11

--
Bacek

From @bacek

commit 72dd10b10602af5126441df0d266dccd353cb6c2
Author: Vasily Chekalkin <bacek@bacek.com>
Date:   Mon Dec 22 22:52:32 2008 +1100

    Implement Array.elems

diff --git a/languages/perl6/src/classes/Array.pir b/languages/perl6/src/classes/Array.pir
index f855fee..6037458 100644
--- a/languages/perl6/src/classes/Array.pir
+++ b/languages/perl6/src/classes/Array.pir
@@ -14,7 +14,7 @@ src/classes/Array.pir - Perl 6 Array class and related functions
     arrayproto.'!MUTABLE'()
 
     $P0 = get_hll_namespace ['Perl6Array']
-    '!EXPORT'('delete,exists,pop,push,shift,unshift', 'from'=>$P0)
+    '!EXPORT'('delete,elems,exists,pop,push,shift,unshift', 'from'=>$P0)
 .end
 
 =head2 Methods
@@ -59,6 +59,16 @@ Remove items from an array.
     .return (result)
 .end
 
+=item elems
+
+Return the number of elements in the array.
+
+=cut
+
+.sub 'elems' :method :multi(Perl6Array)
+    $I0 = self
+    .return ($I0)
+.end
 
 =item exists(indices :slurpy)
 

From @pmichaud

On Mon, Dec 22, 2008 at 04​:15​:20AM -0800, Vasily Chekalkin wrote​:

Trivial patch for Array.elems attached.

As far as I can tell, Array.elems already works in trunk without
the patch. Is there a specific test or set of tests this enables,
or a case that isn't being handled?

Pm

The RT System itself - Status changed from 'new' to 'open'

From @bacek

Patrick R. Michaud via RT wrote​:

On Mon, Dec 22, 2008 at 04​:15​:20AM -0800, Vasily Chekalkin wrote​:

Trivial patch for Array.elems attached.

As far as I can tell, Array.elems already works in trunk without
the patch. Is there a specific test or set of tests this enables,
or a case that isn't being handled?

This is from S29-array/elems.t

#?rakudo todo 'elems on Array ref'
{
  is (elems [1,2,3,4]), 4, "elems [1,2,3,4] should work";
}

It passed with patch, but I'm not sure that test is correct.

--
Bacek

From @pmichaud

Patch rejected; this will be better fixed when we have a settings-based
implementation of elems (which will be able to properly handle the binding).

Thanks!

Pm

@pmichaud - Status changed from 'open' to 'rejected'