Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readline calls after merging pdd22 branch #473

Closed
p6rt opened this issue Dec 9, 2008 · 5 comments
Closed

Fix readline calls after merging pdd22 branch #473

p6rt opened this issue Dec 9, 2008 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Dec 9, 2008

Migrated from rt.perl.org#61212 (status was 'resolved')

Searchable as RT61212$

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

From @bacek

Hello.

Trivial patch attached.

--
Bacek

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

From @bacek

readline.patch
commit 49d24a4d7994458b9efb3a234acad59c937298ed
Author: Vasily Chekalkin <bacek@bacek.com>
Date:   Tue Dec 9 21:54:47 2008 +1100

    Fix io.readline calls

diff --git a/languages/perl6/src/classes/IO.pir b/languages/perl6/src/classes/IO.pir
index 6dd5f28..be67b70 100644
--- a/languages/perl6/src/classes/IO.pir
+++ b/languages/perl6/src/classes/IO.pir
@@ -90,7 +90,7 @@ Reads a line from the file handle.
 .sub 'readline' :method
     .local pmc PIO
     PIO = getattribute self, "$!PIO"
-    $P0 = PIO.'readline'('')
+    $P0 = PIO.'readline'()
     .return ($P0)
 .end
 
@@ -223,7 +223,7 @@ Return the value inside this container in item context.
     .local pmc pio
     $P0 = getattribute self, "$!IO"
     pio = getattribute $P0, "$!PIO"
-    $P0 = pio.'readline'("")
+    $P0 = pio.'readline'()
     .return($P0)
 .end
 

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

From @jnthn

On Tue Dec 09 03​:08​:45 2008, bacek wrote​:

Trivial patch attached.

...and applied in r33704.

Thanks!

Jonathan

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Dec 9, 2008
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant