Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test::is_deeply #472

Closed
p6rt opened this issue Dec 9, 2008 · 5 comments
Closed

Fix Test::is_deeply #472

p6rt opened this issue Dec 9, 2008 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Dec 9, 2008

Migrated from rt.perl.org#61210 (status was 'resolved')

Searchable as RT61210$

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

From @bacek

Hello.

Trivial patch for is_deeply to proper call proclaim.

--
Bacek

@p6rt
Copy link
Author

p6rt commented Dec 9, 2008

From @bacek

test.patch
commit 0ac2699b5a70a0c19bdc7477ee1c1cb7eb168797
Author: Vasily Chekalkin <bacek@bacek.com>
Date:   Tue Dec 9 21:53:16 2008 +1100

    Fix Test.pm is_deeply to call 'proclaim' properly

diff --git a/languages/perl6/Test.pm b/languages/perl6/Test.pm
index e7cf0cf..6478e49 100644
--- a/languages/perl6/Test.pm
+++ b/languages/perl6/Test.pm
@@ -147,12 +147,12 @@ multi sub eval_lives_ok($code) is export() {
 
 multi sub is_deeply($this, $that, $reason) {
     my $val = _is_deeply( $this, $that );
-    proclaim( $val, $reason, $this.perl, $that.perl );
+    proclaim($val, $reason);
 }
 
 multi sub is_deeply($this, $that) {
     my $val = _is_deeply( $this, $that );
-    proclaim( $val, '', $this.perl, $that.perl );
+    proclaim($val, '');
 }
 
 sub _is_deeply( $this, $that) {

@p6rt
Copy link
Author

p6rt commented Dec 12, 2008

From @moritz

On Tue Dec 09 03​:06​:50 2008, bacek wrote​:

Hello.

Trivial patch for is_deeply to proper call proclaim.

Good catch, applied as r33829. Thank you.

Moritz

@p6rt
Copy link
Author

p6rt commented Dec 12, 2008

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Dec 12, 2008

@moritz - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Dec 12, 2008
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant