From @bacek

Hello.

There is suggestion from Pm for Str.chop

+.sub 'chop' :method
+ len = length tmps
+ if len == 0 goto done
+ dec len
+ substr tmps,tmps, 0, len
...

PIR has a C<chop> opcode, perhaps we should use it?

--
Bacek

From @azawawi

Hi bacek,

Here is the patch for it.

To test it, please use​:
./perl6 t/spec/S29-str/chop.rakudo

Index​: src/builtins/any-str.pir

--- src/builtins/any-str.pir (revision 31539)
+++ src/builtins/any-str.pir (working copy)
@​@​ -98,16 +98,10 @​@​
.sub 'chop' :method :multi(_)
  .local string tmps
  .local pmc retv
- .local int len

- retv = new 'Perl6Str'
  tmps = self
-
- len = length tmps
- if len == 0 goto done
- dec len
- substr tmps,tmps, 0, len
- done​:
+ chopn tmps, 1
+ retv = new 'Perl6Str'
  retv = tmps
  .return(retv)
.end

The RT System itself - Status changed from 'new' to 'open'

From @moritz

On Wed Oct 01 03​:55​:19 2008, ahmadz wrote​:

Here is the patch for it.

Thanks, applied as r31541.

To test it, please use​:
./perl6 t/spec/S29-str/chop.rakudo

I prefer 'make fulltest', because sometimes changes have unexpected
non-local effects.

(and fulltest also runs codetest, which I tend to forget otherwise).

@moritz - Status changed from 'open' to 'resolved'