Slurpy params give "Cannot morph a Perl6Scalar." error #255

p6rt · 2008-08-22T22:16:03Z

Migrated from rt.perl.org#58278 (status was 'resolved')

Searchable as RT58278$

p6rt · 2008-08-22T22:16:04Z

From @moritz

r30449:

sub a(*@b) { say @b.elems }; a(1, 2, 3)
Cannot morph a Perl6Scalar.

Note that the passing itself doesn't throw an error:

sub a(*@b) { }; a(1, 2, 3)

Clearly we need more tests...

--
Moritz Lenz
http://moritz.faui2k3.org/ | http://perl-6.de/

p6rt · 2008-08-22T22:39:26Z

From @moritz

r30449:

sub a(*@b) { say @b.elems }; a(1, 2, 3)
Cannot morph a Perl6Scalar.

Note that the passing itself doesn't throw an error:

sub a(*@b) { }; a(1, 2, 3)

Clearly we need more tests...

Now added test in t/spec/S06-signature/slurpy-params.t which rakudo all
fails

--
Moritz Lenz
http://moritz.faui2k3.org/ | http://perl-6.de/

p6rt · 2008-09-07T10:12:27Z

From @bacek

On Fri Aug 22 15:39:26 2008, moritz@casella.verplant.org wrote:

Now added test in t/spec/S06-signature/slurpy-params.t which rakudo all
fails

There is small patch, that makes first 6 tests from slurpy-params.t
pass. Unfortunately it brakes Exception passing as params.

So, question is: "is this patch totally insane or we should add method
'item' to Exception?"

--
Bacek.

p6rt · 2008-09-07T10:12:27Z

From @bacek

signature.patch

diff --git a/languages/perl6/src/parser/actions.pm b/languages/perl6/src/parser/actions.pm
index 349f433..8f76c67 100644
--- a/languages/perl6/src/parser/actions.pm
+++ b/languages/perl6/src/parser/actions.pm
@@ -1068,9 +1068,10 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar", %0',
-                            '    $P0 = get_hll_global ["Bool"], "True"',
-                            '    setprop %r, "readonly", $P0'
+                            '    $P0 = %0."item"()',
+                            '    %r = new "Perl6Scalar", $P0',
+                            '    $P1 = get_hll_global ["Bool"], "True"',
+                            '    setprop %r, "readonly", $P1'
                         ),
                         PAST::Var.new(
                             :name($parameter.name()),
@@ -1089,8 +1090,7 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar"',
-                            '    %r."infix:="(%0)'
+                            '    %r = clone %0'
                         ),
                         PAST::Var.new(
                             :name($parameter.name()),

p6rt · 2008-09-07T10:12:30Z

The RT System itself - Status changed from 'new' to 'open'

p6rt · 2008-09-09T14:11:21Z

From @bacek

Hello.

There is patch that fixes this error (and makes first 6 tests from
S06/slurpy-params.t passing). Unfortunately it triggers bug from #58718

--
Bacek.

p6rt · 2008-09-09T14:11:21Z

From @bacek

signature.patch

diff --git a/languages/perl6/src/parser/actions.pm b/languages/perl6/src/parser/actions.pm
index 349f433..27ddcd0 100644
--- a/languages/perl6/src/parser/actions.pm
+++ b/languages/perl6/src/parser/actions.pm
@@ -1068,7 +1068,8 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar", %0',
+                            '    %r = new "Perl6Scalar"',
+                            '    %r."infix:="(%0)',
                             '    $P0 = get_hll_global ["Bool"], "True"',
                             '    setprop %r, "readonly", $P0'
                         ),
@@ -1089,8 +1090,7 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar"',
-                            '    %r."infix:="(%0)'
+                            '    %r = clone %0'
                         ),
                         PAST::Var.new(
                             :name($parameter.name()),

p6rt · 2008-09-09T14:12:54Z

From @bacek

Hello.

There is patch that fixes this error (and makes first 6 tests from
S06/slurpy-params.t passing). Unfortunately it triggers bug from #58718

--
Bacek.

p6rt · 2008-09-09T14:12:54Z

From @bacek

signature.patch

diff --git a/languages/perl6/src/parser/actions.pm b/languages/perl6/src/parser/actions.pm
index 349f433..27ddcd0 100644
--- a/languages/perl6/src/parser/actions.pm
+++ b/languages/perl6/src/parser/actions.pm
@@ -1068,7 +1068,8 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar", %0',
+                            '    %r = new "Perl6Scalar"',
+                            '    %r."infix:="(%0)',
                             '    $P0 = get_hll_global ["Bool"], "True"',
                             '    setprop %r, "readonly", $P0'
                         ),
@@ -1089,8 +1090,7 @@ method signature($/) {
                     ),
                     PAST::Op.new(
                         :inline(
-                            '    %r = new "Perl6Scalar"',
-                            '    %r."infix:="(%0)'
+                            '    %r = clone %0'
                         ),
                         PAST::Var.new(
                             :name($parameter.name()),

p6rt · 2008-09-09T15:15:51Z

From @pmichaud

Patch rejected; the patch appears to eliminate "Perl6Scalar"
entirely from the 'is copy' semantics, this means we'd be without
an appropriate Scalar container for something like

sub foo($a is copy) { ... }

In general I think much of the signature handling in Rakudo needs
a significant refactor, so I'm a bit reluctant to apply small
tweaks until that happens.

Thanks!

Pm

@@ -1089,8 +1090,7 @@ method signature($/) {
),
PAST::Op.new(
:inline(
- ' %r = new "Perl6Scalar"',
- ' %r."infix:="(%0)'
+ ' %r = clone %0'
),
PAST::Var.new(
:name($parameter.name()),

p6rt · 2008-12-09T14:23:04Z

From @jnthn

On Fri Aug 22 15:39:26 2008, moritz@casella.verplant.org wrote:

r30449:

sub a(*@b) { say @b.elems }; a(1, 2, 3)
Cannot morph a Perl6Scalar.

Note that the passing itself doesn't throw an error:

sub a(*@b) { }; a(1, 2, 3)

Clearly we need more tests...

Now added test in t/spec/S06-signature/slurpy-params.t which rakudo all
fails

We now pass all of them apart from the typed arrays one, which is a
separate issue, so making ticket resolved.

Thanks,

Jonathan

p6rt · 2008-12-09T14:23:07Z

@jnthn - Status changed from 'open' to 'resolved'

p6rt closed this as completed Dec 9, 2008

p6rt added the Bug label Jan 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Slurpy params give "Cannot morph a Perl6Scalar." error #255

Slurpy params give "Cannot morph a Perl6Scalar." error #255

p6rt commented Aug 22, 2008

p6rt commented Aug 22, 2008

p6rt commented Aug 22, 2008

p6rt commented Sep 7, 2008

p6rt commented Sep 7, 2008

p6rt commented Sep 7, 2008

p6rt commented Sep 9, 2008

p6rt commented Sep 9, 2008

p6rt commented Sep 9, 2008

p6rt commented Sep 9, 2008

p6rt commented Sep 9, 2008

p6rt commented Dec 9, 2008

p6rt commented Dec 9, 2008

Slurpy params give "Cannot morph a Perl6Scalar." error #255

Slurpy params give "Cannot morph a Perl6Scalar." error #255

Comments

p6rt commented Aug 22, 2008

p6rt commented Aug 22, 2008

From @moritz

p6rt commented Aug 22, 2008

From @moritz

p6rt commented Sep 7, 2008

From @bacek

p6rt commented Sep 7, 2008

From @bacek

p6rt commented Sep 7, 2008

p6rt commented Sep 9, 2008

From @bacek

p6rt commented Sep 9, 2008

From @bacek

p6rt commented Sep 9, 2008

From @bacek

p6rt commented Sep 9, 2008

From @bacek

p6rt commented Sep 9, 2008

From @pmichaud

p6rt commented Dec 9, 2008

From @jnthn

p6rt commented Dec 9, 2008