From jswitzer@gmail.com

Recent changes to the S29-trig tests have them properly fudged and passing
as of revision 29865. The attached file is the patch to the
spectest_regression to add them to the regression tests.

Thanks,

Jason "s1n" Switzer

From jswitzer@gmail.com

Index: spectest_regression.data
===================================================================
--- spectest_regression.data	(revision 29865)
+++ spectest_regression.data	(working copy)
@@ -116,3 +116,5 @@
 S29-str/sprintf.t
 S29-str/ucfirst.t
 S29-str/uc.t
+S29-trig/e.t
+S29-trig/trig.t

From jswitzer@gmail.com

Check out pmichaud's comment on #​44211. This implies the S29-trig/e.t
test may no longer be a part of STD.

jswitzer@gmail.com - Status changed from 'new' to 'open'

From @moritz

jason switzer (via RT) wrote​:

Recent changes to the S29-trig tests have them properly fudged and passing
as of revision 29865. The attached file is the patch to the
spectest_regression to add them to the regression tests.

Thanks for your good work.

However I'm reluctant to add the test for Num​::e because e shouldn't be
available initially. To quote http://perlcabal.org/syn/S29.html#Num

Num provides a number of constants in addition to the basic mathematical
functions. To get these constants, you must request them​:

use Num :constants;

or use the full name, e.g. Num​::pi.

I notice that it's the same issue for pi, but there the probability of
name clashes isn't as high as for e.
So I'll wait for the time when Rakudo implements 'use' meaningfully, and
when the test is re-worked to adhere to the current spec.

I did add trig.t to spectest_regression though (r29906).

Cheers,
Moritz

--
Moritz Lenz
http://moritz.faui2k3.org/ | http://perl-6.de/

From @pmichaud

Can this ticket be closed?

Pm

From @moritz

Patrick R. Michaud via RT wrote​:

Can this ticket be closed?

I'd say we stall it until the :trig tag export works for the
trigonometric functions.

Moritz

--
Moritz Lenz
http://perlgeek.de/ | http://perl-6.de/ | http://sudokugarden.de/

@moritz - Status changed from 'open' to 'stalled'

From @jnthn

On Thu Nov 13 14​:03​:20 2008, moritz@​casella.verplant.org wrote​:

Patrick R. Michaud via RT wrote​:

Can this ticket be closed?

I'd say we stall it until the :trig tag export works for the
trigonometric functions.

I've seen that we have :Trig working now in p6eval; do we have tests
covering that, and can we now close this?

Thanks,

Jonathan

The RT System itself - Status changed from 'stalled' to 'open'

From @jnthn

On Fri May 01 10​:38​:19 2009, jnthn@​jnthn.net wrote​:

On Thu Nov 13 14​:03​:20 2008, moritz@​casella.verplant.org wrote​:

Patrick R. Michaud via RT wrote​:

Can this ticket be closed?

I'd say we stall it until the :trig tag export works for the
trigonometric functions.

I've seen that we have :Trig working now in p6eval; do we have tests
covering that, and can we now close this?

PhatEddy++ just confirmed on IRC that the tests use :Trig; resolving ticket.

Thanks!

Jonathan

@jnthn - Status changed from 'open' to 'resolved'