Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The presence of $_ in programs produces an error #114

Closed
p6rt opened this issue Jun 2, 2008 · 10 comments
Closed

The presence of $_ in programs produces an error #114

p6rt opened this issue Jun 2, 2008 · 10 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Jun 2, 2008

Migrated from rt.perl.org#55184 (status was 'resolved')

Searchable as RT55184$

@p6rt
Copy link
Author

p6rt commented Jun 2, 2008

From @masak

<masak> jonathan​: how come `./perl6 -e '$_'` gives the error "too few
arguments passed (0) - 1 params expected"?
[...]
<jonathan> masak​: Please submit a ticket about that.
<masak> jonathan​: oki
[...]
<pmichaud> I think it's that $_ is causing the outer sub to have a parameter
<masak> how sinister
<pmichaud> yes, it's a rakudo bug

@p6rt
Copy link
Author

p6rt commented Jun 16, 2008

From @masak

The attached patch fixes the bug #​55184​: "The presence of $_ in
programs produces an error", reported a while back.

<http://rt.perl.org/rt3//Public/Bug/Display.html?id=55184>

It's a limited fix, and I'd be happy to hear how it could be improved.
All rakudo tests pass after the patch has been applied.

Cheers,
// Carl

@p6rt
Copy link
Author

p6rt commented Jun 16, 2008

From @masak

patch_fixing_bug_55184

@p6rt
Copy link
Author

p6rt commented Jun 16, 2008

From @coke

On Mon Jun 16 07​:48​:41 2008, cmasak@​gmail.com wrote​:

The attached patch fixes the bug #​55184​: "The presence of $_ in
programs produces an error", reported a while back.

<http://rt.perl.org/rt3//Public/Bug/Display.html?id=55184>

It's a limited fix, and I'd be happy to hear how it could be improved.
All rakudo tests pass after the patch has been applied.

Cheers,
// Carl

Merging this into the original ticket.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Jun 16, 2008

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jun 19, 2008

From @pmichaud

On Mon Jun 16 07​:48​:41 2008, cmasak@​gmail.com wrote​:

The attached patch fixes the bug #​55184​: "The presence of $_ in
programs produces an error", reported a while back.

<http://rt.perl.org/rt3//Public/Bug/Display.html?id=55184>

It's a limited fix, and I'd be happy to hear how it could be improved.
All rakudo tests pass after the patch has been applied.

Thanks for the patch; I'm rejecting it (or at least placing it on hold)
for now because I don't like promoting the __FLAG_VARIABLE meme that is
rapidly spreading itself throughout the code. (It reminds me of the way
that references to 'infix​:,' ended up proliferating throughout actions.pm.)

All of the $_, $!, and $/ handling in Rakudo needs to be refactored; at
this point I'd rather place things on hold for that refactor than add
even more code to the burden. (I'm expecting to get to the refactor in
the next 4-5 days.)

Thanks again!

Pm

@p6rt
Copy link
Author

p6rt commented Jun 19, 2008

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jun 20, 2008

From @masak

Patrick (>), Carl (>>)​:

The attached patch fixes the bug #​55184​: "The presence of $_ in
programs produces an error", reported a while back.

<http://rt.perl.org/rt3//Public/Bug/Display.html?id=55184>

It's a limited fix, and I'd be happy to hear how it could be improved.
All rakudo tests pass after the patch has been applied.

Thanks for the patch; I'm rejecting it (or at least placing it on hold)
for now because I don't like promoting the __FLAG_VARIABLE meme that is
rapidly spreading itself throughout the code.

Understandable. If nothing else, the making of this patch has given me
some insights into rakudo guts, which must be a good thing.

All of the $_, $!, and $/ handling in Rakudo needs to be refactored; at
this point I'd rather place things on hold for that refactor than add
even more code to the burden. (I'm expecting to get to the refactor in
the next 4-5 days.)

Looking forward to that refactoring. Keep up the good work!

// Carl

@p6rt
Copy link
Author

p6rt commented Jul 4, 2008

From @pmichaud

Now fixed in r29042 -- thanks!

Pm

@p6rt
Copy link
Author

p6rt commented Jul 4, 2008

@pmichaud - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jul 4, 2008
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant