From @cognominal

# grammars don't behave as regular classes.
# I would expect A.WHAT to exist and to behave like with a regular class
# and be able to use A.a in a smart match

class B {}; say B.WHAT;
grammar A { token a { a } }; # say A.WHAT; ==> Method 'WHAT' not
found for non-object

say 'a' ~~ A.a; # ==> Method 'a' not found for non-object

--
cognominal stef

From @cognominal

running the code with --target=pir, I see that the 'token a' regex
is generated as a method with an empty namespace.

--
cognominal stef

From @jnthn

Stéphane Payrard wrote​:

running the code with --target=pir, I see that the 'token a' regex
is generated as a method with an empty namespace.

As far as I'm aware, the grammar keyword isn't properly implemented yet
(it'll parse, but that's probably about it).

Jonathan

The RT System itself - Status changed from 'new' to 'open'

From @cognominal

On Thu, Apr 17, 2008 at 10​:20 PM, Jonathan Worthington via RT
<perl6-bugs-followup@​perl.org> wrote​:

Stéphane Payrard wrote​:

running the code with --target=pir, I see that the 'token a' regex
is generated as a method with an empty namespace.

As far as I'm aware, the grammar keyword isn't properly implemented yet
(it'll parse, but that's probably about it).

Jonathan

There is not much missing.

The following patch already gets .WHAT to work.
The code for grammar methods is apparently correctly generated except
for the namespace.

grammar A { token aa { baba } }; say A.WHAT;

Index​: languages/perl6/src/parser/actions.pm

--- languages/perl6/src/parser/actions.pm (revision 27021)
+++ languages/perl6/src/parser/actions.pm (working copy)
@​@​ -796,11 +796,11 @​@​
  if $key eq 'open' {
  # Start of the block; if it's a class or role, need to make $?CLASS or
  # $?ROLE available for storing current definition in.
- if $&lt;sym&gt; eq 'class' || $&lt;sym> eq 'role' {
+ if $&lt;sym&gt; eq 'class' || $&lt;sym> eq 'role' || $<sym> eq 'grammar' {
  my $decl_past := PAST​::Stmts.new();

  # If it's a class...
- if $<sym> eq 'class' {
+ if $&lt;sym&gt; eq 'class' || $&lt;sym> eq 'grammar' {
  # Call method to create the class.
  $decl_past.push(PAST​::Op.new(
  :pasttype('bind'),
@​@​ -914,7 +914,7 @​@​
  $past.blocktype('declaration');
  $past.pirflags('​:init :load');

- if $<sym> eq 'class' {
+ if $&lt;sym&gt; eq 'class' || $&lt;sym> eq 'grammar' {
  # Make proto-object.
  $?CLASS.push(PAST​::Op.new(
  :pasttype('call'),

--
cognominal stef

From @jnthn

Hi,

I've now made grammars a whole lot more class like. They get
proto-objects and inheritance works too, plus the regexen go in the
correct namespaces. There is some work to do getting Foo​::bar to work
now (where Foo is a grammar name and bar is a regex name in the
grammar), but that's a separate issue that hits classes and grammars
just as equally.

So I think the issues this ticket wanted to have addressed have been
sorted out now. :-)

Thanks!

Jonathan

@jnthn - Status changed from 'open' to 'resolved'