New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock opcode too weak #908
Comments
From dan@sidhe.orgThe lock opcode is too weak. If the main::lock gv exists for any reason, Perl Info
|
From [Unknown Contact. See original ticket]At 04:00 PM 12/1/99 -0500, Dan Sugalski wrote:
Of course, the question is what to do about this? Part of me's tempted to have toke.c check the CV slot to see if there's Of course, there's the part that's thinking this'll all be moot as of 5.6 Dan ----------------------------------------"it's like this"------------------- |
From @gsarOn Wed, 01 Dec 1999 16:00:41 EST, Dan Sugalski wrote:
Try this. Sarathy Inline Patch-----------------------------------8<-----------------------------------
Change 4643 by gsar@auger on 1999/12/04 21:55:27
make weak keyword check look for defined(&lock), not
merely defined(*lock)
Affected files ...
... //depot/perl/toke.c#167 edit
Differences ...
==== //depot/perl/toke.c#167 (text) ====
Index: perl/toke.c
--- perl/toke.c.~1~ Sat Dec 4 13:55:32 1999
+++ perl/toke.c Sat Dec 4 13:55:32 1999
@@ -3502,6 +3502,7 @@
}
else if (gv && !gvp
&& -tmp==KEY_lock /* XXX generalizable kludge */
+ && GvCVu(gv)
&& !hv_fetch(GvHVn(PL_incgv), "Thread.pm", 9, FALSE))
{
tmp = 0; /* any sub overrides "weak" keyword */
End of Patch. |
From [Unknown Contact. See original ticket]At 01:57 PM 12/4/99 -0800, Gurusamy Sarathy wrote:
Cool. The one thing I was thinking of instead of this was a runtime If we plan on introducing other 'weak' opcodes it makes sense, otherwise it Dan ----------------------------------------"it's like this"------------------- |
Migrated from rt.perl.org#1843 (status was 'resolved')
Searchable as RT1843$
The text was updated successfully, but these errors were encountered: